Skip to content

Read from single column shard #14614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

zverevgeny
Copy link
Collaborator

Changelog entry <!-- a user-readable short description of the changes that goes to CHANGELOG.md and Release

Read from a single columntable shard

Changelog category

  • Experimental feature

@zverevgeny zverevgeny requested review from a team as code owners February 16, 2025 07:01
@zverevgeny zverevgeny changed the title Read from single olap shard (prototype)Read from single olap shard Feb 16, 2025
Copy link

github-actions bot commented Feb 16, 2025

2025-02-16 07:05:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for 05e2de2 has started.
2025-02-16 07:05:34 UTC Artifacts will be uploaded here
2025-02-16 07:08:40 UTC ya make is running...
🟡 2025-02-16 08:37:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28080 25487 0 2 2456 135

2025-02-16 08:40:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-16 08:52:22 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 75 0 0 1 128

🟢 2025-02-16 08:52:29 UTC Build successful.
🟡 2025-02-16 08:52:47 UTC ydbd size 2.1 GiB changed* by +204.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0fc5672 merge: 05e2de2 diff diff %
ydbd size 2 235 760 576 Bytes 2 235 969 664 Bytes +204.2 KiB +0.009%
ydbd stripped size 473 726 360 Bytes 473 768 024 Bytes +40.7 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 16, 2025

2025-02-16 07:05:40 UTC Pre-commit check linux-x86_64-release-asan for 05e2de2 has started.
2025-02-16 07:05:53 UTC Artifacts will be uploaded here
2025-02-16 07:09:03 UTC ya make is running...
🟡 2025-02-16 08:44:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13863 13758 0 55 15 35

2025-02-16 08:45:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-16 09:08:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 113 0 4 5 31

2025-02-16 09:08:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-16 09:20:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
70 (only retried tests) 32 0 4 3 31

🟢 2025-02-16 09:20:15 UTC Build successful.
🟢 2025-02-16 09:20:42 UTC ydbd size 3.6 GiB changed* by -84.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fc5672 merge: 05e2de2 diff diff %
ydbd size 3 889 569 312 Bytes 3 889 482 392 Bytes -84.9 KiB -0.002%
ydbd stripped size 1 361 122 224 Bytes 1 361 441 136 Bytes +311.4 KiB +0.023%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny changed the title (prototype)Read from single olap shard (prototype)Read from single column shard Feb 16, 2025
@@ -80,12 +80,14 @@ struct TKqpReadTableSettings {
static constexpr TStringBuf SequentialSettingName = "Sequential";
static constexpr TStringBuf ForcePrimaryName = "ForcePrimary";
static constexpr TStringBuf GroupByFieldNames = "GroupByFieldNames";
static constexpr TStringBuf ShardIdName = "ShardId";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю TabletID, т.к. такое название уже используется в partition_stats:
https://ydb.yandex-team.ru/docs/dev/system-views#partitions

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переименовал в TabletId. Взял точное написание из доки. Отличается от твоего предложения в последней букве

@zverevgeny zverevgeny force-pushed the read_single_shard_by_id branch from fa01226 to 00a5df8 Compare March 7, 2025 17:21
Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 17:23:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for c7baca7 has started.
2025-03-07 17:23:36 UTC Artifacts will be uploaded here
2025-03-07 17:26:39 UTC ya make is running...
🟡 2025-03-07 18:52:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28196 25614 0 2 2465 115

2025-03-07 18:55:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 19:05:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 60 0 0 0 103

🟢 2025-03-07 19:06:05 UTC Build successful.
🟢 2025-03-07 19:06:23 UTC ydbd size 2.1 GiB changed* by +11.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c7ef100 merge: c7baca7 diff diff %
ydbd size 2 294 683 704 Bytes 2 294 695 136 Bytes +11.2 KiB +0.000%
ydbd stripped size 480 604 736 Bytes 480 606 784 Bytes +2.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 7, 2025

2025-03-07 17:25:28 UTC Pre-commit check linux-x86_64-release-asan for c7baca7 has started.
2025-03-07 17:25:43 UTC Artifacts will be uploaded here
2025-03-07 17:28:56 UTC ya make is running...
🟡 2025-03-07 19:14:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13787 13614 0 112 24 37

2025-03-07 19:15:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 19:31:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
238 (only retried tests) 194 0 5 6 33

2025-03-07 19:31:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 19:43:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 45 0 0 1 30

🟢 2025-03-07 19:43:35 UTC Build successful.
🟢 2025-03-07 19:44:03 UTC ydbd size 3.7 GiB changed* by +26.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c7ef100 merge: c7baca7 diff diff %
ydbd size 3 996 187 888 Bytes 3 996 214 520 Bytes +26.0 KiB +0.001%
ydbd stripped size 1 389 175 240 Bytes 1 389 183 048 Bytes +7.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 10:00:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28cbfbf has started.
2025-03-08 10:00:47 UTC Artifacts will be uploaded here
2025-03-08 10:02:09 UTC Check cancelled

Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 10:00:39 UTC Pre-commit check linux-x86_64-release-asan for 28cbfbf has started.
2025-03-08 10:00:54 UTC Artifacts will be uploaded here
2025-03-08 10:02:09 UTC Check cancelled

@zverevgeny zverevgeny force-pushed the read_single_shard_by_id branch from 27e218f to 7605fee Compare March 8, 2025 10:01
Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 10:04:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 07f57bc has started.
2025-03-08 10:04:16 UTC Artifacts will be uploaded here
2025-03-08 10:07:19 UTC ya make is running...
🟡 2025-03-08 11:33:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28200 25612 0 3 2469 116

2025-03-08 11:36:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-08 11:48:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 60 0 0 0 108

🟢 2025-03-08 11:48:39 UTC Build successful.
🟡 2025-03-08 11:48:58 UTC ydbd size 2.1 GiB changed* by +179.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c7ef100 merge: 07f57bc diff diff %
ydbd size 2 294 683 704 Bytes 2 294 866 984 Bytes +179.0 KiB +0.008%
ydbd stripped size 480 604 736 Bytes 480 612 928 Bytes +8.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 8, 2025

2025-03-08 10:05:45 UTC Pre-commit check linux-x86_64-release-asan for 07f57bc has started.
2025-03-08 10:06:00 UTC Artifacts will be uploaded here
2025-03-08 10:09:02 UTC ya make is running...
🟡 2025-03-08 11:45:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13787 13633 0 81 39 34

2025-03-08 11:47:09 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-08 12:01:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 173 0 1 1 33

2025-03-08 12:01:18 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-08 12:13:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 33 0 0 0 31

🟢 2025-03-08 12:13:15 UTC Build successful.
🟡 2025-03-08 12:13:41 UTC ydbd size 3.7 GiB changed* by +370.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: c7ef100 merge: 07f57bc diff diff %
ydbd size 3 996 187 888 Bytes 3 996 567 728 Bytes +370.9 KiB +0.010%
ydbd stripped size 1 389 175 240 Bytes 1 389 205 672 Bytes +29.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@gridnevvvit gridnevvvit removed the request for review from a team March 8, 2025 17:41
} else if (name == TKqpReadTableSettings::TabletIdName) {
YQL_ENSURE(tuple.Ref().ChildrenSize() == 2);
settings.TabletId = FromString<ui64>(tuple.Value().Cast<TCoAtom>().Value());
}else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

пробела не хватает

@zverevgeny zverevgeny linked an issue Mar 10, 2025 that may be closed by this pull request
@zverevgeny zverevgeny changed the title (prototype)Read from single column shard Read from single column shard Mar 10, 2025
@zverevgeny zverevgeny merged commit 59ab890 into ydb-platform:main Mar 10, 2025
14 checks passed
Copy link

🟢 2025-03-10 06:54:26 UTC The validation of the Pull Request description is successful.

@naspirato naspirato mentioned this pull request Mar 11, 2025
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Mar 21, 2025
Conflicts:
	ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select from single shard
5 participants