-
Notifications
You must be signed in to change notification settings - Fork 657
Read from single column shard #14614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read from single column shard #14614
Conversation
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
ydb/core/kqp/common/kqp_yql.h
Outdated
@@ -80,12 +80,14 @@ struct TKqpReadTableSettings { | |||
static constexpr TStringBuf SequentialSettingName = "Sequential"; | |||
static constexpr TStringBuf ForcePrimaryName = "ForcePrimary"; | |||
static constexpr TStringBuf GroupByFieldNames = "GroupByFieldNames"; | |||
static constexpr TStringBuf ShardIdName = "ShardId"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Предлагаю TabletID, т.к. такое название уже используется в partition_stats:
https://ydb.yandex-team.ru/docs/dev/system-views#partitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Переименовал в TabletId. Взял точное написание из доки. Отличается от твоего предложения в последней букве
fa01226
to
00a5df8
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
27e218f
to
7605fee
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
} else if (name == TKqpReadTableSettings::TabletIdName) { | ||
YQL_ENSURE(tuple.Ref().ChildrenSize() == 2); | ||
settings.TabletId = FromString<ui64>(tuple.Value().Cast<TCoAtom>().Value()); | ||
}else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
пробела не хватает
🟢 |
Conflicts: ydb/core/kqp/ut/olap/kqp_olap_ut.cpp
Changelog entry <!-- a user-readable short description of the changes that goes to CHANGELOG.md and Release
Read from a single columntable shard
Changelog category