Skip to content

Ingore basic scheme limits for internal operations #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Feb 19, 2025

Changelog entry

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Hacky solution for inability to import a database from a backup that was successfully created. Shard limit might be broken on import. Probably due to the index building. We decided to ignore the shard limits if the operation is a child of the import operation (i.e. is internal).

Copy link

github-actions bot commented Feb 19, 2025

🟢 2025-02-20 11:01:13 UTC The validation of the Pull Request description is successful.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@jepett0 jepett0 marked this pull request as ready for review February 20, 2025 10:56
@jepett0 jepett0 requested a review from a team as a code owner February 20, 2025 10:56
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 11:30:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for f058088 has started.
2025-02-20 11:51:12 UTC Artifacts will be uploaded here
2025-02-20 11:54:36 UTC ya make is running...
🟡 2025-02-20 13:30:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28042 25443 0 2 2463 134

2025-02-20 13:33:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 13:54:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 79 0 0 1 128

🟢 2025-02-20 13:55:02 UTC Build successful.
🟢 2025-02-20 13:55:22 UTC ydbd size 2.1 GiB changed* by +2.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a69e43 merge: f058088 diff diff %
ydbd size 2 239 403 032 Bytes 2 239 405 688 Bytes +2.6 KiB +0.000%
ydbd stripped size 474 529 336 Bytes 474 529 592 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 11:32:37 UTC Pre-commit check linux-x86_64-release-asan for f058088 has started.
2025-02-20 11:32:48 UTC Artifacts will be uploaded here
2025-02-20 11:36:14 UTC ya make is running...
🟡 2025-02-20 13:12:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13803 13724 0 29 13 37

2025-02-20 13:14:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 13:27:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
124 (only retried tests) 85 0 0 7 32

🟢 2025-02-20 13:27:33 UTC Build successful.
🟢 2025-02-20 13:28:06 UTC ydbd size 3.6 GiB changed* by +4.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a69e43 merge: f058088 diff diff %
ydbd size 3 895 485 704 Bytes 3 895 490 392 Bytes +4.6 KiB +0.000%
ydbd stripped size 1 364 012 320 Bytes 1 364 013 280 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 merged commit d1adfd1 into ydb-platform:main Feb 21, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operations issued internally on 'ydb import' should be able to complete despite breaking scheme limits
2 participants