Skip to content

Make DEFAULT_EVENTS_PER_MAILBOX unreachable #14843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 20, 2025

Changelog entry

EVENTS_PER_MAILBOX only make problems with high-load sessions. We made this limit unreachable for stopping processing only by time quote.

Changelog category

  • Improvement

Description for reviewers

...

@kruall kruall added the area/actorsystem Actor System related issues label Feb 20, 2025
@kruall kruall requested a review from alexvru February 20, 2025 13:41
Copy link

github-actions bot commented Feb 20, 2025

🟢 2025-02-20 15:00:59 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 13:55:52 UTC Pre-commit check linux-x86_64-release-asan for 8e8d59f has started.
2025-02-20 13:55:56 UTC Artifacts will be uploaded here
2025-02-20 13:59:13 UTC ya make is running...
2025-02-20 14:00:45 UTC Check cancelled

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 13:56:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e8d59f has started.
2025-02-20 13:57:17 UTC Artifacts will be uploaded here
2025-02-20 14:00:41 UTC Check cancelled

Copy link

2025-02-20 14:05:09 UTC Pre-commit check linux-x86_64-release-asan for 8e8d59f has started.

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 14:06:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e8d59f has started.
2025-02-20 14:06:21 UTC Artifacts will be uploaded here
2025-02-20 14:09:41 UTC ya make is running...
2025-02-20 15:02:03 UTC Check cancelled

@kruall kruall added the rebase-and-check Rebase PR with the current base branch and check label Feb 20, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 20, 2025
Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 15:05:40 UTC Pre-commit check linux-x86_64-relwithdebinfo for 11e266c has started.
2025-02-20 15:05:52 UTC Artifacts will be uploaded here
2025-02-20 15:09:12 UTC ya make is running...
🟡 2025-02-20 16:03:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28375 25608 0 167 2460 140

2025-02-20 16:06:05 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 16:27:25 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
382 (only retried tests) 246 0 0 11 125

🟢 2025-02-20 16:27:35 UTC Build successful.
🟢 2025-02-20 16:27:53 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8e57514 merge: 11e266c diff diff %
ydbd size 2 239 511 352 Bytes 2 239 511 352 Bytes 0 Bytes 0.000%
ydbd stripped size 474 551 896 Bytes 474 551 896 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 20, 2025

2025-02-20 15:07:00 UTC Pre-commit check linux-x86_64-release-asan for 11e266c has started.
2025-02-20 15:07:34 UTC Artifacts will be uploaded here
2025-02-20 15:11:22 UTC ya make is running...
🟡 2025-02-20 16:54:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14074 13977 0 49 14 34

2025-02-20 16:56:57 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 17:09:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 107 0 0 2 34

🟢 2025-02-20 17:09:43 UTC Build successful.
🟢 2025-02-20 17:10:10 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8e57514 merge: 11e266c diff diff %
ydbd size 3 895 673 176 Bytes 3 895 673 080 Bytes -96 Bytes -0.000%
ydbd stripped size 1 364 069 600 Bytes 1 364 069 536 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall merged commit 2b1cfa7 into ydb-platform:main Feb 20, 2025
26 of 35 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
naspirato added a commit that referenced this pull request Mar 8, 2025
@naspirato naspirato mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/actorsystem Actor System related issues improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants