Add config node init command #14869
Add config node init command #14869
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
|
||
| TCommandNodeConfig::TCommandNodeConfig() | ||
| : TClientCommandTree("config", {}, "Node-wide configuration") | ||
| { |
| } | ||
| Cerr << "Failed to save configs: " | ||
| << (clusterSaved ? "" : "main config ") | ||
| << (storageSaved ? "and " : "storage config") |
There was a problem hiding this comment.
А что если clusterSaved = false, а storageSaved = true
There was a problem hiding this comment.
Все равно должна выдаваться ошибка. То что там теперь лежит бесполезный файл storage не должно никак повлиять, так как это файлы только для системы
There was a problem hiding this comment.
Я про текст ошибки:
"Failed to save configs: main config and "
There was a problem hiding this comment.
Понял, поторопился)
| bool clusterSaved = false; | ||
| bool storageSaved = false; | ||
|
|
||
| if (hasCluster && hasStorage) { |
There was a problem hiding this comment.
На мой взгляд ниже много boilerplate кода, по куче раз конфиги сохраняем. Лучше в как-то в одном месте сделать, и потом писать вывод на основе того, что пытались сохранить, что получилось сохранить.
Но тут скорее на твое усмотрение и на усмотрение @pnv1
Changelog entry
Add config node init command
Changelog category
Description for reviewers
...