Skip to content

Workaround for batch processing of transactions #14874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Feb 21, 2025

Changelog entry

Transactions can be executed simultaneously. In this case, when the predicate is calculated, SeqNo is not promoted for SourceId. We decided to temporarily disable simultaneous execution of transactions.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

The Transactions_Conflict_On_SeqNo test reproduced the error from the client. Transaction patching has been temporarily disabled.

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner February 21, 2025 04:35
Copy link

github-actions bot commented Feb 21, 2025

🟢 2025-02-24 08:41:58 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 04:39:12 UTC Pre-commit check linux-x86_64-release-asan for d50209a has started.
2025-02-21 04:39:24 UTC Artifacts will be uploaded here
2025-02-21 04:40:12 UTC Check cancelled

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 04:41:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for f844731 has started.
2025-02-21 04:41:55 UTC Artifacts will be uploaded here
2025-02-21 04:44:50 UTC ya make is running...
🟢 2025-02-21 05:36:28 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19124 17759 0 0 1228 137

🟢 2025-02-21 05:38:23 UTC Build successful.
🟢 2025-02-21 05:38:41 UTC ydbd size 2.1 GiB changed* by +57.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 555fbb8 merge: f844731 diff diff %
ydbd size 2 240 049 416 Bytes 2 240 108 728 Bytes +57.9 KiB +0.003%
ydbd stripped size 474 639 512 Bytes 474 630 488 Bytes -8.8 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 04:42:15 UTC Pre-commit check linux-x86_64-release-asan for f844731 has started.
2025-02-21 04:42:27 UTC Artifacts will be uploaded here
2025-02-21 04:45:19 UTC ya make is running...
🟡 2025-02-21 05:48:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11811 11740 0 23 15 33

2025-02-21 05:58:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 06:23:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 73 0 0 4 28

🟢 2025-02-21 06:23:10 UTC Build successful.
🟢 2025-02-21 06:23:36 UTC ydbd size 3.6 GiB changed* by +59.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 555fbb8 merge: f844731 diff diff %
ydbd size 3 896 864 936 Bytes 3 896 925 344 Bytes +59.0 KiB +0.002%
ydbd stripped size 1 364 380 864 Bytes 1 364 346 208 Bytes -33.8 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 21, 2025
@Alek5andr-Kotov Alek5andr-Kotov changed the title WIP: Workaround for batch processing of transactions Workaround for batch processing of transactions Feb 21, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 21, 2025
@Alek5andr-Kotov Alek5andr-Kotov enabled auto-merge (squash) February 21, 2025 04:49
@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner February 21, 2025 08:51
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 08:52:07 UTC Pre-commit check linux-x86_64-release-asan for 7dcd577 has started.
2025-02-21 08:52:35 UTC Artifacts will be uploaded here
2025-02-21 08:55:59 UTC ya make is running...
🟡 2025-02-21 09:54:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11681 11600 0 32 14 35

2025-02-21 09:56:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-21 10:13:43 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
125 (only retried tests) 80 0 3 8 34

2025-02-21 10:13:53 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-21 10:32:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77 (only retried tests) 40 0 1 3 33

🟢 2025-02-21 10:32:37 UTC Build successful.
🟢 2025-02-21 10:33:28 UTC ydbd size 3.6 GiB changed* by +1.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 795aa32 merge: 7dcd577 diff diff %
ydbd size 3 896 991 888 Bytes 3 896 992 944 Bytes +1.0 KiB +0.000%
ydbd stripped size 1 364 374 176 Bytes 1 364 374 560 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 08:55:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7dcd577 has started.
2025-02-21 08:56:23 UTC Artifacts will be uploaded here
2025-02-21 08:59:19 UTC ya make is running...
🟡 2025-02-21 09:51:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19127 17761 0 4 1228 134

2025-02-21 09:53:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 10:09:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 90 0 0 2 126

🟢 2025-02-21 10:09:44 UTC Build successful.
🟢 2025-02-21 10:10:05 UTC ydbd size 2.1 GiB changed* by +28.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bbb7d71 merge: 7dcd577 diff diff %
ydbd size 2 240 103 256 Bytes 2 240 132 160 Bytes +28.2 KiB +0.001%
ydbd stripped size 474 632 536 Bytes 474 642 456 Bytes +9.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Gazizonoki
Gazizonoki previously approved these changes Feb 21, 2025
@Alek5andr-Kotov Alek5andr-Kotov changed the title Workaround for batch processing of transactions WIP: Workaround for batch processing of transactions Feb 21, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 12:30:34 UTC Pre-commit check linux-x86_64-release-asan for 40e22ae has started.
2025-02-21 12:30:39 UTC Artifacts will be uploaded here
2025-02-21 12:33:36 UTC ya make is running...
🟡 2025-02-21 14:14:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13425 13314 0 61 14 36

2025-02-21 14:15:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 14:28:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 121 0 0 3 32

🟢 2025-02-21 14:28:19 UTC Build successful.
🔴 2025-02-21 14:28:45 UTC ydbd size 3.6 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 8b559fd merge: 40e22ae diff diff %
ydbd size 3 897 270 328 Bytes 3 899 589 224 Bytes +2.2 MiB +0.060%
ydbd stripped size 1 364 440 992 Bytes 1 364 999 488 Bytes +545.4 KiB +0.041%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 12:30:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for 40e22ae has started.
2025-02-21 12:31:09 UTC Artifacts will be uploaded here
2025-02-21 12:34:02 UTC ya make is running...
🟢 2025-02-21 13:54:24 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27761 25162 0 0 2462 137

🟢 2025-02-21 13:57:34 UTC Build successful.
🟡 2025-02-21 13:57:52 UTC ydbd size 2.1 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2d9caae merge: 40e22ae diff diff %
ydbd size 2 240 270 264 Bytes 2 241 740 936 Bytes +1.4 MiB +0.066%
ydbd stripped size 474 660 312 Bytes 474 859 736 Bytes +194.8 KiB +0.042%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 14:40:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6145976 has started.
2025-02-21 14:40:55 UTC Artifacts will be uploaded here
2025-02-21 14:44:31 UTC ya make is running...
🟡 2025-02-21 15:41:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27769 24995 0 1 2694 79

2025-02-21 15:45:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 16:17:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
393 (only retried tests) 254 0 0 10 129

🟢 2025-02-21 16:17:55 UTC Build successful.
🟢 2025-02-21 16:18:16 UTC ydbd size 2.1 GiB changed* by +360 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: f330cca merge: 6145976 diff diff %
ydbd size 2 241 792 328 Bytes 2 241 792 688 Bytes +360 Bytes +0.000%
ydbd stripped size 474 864 792 Bytes 474 864 792 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 14:41:37 UTC Pre-commit check linux-x86_64-release-asan for 6145976 has started.
2025-02-21 14:42:20 UTC Artifacts will be uploaded here
2025-02-21 14:45:23 UTC ya make is running...
🟡 2025-02-21 15:51:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13431 13150 0 233 12 36

2025-02-21 15:53:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 16:05:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
330 (only retried tests) 294 0 0 5 31

🟢 2025-02-21 16:05:54 UTC Build successful.
🟢 2025-02-21 16:06:23 UTC ydbd size 3.6 GiB changed* by +1.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f330cca merge: 6145976 diff diff %
ydbd size 3 899 694 352 Bytes 3 899 695 904 Bytes +1.5 KiB +0.000%
ydbd stripped size 1 365 007 360 Bytes 1 365 008 320 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 21, 2025
Copy link

github-actions bot commented Feb 23, 2025

2025-02-23 20:37:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for e1b8c32 has started.
2025-02-23 20:37:53 UTC Artifacts will be uploaded here
2025-02-23 20:40:44 UTC ya make is running...
🟡 2025-02-23 21:43:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27768 25156 0 2 2473 137

2025-02-23 21:46:21 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-23 22:04:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 90 0 0 2 128

🟢 2025-02-23 22:04:42 UTC Build successful.
🟡 2025-02-23 22:05:02 UTC ydbd size 2.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1041280 merge: e1b8c32 diff diff %
ydbd size 2 241 693 936 Bytes 2 242 821 416 Bytes +1.1 MiB +0.050%
ydbd stripped size 474 795 416 Bytes 474 854 200 Bytes +57.4 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 23, 2025

2025-02-23 20:39:37 UTC Pre-commit check linux-x86_64-release-asan for e1b8c32 has started.
2025-02-23 20:39:48 UTC Artifacts will be uploaded here
2025-02-23 20:42:48 UTC ya make is running...
🟡 2025-02-23 21:49:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13432 13279 0 99 17 37

2025-02-23 21:50:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-23 22:03:09 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 175 0 0 4 33

🟢 2025-02-23 22:03:16 UTC Build successful.
🟢 2025-02-23 22:03:46 UTC ydbd size 3.6 GiB changed* by -129.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 1041280 merge: e1b8c32 diff diff %
ydbd size 3 899 596 224 Bytes 3 899 464 144 Bytes -129.0 KiB -0.003%
ydbd stripped size 1 364 895 696 Bytes 1 365 151 632 Bytes +249.9 KiB +0.019%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Alek5andr-Kotov Alek5andr-Kotov merged commit 3c75e8e into ydb-platform:main Feb 24, 2025
16 of 18 checks passed
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Feb 24, 2025
Alek5andr-Kotov added a commit to Alek5andr-Kotov/ydb that referenced this pull request Feb 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants