Skip to content

Do not cleanup MKQL pool pages #14890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

abyss7
Copy link
Collaborator

@abyss7 abyss7 commented Feb 21, 2025

Changelog entry

While enabled the cleanup method cleans not only physically-allocated (RSS) pages, but also reserved ones that are never used. Thus we get a lot of "holes" inside mapped memory regions:

    3'000'000 - regions with cleanup
      100'000 - regions without cleanup

Changelog category

  • Improvement

@abyss7 abyss7 requested a review from gridnevvvit February 21, 2025 10:23
Copy link

github-actions bot commented Feb 21, 2025

🟢 2025-02-21 11:26:24 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 11:24:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for c832b4f has started.
2025-02-21 11:26:55 UTC Artifacts will be uploaded here
2025-02-21 11:29:48 UTC ya make is running...
🟢 2025-02-21 12:40:54 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27596 24985 0 0 2465 146

🟢 2025-02-21 12:43:42 UTC Build successful.
🟢 2025-02-21 12:43:57 UTC ydbd size 2.1 GiB changed* by +2.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2d9caae merge: c832b4f diff diff %
ydbd size 2 240 270 264 Bytes 2 240 273 120 Bytes +2.8 KiB +0.000%
ydbd stripped size 474 660 312 Bytes 474 659 416 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 11:24:01 UTC Pre-commit check linux-x86_64-release-asan for c832b4f has started.
2025-02-21 11:24:16 UTC Artifacts will be uploaded here
2025-02-21 11:27:18 UTC ya make is running...
🟡 2025-02-21 12:45:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13386 13321 0 23 6 36

2025-02-21 12:47:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 12:59:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 62 0 0 2 35

🟢 2025-02-21 12:59:41 UTC Build successful.
🟡 2025-02-21 13:00:07 UTC ydbd size 3.6 GiB changed* by +263.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 64fee69 merge: c832b4f diff diff %
ydbd size 3 897 000 568 Bytes 3 897 270 248 Bytes +263.4 KiB +0.007%
ydbd stripped size 1 364 376 480 Bytes 1 364 440 928 Bytes +62.9 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants