Skip to content

Fix print and update CHANGELOG.md #14905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix print and update CHANGELOG.md #14905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ydb/apps/ydb/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
* Add `ydb admin node config init` command to initialize directory with node config files.
* Add `ydb admin cluster config generate` command to generate dynamic config from static config on cluster.
* Fixed memory leak in tpcds generator.
* Include external data sources and external tables in local backups (`ydb tools dump` and `ydb tools restore`). Both scheme objects are backed up as YQL creation queries saved in the `create_external_data_source.sql` and `create_external_table.sql` files respectively, which can be executed to recreate the original scheme objects.
* Fixed a bug where `ydb auth get-token` command tried to authenticate twice: while listing andpoints and while executing actual token request.
Expand Down
7 changes: 4 additions & 3 deletions ydb/public/lib/ydb_cli/commands/ydb_node_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ constexpr const char* STORAGE_CONFIG_FILE_NAME = "storage.yaml";

TCommandNodeConfig::TCommandNodeConfig()
: TClientCommandTree("config", {}, "Node-wide configuration")
{
{
AddCommand(std::make_unique<TCommandNodeConfigInit>());
}

Expand Down Expand Up @@ -97,8 +97,9 @@ int TCommandNodeConfigInit::Run(TConfig& config) {
return EXIT_SUCCESS;
}
Cerr << "Failed to save configs: "
<< (clusterSaved ? "" : "main config ")
<< (storageSaved ? "and " : "storage config")
<< (clusterSaved ? "" : "main config")
<< (clusterSaved && storageSaved ? ", " : "")
<< (storageSaved ? "" : "storage config")
<< Endl;
return EXIT_FAILURE;
}
Expand Down