Expand the list of message fields available for transfering from a topic to a table #14941
Conversation
|
🟢 |
|
⚪ |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| using TRecord = TEvWorker::TEvData::TRecord; | ||
|
|
||
| TRecord Record(ui64 offset, const TString& data) { | ||
| return TRecord(offset, data, TInstant::Zero(), "MessageGroupId", "ProducerId", 13 /* seqNo */); | ||
| } |
There was a problem hiding this comment.
Дык сделай просто локальную обертку над TRecord и дифф будет намного меньше.
| using TRecord = TEvWorker::TEvData::TRecord; | ||
|
|
||
| TRecord Record(ui64 offset, const TString& data) { | ||
| return TRecord(offset, data, TInstant::Zero(), "MessageGroupId", "ProducerId", 13 /* seqNo */); | ||
| } |
| using TRecord = TEvWorker::TEvData::TRecord; | ||
|
|
||
| TRecord Record(ui64 offset, const TString& data) { | ||
| return TRecord(offset, data, TInstant::Zero(), "MessageGroupId", "ProducerId", 13 /* seqNo */); | ||
| TEvWorker::TEvData::TRecord TRecord(ui64 offset, const TString& data) { | ||
| return TEvWorker::TEvData::TRecord(offset, data, TInstant::Zero(), "MessageGroupId", "ProducerId", 13 /* seqNo */); | ||
| } |
There was a problem hiding this comment.
Функция не можешь называться TRecord. Я имел в виду что-то такое:
struct TRecord: public TEvWorker::TEvData::TRecord {
explicit TRecord(ui64 offset, const TString& data)
: TEvWorker::TEvData::TRecord(offset, data, TInstant::Zero(), "MessageGroupId", "ProducerId", 42)
{}
};И положить в общее место, чтобы использовать в table_writer_ut.cpp и transfer_writer_ut.cpp.
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Changelog entry
...
Changelog category
Description for reviewers
...