Skip to content

Fix #14903 #14957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Fix #14903 #14957

merged 4 commits into from
Feb 25, 2025

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Feb 24, 2025

Changelog entry

Fix #14903

Return error from datashard instead of UNAVAILABLE in case of exceeded retry limit.

Changelog category

  • Bugfix

Description for reviewers

...

@nikvas0 nikvas0 requested a review from a team as a code owner February 24, 2025 12:10
Copy link

github-actions bot commented Feb 24, 2025

🟢 2025-02-24 13:00:04 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 12:13:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 78b6a6c has started.
2025-02-24 12:14:18 UTC Artifacts will be uploaded here
2025-02-24 12:17:07 UTC ya make is running...
2025-02-24 12:55:30 UTC Check cancelled

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 12:13:59 UTC Pre-commit check linux-x86_64-release-asan for 78b6a6c has started.
2025-02-24 12:14:12 UTC Artifacts will be uploaded here
2025-02-24 12:17:05 UTC ya make is running...
2025-02-24 12:55:32 UTC Check cancelled

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 12:56:42 UTC Pre-commit check linux-x86_64-release-asan for d184891 has started.
2025-02-24 12:56:48 UTC Artifacts will be uploaded here
2025-02-24 12:59:41 UTC ya make is running...
🟡 2025-02-24 14:02:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11707 11629 0 30 10 38

2025-02-24 14:03:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-24 14:16:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 91 0 0 5 33

🟢 2025-02-24 14:16:16 UTC Build successful.
🟢 2025-02-24 14:16:46 UTC ydbd size 3.6 GiB changed* by +31.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cb5d0e3 merge: d184891 diff diff %
ydbd size 3 899 589 992 Bytes 3 899 621 864 Bytes +31.1 KiB +0.001%
ydbd stripped size 1 365 211 408 Bytes 1 365 219 280 Bytes +7.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 12:58:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for d184891 has started.
2025-02-24 12:59:00 UTC Artifacts will be uploaded here
2025-02-24 13:01:48 UTC ya make is running...
🟡 2025-02-24 14:02:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19152 17794 0 3 1216 139

2025-02-24 14:04:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-24 14:16:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 73 0 0 0 129

🟢 2025-02-24 14:17:00 UTC Build successful.
🟢 2025-02-24 14:17:21 UTC ydbd size 2.1 GiB changed* by +18.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cb5d0e3 merge: d184891 diff diff %
ydbd size 2 242 886 232 Bytes 2 242 905 520 Bytes +18.8 KiB +0.001%
ydbd stripped size 474 869 016 Bytes 474 876 184 Bytes +7.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 24, 2025
@nikvas0 nikvas0 enabled auto-merge (squash) February 24, 2025 16:55
Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 20:07:21 UTC Pre-commit check linux-x86_64-release-asan for bc50e6c has started.
2025-02-24 20:07:37 UTC Artifacts will be uploaded here
2025-02-24 20:10:24 UTC ya make is running...
🟡 2025-02-24 21:07:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11725 11649 0 26 16 34

2025-02-24 21:08:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-24 21:24:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 74 0 1 7 31

2025-02-24 21:24:59 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-24 21:43:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 30 0 0 5 32

🟢 2025-02-24 21:43:42 UTC Build successful.
🟢 2025-02-24 21:44:08 UTC ydbd size 3.6 GiB changed* by +33.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4b70624 merge: bc50e6c diff diff %
ydbd size 3 899 667 440 Bytes 3 899 701 624 Bytes +33.4 KiB +0.001%
ydbd stripped size 1 365 237 168 Bytes 1 365 233 232 Bytes -3.8 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 20:08:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for bc50e6c has started.
2025-02-24 20:08:41 UTC Artifacts will be uploaded here
2025-02-24 20:11:38 UTC ya make is running...
🟡 2025-02-24 21:01:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19174 17653 0 4 1448 69

2025-02-24 21:03:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-24 21:29:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
378 (only retried tests) 240 0 2 8 128

2025-02-24 21:30:05 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-24 21:42:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 63 0 0 1 127

🟢 2025-02-24 21:42:14 UTC Build successful.
🟢 2025-02-24 21:42:36 UTC ydbd size 2.1 GiB changed* by +14.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a674a8f merge: bc50e6c diff diff %
ydbd size 2 242 929 256 Bytes 2 242 944 504 Bytes +14.9 KiB +0.001%
ydbd stripped size 474 870 744 Bytes 474 873 880 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 08:38:03 UTC Pre-commit check linux-x86_64-release-asan for ca82d0c has started.
2025-02-25 08:38:20 UTC Artifacts will be uploaded here
2025-02-25 08:41:20 UTC ya make is running...
🟡 2025-02-25 09:50:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11713 11588 0 75 16 34

2025-02-25 09:51:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 10:06:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
173 (only retried tests) 133 0 0 7 33

🟢 2025-02-25 10:06:29 UTC Build successful.
🟢 2025-02-25 10:07:03 UTC ydbd size 3.6 GiB changed* by +31.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 389847d merge: ca82d0c diff diff %
ydbd size 3 900 080 896 Bytes 3 900 112 768 Bytes +31.1 KiB +0.001%
ydbd stripped size 1 365 326 544 Bytes 1 365 334 416 Bytes +7.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 08:38:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca82d0c has started.
2025-02-25 08:38:22 UTC Artifacts will be uploaded here
2025-02-25 08:41:12 UTC ya make is running...
🟡 2025-02-25 09:33:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19158 17804 0 5 1219 130

2025-02-25 09:35:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 09:53:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 73 0 0 3 126

🟢 2025-02-25 09:53:48 UTC Build successful.
🟢 2025-02-25 09:54:09 UTC ydbd size 2.1 GiB changed* by +14.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 389847d merge: ca82d0c diff diff %
ydbd size 2 243 192 168 Bytes 2 243 207 352 Bytes +14.8 KiB +0.001%
ydbd stripped size 474 898 072 Bytes 474 901 144 Bytes +3.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit a4b20bc into ydb-platform:main Feb 25, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Mar 20, 2025
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when shard replies "MaxTxInFly was exceeded" KQP returns Unavailable
2 participants