Skip to content

Revert use of GraceJoinCore for map/broadcast by default #14974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 24, 2025

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@Hor911 Hor911 requested a review from a team as a code owner February 24, 2025 19:46
Copy link

🟢 2025-02-24 19:48:08 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 19:48:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for e7eb8d0 has started.
2025-02-24 19:50:37 UTC Artifacts will be uploaded here
2025-02-24 19:53:22 UTC ya make is running...
🟡 2025-02-24 20:38:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18852 17483 0 14 1222 133

2025-02-24 20:40:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-24 20:58:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
232 (only retried tests) 90 0 12 3 127

2025-02-24 20:58:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-24 21:25:09 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 78 0 12 0 126

🟢 2025-02-24 21:25:17 UTC Build successful.
🟢 2025-02-24 21:25:37 UTC ydbd size 2.1 GiB changed* by +8.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4b70624 merge: e7eb8d0 diff diff %
ydbd size 2 242 920 504 Bytes 2 242 929 256 Bytes +8.5 KiB +0.000%
ydbd stripped size 474 878 200 Bytes 474 870 744 Bytes -7.3 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 19:48:19 UTC Pre-commit check linux-x86_64-release-asan for e7eb8d0 has started.
2025-02-24 19:48:42 UTC Artifacts will be uploaded here
2025-02-24 19:51:29 UTC ya make is running...
🟡 2025-02-24 21:00:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11616 11471 0 84 26 35

2025-02-24 21:02:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-24 21:14:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
199 (only retried tests) 156 0 4 9 30

2025-02-24 21:14:16 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-24 21:25:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 38 0 4 2 29

🟢 2025-02-24 21:25:42 UTC Build successful.
🟢 2025-02-24 21:26:08 UTC ydbd size 3.6 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4b70624 merge: e7eb8d0 diff diff %
ydbd size 3 899 667 440 Bytes 3 899 669 656 Bytes +2.2 KiB +0.000%
ydbd stripped size 1 365 237 168 Bytes 1 365 225 296 Bytes -11.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 23:41:15 UTC Pre-commit check linux-x86_64-release-asan for b353fb6 has started.
2025-02-24 23:41:27 UTC Artifacts will be uploaded here
2025-02-24 23:44:13 UTC ya make is running...
🟡 2025-02-25 00:42:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11616 11459 0 107 14 36

2025-02-25 00:43:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 00:56:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 171 0 4 5 33

2025-02-25 00:56:22 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-25 01:12:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74 (only retried tests) 34 0 4 5 31

🟢 2025-02-25 01:12:36 UTC Build successful.
🟢 2025-02-25 01:13:04 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a674a8f merge: b353fb6 diff diff %
ydbd size 3 899 669 752 Bytes 3 899 669 656 Bytes -96 Bytes -0.000%
ydbd stripped size 1 365 225 360 Bytes 1 365 225 296 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 24, 2025

2025-02-24 23:43:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for b353fb6 has started.
2025-02-24 23:44:03 UTC Artifacts will be uploaded here
2025-02-24 23:46:50 UTC ya make is running...
🟡 2025-02-25 00:36:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18852 17490 0 7 1220 135

2025-02-25 00:38:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 01:01:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 80 0 6 3 127

2025-02-25 01:01:40 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-25 01:28:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
200 (only retried tests) 68 0 6 1 125

🟢 2025-02-25 01:28:15 UTC Build successful.
🟢 2025-02-25 01:28:37 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a674a8f merge: b353fb6 diff diff %
ydbd size 2 242 929 256 Bytes 2 242 929 256 Bytes 0 Bytes 0.000%
ydbd stripped size 474 870 744 Bytes 474 870 744 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 08:48:56 UTC Pre-commit check linux-x86_64-release-asan for 031ecfb has started.
2025-02-25 08:49:10 UTC Artifacts will be uploaded here
2025-02-25 08:51:55 UTC ya make is running...
🟡 2025-02-25 09:52:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11616 11516 0 44 24 32

2025-02-25 09:53:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 10:07:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
139 (only retried tests) 102 0 0 5 32

🟢 2025-02-25 10:07:20 UTC Build successful.
🟢 2025-02-25 10:07:48 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 389847d merge: 031ecfb diff diff %
ydbd size 3 900 080 896 Bytes 3 900 080 800 Bytes -96 Bytes -0.000%
ydbd stripped size 1 365 326 544 Bytes 1 365 326 480 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 08:49:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 031ecfb has started.
2025-02-25 08:49:19 UTC Artifacts will be uploaded here
2025-02-25 08:52:15 UTC ya make is running...
🟡 2025-02-25 09:40:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18852 17500 0 3 1219 130

2025-02-25 09:42:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 10:09:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
200 (only retried tests) 71 0 0 3 126

🟢 2025-02-25 10:09:09 UTC Build successful.
🟢 2025-02-25 10:09:30 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 389847d merge: 031ecfb diff diff %
ydbd size 2 243 192 168 Bytes 2 243 192 168 Bytes 0 Bytes 0.000%
ydbd stripped size 474 898 072 Bytes 474 898 072 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit b58a028 into ydb-platform:main Feb 25, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants