Skip to content

Fix describe_volume and alter_volume #14978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2025
Merged

Fix describe_volume and alter_volume #14978

merged 3 commits into from
Feb 25, 2025

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 25, 2025

Changelog entry

Alter volume was not working correctly. If you didn't write storage config, it changed channels by channel_profile_id=0.
Also, descibe volume didn't return channels of volume, it was fixed too.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@kruall kruall added the area/blobstorage BlobStorage issues label Feb 25, 2025
@kruall kruall self-assigned this Feb 25, 2025
@kruall kruall requested a review from a team as a code owner February 25, 2025 05:21
@github-actions GitHub Actions
Copy link

🟢 2025-02-25 05:22:56 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 05:25:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 664dae0 has started.
⚪ 2025-02-25 05:25:58 UTC Artifacts will be uploaded here
⚪ 2025-02-25 05:29:11 UTC ya make is running...
🟡 2025-02-25 07:01:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28088 25484 0 4 2466 134

⚪ 2025-02-25 07:03:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 07:22:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 82 0 0 1 128

🟢 2025-02-25 07:22:19 UTC Build successful.
🟢 2025-02-25 07:22:39 UTC ydbd size 2.1 GiB changed* by +29.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 389847d merge: 664dae0 diff diff %
ydbd size 2 243 192 168 Bytes 2 243 222 232 Bytes +29.4 KiB +0.001%
ydbd stripped size 474 898 072 Bytes 474 906 744 Bytes +8.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 05:25:56 UTC Pre-commit check linux-x86_64-release-asan for 664dae0 has started.
⚪ 2025-02-25 05:26:11 UTC Artifacts will be uploaded here
⚪ 2025-02-25 05:29:26 UTC ya make is running...
🟡 2025-02-25 07:05:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13711 13560 0 99 17 35

⚪ 2025-02-25 07:06:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 07:23:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 162 0 1 5 30

⚪ 2025-02-25 07:24:13 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 07:41:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 31 0 0 2 30

🟢 2025-02-25 07:41:55 UTC Build successful.
🟢 2025-02-25 07:42:24 UTC ydbd size 3.6 GiB changed* by +52.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 389847d merge: 664dae0 diff diff %
ydbd size 3 900 080 896 Bytes 3 900 134 592 Bytes +52.4 KiB +0.001%
ydbd stripped size 1 365 326 544 Bytes 1 365 343 504 Bytes +16.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexvru
alexvru previously approved these changes Feb 25, 2025
View reviewed changes
CyberROFL
CyberROFL reviewed Feb 25, 2025
View reviewed changes
ydb/core/tx/schemeshard/schemeshard__operation_alter_solomon.cpp
Comment on lines +262 to +265
if (!alter.HasChannelProfileId()) {
result->SetError(TEvSchemeShard::EStatus::StatusInvalidParameter, "set channel profile id, please");
return result;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавишь тест?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:40:11 UTC Pre-commit check linux-x86_64-release-asan for 1076443 has started.
⚪ 2025-02-25 12:40:25 UTC Artifacts will be uploaded here
⚪ 2025-02-25 12:43:46 UTC ya make is running...
⚫ 2025-02-25 12:47:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:40:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1076443 has started.
⚪ 2025-02-25 12:40:36 UTC Artifacts will be uploaded here
⚪ 2025-02-25 12:43:57 UTC ya make is running...
⚫ 2025-02-25 12:47:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:50:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6806da4 has started.
⚪ 2025-02-25 12:50:30 UTC Artifacts will be uploaded here
⚪ 2025-02-25 12:53:50 UTC ya make is running...
🟡 2025-02-25 13:54:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28091 25491 0 2 2463 135

⚪ 2025-02-25 13:57:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:18:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 73 0 1 3 127

⚪ 2025-02-25 14:18:12 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 14:30:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 63 0 0 2 126

🟢 2025-02-25 14:30:42 UTC Build successful.
🟢 2025-02-25 14:31:06 UTC ydbd size 2.1 GiB changed* by +29.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9029d02 merge: 6806da4 diff diff %
ydbd size 2 243 209 832 Bytes 2 243 239 896 Bytes +29.4 KiB +0.001%
ydbd stripped size 474 901 528 Bytes 474 910 200 Bytes +8.5 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 12:52:03 UTC Pre-commit check linux-x86_64-release-asan for 6806da4 has started.
⚪ 2025-02-25 12:52:15 UTC Artifacts will be uploaded here
⚪ 2025-02-25 12:55:35 UTC ya make is running...
🟡 2025-02-25 14:02:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13714 13577 0 83 21 33

⚪ 2025-02-25 14:04:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 14:16:21 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 145 0 0 6 31

🟢 2025-02-25 14:16:28 UTC Build successful.
🟢 2025-02-25 14:16:57 UTC ydbd size 3.6 GiB changed* by +52.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9029d02 merge: 6806da4 diff diff %
ydbd size 3 900 116 896 Bytes 3 900 170 528 Bytes +52.4 KiB +0.001%
ydbd stripped size 1 365 335 376 Bytes 1 365 352 272 Bytes +16.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall enabled auto-merge (squash) February 25, 2025 13:35
@kruall kruall merged commit 8afb530 into ydb-platform:main Feb 25, 2025
12 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 25, 2025
Merged
kruall added a commit to kruall/ydb that referenced this pull request Feb 26, 2025
@kruall
Fix describe_volume and alter_volume (ydb-platform#14978)
fd87468
@kruall kruall mentioned this pull request Feb 26, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@kruall
Fix describe_volume and alter_volume (ydb-platform#14978)
a9d610d
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@kruall @blinkov
Fix describe_volume and alter_volume (#14978)
76e418e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

@alexvru alexvru alexvru left review comments

Assignees

@kruall kruall

Labels
area/blobstorage BlobStorage issues not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruall @CyberROFL @alexvru