Skip to content

Rename config-store to config-dir #14998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

mregrock
Copy link
Collaborator

Changelog entry

Rename config-store to config-dir

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@mregrock mregrock requested a review from a team as a code owner February 25, 2025 10:13
@mregrock mregrock requested a review from pixcc February 25, 2025 10:13
Copy link

🟢 2025-02-25 10:15:00 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 10:16:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for b2b040c has started.
2025-02-25 10:17:00 UTC Artifacts will be uploaded here
2025-02-25 10:20:20 UTC ya make is running...
🟡 2025-02-25 12:06:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28249 25645 0 3 2464 137

2025-02-25 12:08:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 12:31:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
214 (only retried tests) 87 0 0 0 127

🟢 2025-02-25 12:31:13 UTC Build successful.
🟢 2025-02-25 12:31:41 UTC ydbd size 2.1 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a4b20bc merge: b2b040c diff diff %
ydbd size 2 243 207 352 Bytes 2 243 207 336 Bytes -16 Bytes -0.000%
ydbd stripped size 474 901 144 Bytes 474 901 144 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 10:16:58 UTC Pre-commit check linux-x86_64-release-asan for b2b040c has started.
2025-02-25 10:17:13 UTC Artifacts will be uploaded here
2025-02-25 10:20:30 UTC ya make is running...
🟡 2025-02-25 12:04:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13870 13779 0 31 23 37

2025-02-25 12:05:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 12:24:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 105 0 2 3 32

2025-02-25 12:24:31 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 12:36:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 31 0 0 2 32

🟢 2025-02-25 12:36:21 UTC Build successful.
🟢 2025-02-25 12:37:04 UTC ydbd size 3.6 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a4b20bc merge: b2b040c diff diff %
ydbd size 3 900 112 864 Bytes 3 900 112 752 Bytes -112 Bytes -0.000%
ydbd stripped size 1 365 334 480 Bytes 1 365 334 416 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc requested review from Enjection and removed request for pixcc February 25, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants