Skip to content

Flush sink on INSERT #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Flush sink on INSERT #15003

merged 4 commits into from
Mar 5, 2025

Conversation

nikvas0
Copy link
Collaborator

@nikvas0 nikvas0 commented Feb 25, 2025

Changelog entry

In case of INSERT flush sink immediately in order to provide duplicate rows error without delay.

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@nikvas0 nikvas0 requested a review from a team as a code owner February 25, 2025 12:05
Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 12:07:11 UTC Pre-commit check linux-x86_64-release-asan for a7d678e has started.
2025-02-25 12:07:24 UTC Artifacts will be uploaded here
2025-02-25 12:10:16 UTC ya make is running...
🟡 2025-02-25 13:08:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11747 11658 0 45 9 35

2025-02-25 13:10:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 13:40:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 96 0 1 4 33

2025-02-25 13:40:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-25 13:52:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 31 0 1 3 31

🟢 2025-02-25 13:53:00 UTC Build successful.
🟢 2025-02-25 13:53:41 UTC ydbd size 3.6 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: b58a028 merge: a7d678e diff diff %
ydbd size 3 900 116 896 Bytes 3 900 116 944 Bytes +48 Bytes +0.000%
ydbd stripped size 1 365 335 376 Bytes 1 365 335 312 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 12:07:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for a7d678e has started.
2025-02-25 12:07:32 UTC Artifacts will be uploaded here
2025-02-25 12:10:29 UTC ya make is running...
🟡 2025-02-25 13:08:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19192 17822 0 4 1233 133

2025-02-25 13:10:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 13:25:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 93 0 1 1 127

2025-02-25 13:25:42 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-25 13:41:26 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 63 0 1 0 125

🟢 2025-02-25 13:41:36 UTC Build successful.
🟢 2025-02-25 13:42:01 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: b58a028 merge: a7d678e diff diff %
ydbd size 2 243 209 832 Bytes 2 243 209 832 Bytes 0 Bytes 0.000%
ydbd stripped size 474 901 528 Bytes 474 901 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-02-25 12:07:21 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 21:13:06 UTC Pre-commit check linux-x86_64-release-asan for 98b3017 has started.
2025-02-25 21:13:20 UTC Artifacts will be uploaded here
2025-02-25 21:16:08 UTC ya make is running...
🟡 2025-02-25 22:23:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11748 11613 0 73 29 33

2025-02-25 22:24:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 22:37:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 152 0 2 4 30

2025-02-25 22:37:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 22:49:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 29 0 0 3 29

🟢 2025-02-25 22:49:27 UTC Build successful.
🟢 2025-02-25 22:49:57 UTC ydbd size 3.6 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 38b28a9 merge: 98b3017 diff diff %
ydbd size 3 900 338 688 Bytes 3 900 338 736 Bytes +48 Bytes +0.000%
ydbd stripped size 1 365 388 720 Bytes 1 365 388 656 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 21:13:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 98b3017 has started.
2025-02-25 21:13:20 UTC Artifacts will be uploaded here
2025-02-25 21:16:09 UTC ya make is running...
🟡 2025-02-25 22:07:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19194 17839 0 1 1216 138

2025-02-25 22:09:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 22:27:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
206 (only retried tests) 76 0 0 1 129

🟢 2025-02-25 22:27:15 UTC Build successful.
🟢 2025-02-25 22:27:33 UTC ydbd size 2.1 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 38b28a9 merge: 98b3017 diff diff %
ydbd size 2 243 348 776 Bytes 2 243 348 792 Bytes +16 Bytes +0.000%
ydbd stripped size 474 924 472 Bytes 474 924 472 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 enabled auto-merge (squash) February 26, 2025 06:00
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 10:07:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for c3f00a2 has started.
2025-02-26 10:08:48 UTC Artifacts will be uploaded here
2025-02-26 10:12:11 UTC ya make is running...
🟢 2025-02-26 11:05:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19198 17832 0 0 1228 138

🟢 2025-02-26 11:07:40 UTC Build successful.
🟡 2025-02-26 11:08:02 UTC ydbd size 2.1 GiB changed* by +181.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0c1ebc0 merge: c3f00a2 diff diff %
ydbd size 2 263 580 664 Bytes 2 263 766 744 Bytes +181.7 KiB +0.008%
ydbd stripped size 477 118 136 Bytes 477 143 256 Bytes +24.5 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 10:08:59 UTC Pre-commit check linux-x86_64-release-asan for c3f00a2 has started.
2025-02-26 10:09:13 UTC Artifacts will be uploaded here
2025-02-26 10:11:59 UTC ya make is running...
🟡 2025-02-26 11:13:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11753 11682 0 22 13 36

2025-02-26 11:14:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 11:32:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 71 0 3 5 30

2025-02-26 11:32:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-26 11:54:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 32 0 2 2 31

🟢 2025-02-26 11:54:18 UTC Build successful.
🟢 2025-02-26 11:54:48 UTC ydbd size 3.7 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d2f7432 merge: c3f00a2 diff diff %
ydbd size 3 943 200 208 Bytes 3 943 203 344 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 374 169 712 Bytes 1 374 170 544 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 11:29:23 UTC Pre-commit check linux-x86_64-release-asan for 16c4c88 has started.
2025-03-05 11:29:38 UTC Artifacts will be uploaded here
2025-03-05 11:32:28 UTC ya make is running...
🟡 2025-03-05 12:43:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11744 11548 0 132 26 38

2025-03-05 12:44:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 12:59:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
262 (only retried tests) 220 0 7 1 34

2025-03-05 13:00:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-05 13:12:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 39 0 0 0 34

🟢 2025-03-05 13:12:45 UTC Build successful.
🟡 2025-03-05 13:13:20 UTC ydbd size 3.7 GiB changed* by +270.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5a1e03d merge: 16c4c88 diff diff %
ydbd size 3 990 863 936 Bytes 3 991 140 720 Bytes +270.3 KiB +0.007%
ydbd stripped size 1 388 994 760 Bytes 1 389 078 184 Bytes +81.5 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 11:29:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 16c4c88 has started.
2025-03-05 11:29:37 UTC Artifacts will be uploaded here
2025-03-05 11:32:29 UTC ya make is running...
🟢 2025-03-05 12:24:38 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19209 17857 0 0 1228 124

🟢 2025-03-05 12:26:31 UTC Build successful.
🟡 2025-03-05 12:26:49 UTC ydbd size 2.1 GiB changed* by +138.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5a1e03d merge: 16c4c88 diff diff %
ydbd size 2 290 085 376 Bytes 2 290 227 600 Bytes +138.9 KiB +0.006%
ydbd stripped size 479 952 640 Bytes 479 979 584 Bytes +26.3 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nikvas0 nikvas0 merged commit 1d48d63 into ydb-platform:main Mar 5, 2025
12 checks passed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
nikvas0 added a commit to nikvas0/ydb that referenced this pull request Mar 31, 2025
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants