Skip to content

Data erasure refactoring #15007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 26, 2025
Merged

Data erasure refactoring #15007

merged 5 commits into from
Feb 26, 2025

Conversation

molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Feb 25, 2025 •
edited
Loading

Changelog entry

Base on #14460

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@molotkov-and molotkov-and requested a review from a team as a code owner February 25, 2025 13:17
@molotkov-and molotkov-and linked an issue Feb 25, 2025 that may be closed by this pull request
Apply comments for data erasure #14946
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

🟢 2025-02-25 14:26:33 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 13:18:27 UTC Pre-commit check linux-x86_64-release-asan for d3293e4 has started.
⚪ 2025-02-25 13:18:41 UTC Artifacts will be uploaded here
⚪ 2025-02-25 13:21:41 UTC ya make is running...
🟡 2025-02-25 14:42:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13447 13359 0 30 23 35

⚪ 2025-02-25 14:44:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:56:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
124 (only retried tests) 85 0 3 4 32

⚪ 2025-02-25 14:56:49 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-25 15:08:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 27 0 3 5 29

🟢 2025-02-25 15:08:34 UTC Build successful.
🟢 2025-02-25 15:09:02 UTC ydbd size 3.6 GiB changed* by +23.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9029d02 merge: d3293e4 diff diff %
ydbd size 3 900 116 896 Bytes 3 900 141 056 Bytes +23.6 KiB +0.001%
ydbd stripped size 1 365 335 376 Bytes 1 365 346 608 Bytes +11.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 15:39:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for d3293e4 has started.
⚪ 2025-02-25 15:39:54 UTC Artifacts will be uploaded here
⚪ 2025-02-25 15:43:07 UTC ya make is running...
⚫ 2025-02-25 16:07:17 UTC Check cancelled

azevaykin
azevaykin previously approved these changes Feb 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 16:10:38 UTC Pre-commit check linux-x86_64-release-asan for bfaca59 has started.
⚪ 2025-02-25 16:10:51 UTC Artifacts will be uploaded here
⚪ 2025-02-25 16:14:05 UTC ya make is running...
🟡 2025-02-25 17:41:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13450 13345 0 47 25 33

⚪ 2025-02-25 17:42:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 18:07:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
164 (only retried tests) 123 0 1 6 34

⚪ 2025-02-25 18:07:26 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-25 18:19:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 33 0 0 3 32

🟢 2025-02-25 18:19:27 UTC Build successful.
🟢 2025-02-25 18:19:56 UTC ydbd size 3.6 GiB changed* by +19.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b74ed72 merge: bfaca59 diff diff %
ydbd size 3 900 170 608 Bytes 3 900 190 752 Bytes +19.7 KiB +0.001%
ydbd stripped size 1 365 352 336 Bytes 1 365 359 536 Bytes +7.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

⚪ 2025-02-25 16:11:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for bfaca59 has started.
⚪ 2025-02-25 16:11:48 UTC Artifacts will be uploaded here
⚪ 2025-02-25 16:14:47 UTC ya make is running...
🟡 2025-02-25 17:33:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27787 25182 0 2 2463 140

⚪ 2025-02-25 17:36:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-25 17:49:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
205 (only retried tests) 75 0 0 3 127

🟢 2025-02-25 17:49:10 UTC Build successful.
🟢 2025-02-25 17:49:28 UTC ydbd size 2.1 GiB changed* by +6.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b74ed72 merge: bfaca59 diff diff %
ydbd size 2 243 239 880 Bytes 2 243 246 672 Bytes +6.6 KiB +0.000%
ydbd stripped size 474 910 200 Bytes 474 909 816 Bytes -384 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit 63aaaeb into ydb-platform:main Feb 26, 2025
12 checks passed
@molotkov-and molotkov-and deleted the data-erasure-refactoring branch February 26, 2025 12:32
molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Feb 27, 2025
@molotkov-and
Data erasure refactoring (ydb-platform#15007)
21d5a35
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@molotkov-and
Data erasure refactoring (ydb-platform#15007)
dfc63fd
molotkov-and added a commit that referenced this pull request Mar 4, 2025
@molotkov-and
Data erasure refactoring (#15007) (#15113)
e9cedd9
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@molotkov-and @blinkov
Data erasure refactoring (#15007)
13b1325
@ijon ijon mentioned this pull request Mar 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

@azevaykin azevaykin azevaykin approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply comments for data erasure
3 participants
@molotkov-and @ijon @azevaykin