Skip to content

Report LayoutCorrect for static groups too #15036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Feb 26, 2025

Changelog entry

Report LayoutCorrect for static groups too

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

LayoutCorrect filled for static groups also.

Copy link

🟢 2025-02-26 05:42:34 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 05:45:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 57c4ae4 has started.
2025-02-26 05:45:22 UTC Artifacts will be uploaded here
2025-02-26 06:00:16 UTC ya make is running...
🟡 2025-02-26 06:59:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19159 17806 0 1 1217 135

2025-02-26 07:01:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 07:13:38 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 77 0 0 0 126

🟢 2025-02-26 07:13:47 UTC Build successful.
🔴 2025-02-26 07:14:05 UTC ydbd size 2.1 GiB changed* by +19.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 38b28a9 merge: 57c4ae4 diff diff %
ydbd size 2 243 348 776 Bytes 2 263 577 040 Bytes +19.3 MiB +0.902%
ydbd stripped size 474 924 472 Bytes 477 109 752 Bytes +2.1 MiB +0.460%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 05:45:29 UTC Pre-commit check linux-x86_64-release-asan for 57c4ae4 has started.
2025-02-26 05:45:45 UTC Artifacts will be uploaded here
2025-02-26 05:59:50 UTC ya make is running...
🟡 2025-02-26 07:04:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11714 11552 0 109 17 36

2025-02-26 07:06:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 07:24:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
223 (only retried tests) 183 0 1 10 29

2025-02-26 07:24:41 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-26 07:36:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 34 0 0 2 30

🟢 2025-02-26 07:36:46 UTC Build successful.
🔴 2025-02-26 07:37:17 UTC ydbd size 3.7 GiB changed* by +40.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 38b28a9 merge: 57c4ae4 diff diff %
ydbd size 3 900 338 688 Bytes 3 942 821 488 Bytes +40.5 MiB +1.089%
ydbd stripped size 1 365 388 720 Bytes 1 374 025 328 Bytes +8.2 MiB +0.633%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) February 26, 2025 11:26
@alexvru alexvru merged commit 340fbf8 into ydb-platform:main Feb 26, 2025
14 checks passed
@alexvru alexvru deleted the bsdc/report-static-group-layout-correctness branch February 26, 2025 11:38
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
StekPerepolnen pushed a commit to StekPerepolnen/ydb that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants