Skip to content

fix compaction stats calculation #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

fix compaction stats calculation #15059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ydb/core/tx/columnshard/engines/changes/compaction/sub_columns/builder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ class TMergedBuilder {
class TGeneralAccessorBuilder {
private:
std::variant<TSparsedBuilder, TPlainBuilder> Builder;

YDB_READONLY(ui32, FilledRecordsCount, 0);
YDB_READONLY(ui64, FilledRecordsSize, 0);
public:
TGeneralAccessorBuilder(TSparsedBuilder&& builder)
: Builder(std::move(builder)) {
Expand Down Expand Up @@ -61,6 +62,8 @@ class TMergedBuilder {
}
};
std::visit(TVisitor(recordIndex, value), Builder);
++FilledRecordsCount;
FilledRecordsSize += value.size();
}
std::shared_ptr<NArrow::NAccessor::IChunkedArray> Finish(const ui32 recordsCount) {
struct TVisitor {
Expand Down Expand Up @@ -89,11 +92,16 @@ class TMergedBuilder {
AFL_VERIFY(RecordIndex);
auto portionOthersData = OthersBuilder->Finish(Remapper.BuildRemapInfo(OthersBuilder->GetStatsByKeyIndex(), Settings, RecordIndex));
std::vector<std::shared_ptr<NArrow::NAccessor::IChunkedArray>> arrays;
for (auto&& i : ColumnBuilders) {
arrays.emplace_back(i.Finish(RecordIndex));
TDictStats::TBuilder statsBuilder;
for (ui32 idx = 0; idx < ColumnBuilders.size(); ++idx) {
if (ColumnBuilders[idx].GetFilledRecordsCount()) {
statsBuilder.Add(ResultColumnStats.GetColumnName(idx), ColumnBuilders[idx].GetFilledRecordsCount(),
ColumnBuilders[idx].GetFilledRecordsSize(), ResultColumnStats.GetAccessorType(idx));
arrays.emplace_back(ColumnBuilders[idx].Finish(RecordIndex));
}
}
TColumnsData cData(
ResultColumnStats, std::make_shared<NArrow::TGeneralContainer>(ResultColumnStats.BuildColumnsSchema()->fields(), std::move(arrays)));
auto stats = statsBuilder.Finish();
TColumnsData cData(stats, std::make_shared<NArrow::TGeneralContainer>(stats.BuildColumnsSchema()->fields(), std::move(arrays)));
Results.back().emplace_back(
std::make_shared<TSubColumnsArray>(std::move(cData), std::move(portionOthersData), arrow::binary(), RecordIndex, Settings));
Initialize();
Expand Down
Loading