Skip to content

Fix memory leak in ldap auth provider #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented Feb 26, 2025

Copy link

github-actions bot commented Feb 26, 2025

🟢 2025-02-26 14:25:02 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 12:14:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 67c227c has started.
2025-02-26 12:14:39 UTC Artifacts will be uploaded here
2025-02-26 12:17:25 UTC ya make is running...
🟡 2025-02-26 13:11:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19172 17830 0 2 1214 126

2025-02-26 13:13:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 13:24:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 64 0 1 0 123

2025-02-26 13:24:52 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-26 13:34:31 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
184 (only retried tests) 62 0 0 0 122

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 12:21:35 UTC Pre-commit check linux-x86_64-release-asan for 67c227c has started.
2025-02-26 12:21:49 UTC Artifacts will be uploaded here
2025-02-26 12:24:49 UTC ya make is running...
🟡 2025-02-26 13:28:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11718 11481 0 193 11 33

2025-02-26 13:29:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 13:35:12 UTC ydbd size 3.7 GiB changed* by -48 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 8d25dd3 merge: 67c227c diff diff %
ydbd size 3 945 558 464 Bytes 3 945 558 416 Bytes -48 Bytes -0.000%
ydbd stripped size 1 374 591 760 Bytes 1 374 591 696 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-26 13:35:14 UTC Check cancelled

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 13:41:24 UTC Pre-commit check linux-x86_64-release-asan for 29db610 has started.
2025-02-26 13:42:05 UTC Artifacts will be uploaded here
2025-02-26 13:45:18 UTC ya make is running...
🟡 2025-02-26 15:05:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11718 11558 0 85 42 33

2025-02-26 15:06:19 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 15:14:06 UTC ydbd size 3.7 GiB changed* by +1.7 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63aaaeb merge: 29db610 diff diff %
ydbd size 3 945 574 488 Bytes 3 947 391 456 Bytes +1.7 MiB +0.046%
ydbd stripped size 1 374 594 864 Bytes 1 375 223 440 Bytes +613.8 KiB +0.046%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-26 15:14:08 UTC Check cancelled

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 13:43:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 29db610 has started.
2025-02-26 13:43:23 UTC Artifacts will be uploaded here
2025-02-26 13:46:19 UTC ya make is running...
🟢 2025-02-26 14:44:31 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19172 17827 0 0 1214 131

🟢 2025-02-26 14:46:18 UTC Build successful.
🟡 2025-02-26 14:46:34 UTC ydbd size 2.1 GiB changed* by +964.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63aaaeb merge: 29db610 diff diff %
ydbd size 2 265 223 160 Bytes 2 266 210 696 Bytes +964.4 KiB +0.044%
ydbd stripped size 477 290 520 Bytes 477 496 536 Bytes +201.2 KiB +0.043%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 26, 2025
@molotkov-and molotkov-and enabled auto-merge (squash) February 26, 2025 15:15
Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 15:18:30 UTC Pre-commit check linux-x86_64-release-asan for d4ca65d has started.
2025-02-26 15:18:47 UTC Artifacts will be uploaded here
2025-02-26 15:21:42 UTC ya make is running...
🟡 2025-02-26 16:30:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11722 11468 0 193 27 34

2025-02-26 16:31:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-26 16:53:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
314 (only retried tests) 272 0 13 1 28

2025-02-26 16:53:56 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-26 17:05:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 47 0 2 0 26

🟢 2025-02-26 17:05:58 UTC Build successful.
🟢 2025-02-26 17:06:28 UTC ydbd size 3.7 GiB changed* by -32 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e0f8b20 merge: d4ca65d diff diff %
ydbd size 3 982 265 248 Bytes 3 982 265 216 Bytes -32 Bytes -0.000%
ydbd stripped size 1 387 038 472 Bytes 1 387 038 408 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 26, 2025

2025-02-26 15:21:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for d4ca65d has started.
2025-02-26 15:21:32 UTC Artifacts will be uploaded here
2025-02-26 15:24:24 UTC ya make is running...
🟡 2025-02-26 16:15:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19174 17815 0 2 1225 132

2025-02-26 16:17:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-26 16:30:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 80 0 0 0 128

🟢 2025-02-26 16:30:24 UTC Build successful.
🟢 2025-02-26 16:30:57 UTC ydbd size 2.1 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: e0f8b20 merge: d4ca65d diff diff %
ydbd size 2 284 785 120 Bytes 2 284 785 232 Bytes +112 Bytes +0.000%
ydbd stripped size 479 196 384 Bytes 479 196 448 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit 9ff271a into ydb-platform:main Feb 27, 2025
12 checks passed
zinal pushed a commit to zinal/ydb that referenced this pull request Feb 27, 2025
@molotkov-and molotkov-and deleted the ldap/fix-memory-leak branch February 27, 2025 08:24
molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Feb 28, 2025
molotkov-and added a commit to molotkov-and/ydb that referenced this pull request Mar 3, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants