The use-heap-after-free error in the Topic SDK code
#15088
Conversation
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Alek5andr-Kotov
changed the title
Alek5andr-Kotov
changed the title
use-heap-after-free error in the Topic SDK code
|
|
||
| template <> | ||
| struct THash<NYdb::NTopic::TTransactionId> { | ||
| size_t operator()(const NYdb::NTopic::TTransactionId& v) const noexcept { |
There was a problem hiding this comment.
А для чего хеш используется? Вроде в HashMap не кладем ничего
There was a problem hiding this comment.
В сессиях чтения и записи хранится список транзакций
https://github.com/ydb-platform/ydb/blob/main/ydb/public/sdk/cpp/src/client/topic/impl/read_session_impl.h#L1380
https://github.com/ydb-platform/ydb/blob/main/ydb/public/sdk/cpp/src/client/topic/impl/write_session_impl.h#L496
| } | ||
|
|
||
| inline | ||
| const std::string& GetTxId(const TTransactionId& x) | ||
| bool operator!=(const TTransactionId& lhs, const TTransactionId& rhs) |
There was a problem hiding this comment.
А зачем нам только оператор !=?
There was a problem hiding this comment.
Для симметрии :)
Changelog entry
A pointer to the transaction was stored in the recorded message. This could lead to a
use-heap-after-freeerror in thelinux-x86_64-release-asanconfiguration#15089
Changelog category
Description for reviewers
Added the
TTransactionIdtype. Now, instead of a pointer,std::optional<TTransactionId>is stored.