Skip to content

Rename EncryptFile/DecryptFile to avoid conflict with windows functions #15116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

These methods conflict with windows macros that turn them into EncryptFileA/EncryptFileW.

Copy link

🟢 2025-02-27 10:48:48 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 10:49:05 UTC Pre-commit check linux-x86_64-release-asan for 2e2940f has started.
2025-02-27 10:49:19 UTC Artifacts will be uploaded here
2025-02-27 10:52:07 UTC ya make is running...
🟡 2025-02-27 12:14:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11751 11477 0 229 12 33

2025-02-27 12:16:29 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 12:30:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
328 (only retried tests) 281 0 19 0 28

2025-02-27 12:31:00 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-27 12:35:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
86 (only retried tests) 59 0 1 0 26

🟢 2025-02-27 12:36:06 UTC Build successful.
🔴 2025-02-27 12:36:33 UTC ydbd size 3.7 GiB changed* by +2.5 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 6b121ad merge: 2e2940f diff diff %
ydbd size 3 982 754 272 Bytes 3 985 411 104 Bytes +2.5 MiB +0.067%
ydbd stripped size 1 387 223 208 Bytes 1 387 765 512 Bytes +529.6 KiB +0.039%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 10:49:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2e2940f has started.
2025-02-27 10:49:53 UTC Artifacts will be uploaded here
2025-02-27 10:52:55 UTC ya make is running...
🟡 2025-02-27 11:53:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19221 17868 0 6 1215 132

2025-02-27 11:55:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 12:14:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 76 0 1 0 127

2025-02-27 12:15:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-27 12:29:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 65 0 0 0 125

🟢 2025-02-27 12:29:11 UTC Build successful.
🟢 2025-02-27 12:29:35 UTC ydbd size 2.1 GiB changed* by +21.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f60bf44 merge: 2e2940f diff diff %
ydbd size 2 286 662 224 Bytes 2 286 683 864 Bytes +21.1 KiB +0.001%
ydbd stripped size 479 414 496 Bytes 479 416 672 Bytes +2.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@UgnineSirdis UgnineSirdis merged commit c5b2980 into ydb-platform:main Feb 27, 2025
14 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@UgnineSirdis UgnineSirdis deleted the rename-encrypt-file branch May 14, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants