Skip to content

Show modal dialog in Hive UI before disabling/enabling tablets starting #15152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 6, 2025
Merged

Show modal dialog in Hive UI before disabling/enabling tablets starting #15152

merged 5 commits into from
Mar 6, 2025

Conversation

SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Feb 27, 2025 •
edited
Loading

Changelog entry

Add confirmation modal dialog in CMS UI when user wants to change tablet settings.

Changelog category

  • Improvement

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

🟢 2025-02-28 16:07:39 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

⚪ 2025-02-27 16:35:24 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6959bee has started.
⚪ 2025-02-27 16:35:41 UTC Artifacts will be uploaded here
⚪ 2025-02-27 16:38:59 UTC ya make is running...
🟡 2025-02-27 17:26:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19191 17841 0 2 1215 133

⚪ 2025-02-27 17:28:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-27 17:46:35 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
197 (only retried tests) 70 0 0 0 127

🟢 2025-02-27 17:46:43 UTC Build successful.
🟢 2025-02-27 17:47:01 UTC ydbd size 2.1 GiB changed* by +5.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1d43db6 merge: 6959bee diff diff %
ydbd size 2 286 685 096 Bytes 2 286 691 144 Bytes +5.9 KiB +0.000%
ydbd stripped size 479 417 824 Bytes 479 422 176 Bytes +4.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

⚪ 2025-02-27 16:35:25 UTC Pre-commit check linux-x86_64-release-asan for 6959bee has started.
⚪ 2025-02-27 16:35:40 UTC Artifacts will be uploaded here
⚪ 2025-02-27 16:38:33 UTC ya make is running...
🟡 2025-02-27 17:46:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11721 11564 0 102 20 35

⚪ 2025-02-27 17:48:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 18:03:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
215 (only retried tests) 184 0 4 0 27

⚪ 2025-02-27 18:03:45 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-27 18:12:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 32 0 0 0 26

🟢 2025-02-27 18:12:13 UTC Build successful.
🟢 2025-02-27 18:12:40 UTC ydbd size 3.7 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1d43db6 merge: 6959bee diff diff %
ydbd size 3 985 411 184 Bytes 3 985 418 176 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 387 765 576 Bytes 1 387 770 312 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 17:49:28 UTC Pre-commit check linux-x86_64-release-asan for 8e188b4 has started.
⚪ 2025-02-28 17:49:57 UTC Artifacts will be uploaded here
⚪ 2025-02-28 17:53:17 UTC ya make is running...
🟡 2025-02-28 18:56:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11694 11534 0 98 28 34

⚪ 2025-02-28 18:57:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 19:11:05 UTC ydbd size 3.7 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 8e188b4 diff diff %
ydbd size 3 986 933 872 Bytes 3 986 940 880 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 388 172 936 Bytes 1 388 177 672 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-28 19:11:07 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 17:49:28 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8e188b4 has started.
⚪ 2025-02-28 17:49:44 UTC Artifacts will be uploaded here
⚪ 2025-02-28 17:52:30 UTC ya make is running...
🟢 2025-02-28 18:48:25 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19171 17815 0 0 1222 134

🟢 2025-02-28 18:50:07 UTC Build successful.
🟢 2025-02-28 18:50:23 UTC ydbd size 2.1 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 8e188b4 diff diff %
ydbd size 2 287 545 688 Bytes 2 287 547 624 Bytes +1.9 KiB +0.000%
ydbd stripped size 479 560 352 Bytes 479 560 608 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:13:19 UTC Pre-commit check linux-x86_64-release-asan for e95102d has started.
⚪ 2025-02-28 19:13:51 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:17:32 UTC ya make is running...
⚫ 2025-02-28 19:38:35 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:13:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for e95102d has started.
⚪ 2025-02-28 19:14:31 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:17:17 UTC ya make is running...
⚫ 2025-02-28 19:38:36 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:40:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 484c332 has started.
⚪ 2025-02-28 19:44:14 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:47:02 UTC ya make is running...
🟡 2025-02-28 20:35:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19171 17819 0 1 1217 134

⚪ 2025-02-28 20:37:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 20:48:20 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 77 0 0 0 124

🟢 2025-02-28 20:48:30 UTC Build successful.
🟢 2025-02-28 20:48:48 UTC ydbd size 2.1 GiB changed* by +1.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 484c332 diff diff %
ydbd size 2 287 545 688 Bytes 2 287 547 624 Bytes +1.9 KiB +0.000%
ydbd stripped size 479 560 352 Bytes 479 560 608 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:42:57 UTC Pre-commit check linux-x86_64-release-asan for 484c332 has started.
⚪ 2025-02-28 19:45:44 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:49:11 UTC ya make is running...
🟡 2025-02-28 20:58:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11694 11535 0 97 27 35

⚪ 2025-02-28 20:59:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 21:15:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
223 (only retried tests) 185 0 5 3 30

⚪ 2025-02-28 21:15:15 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 21:27:27 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 34 0 0 0 29

🟢 2025-02-28 21:27:34 UTC Build successful.
🟢 2025-02-28 21:28:01 UTC ydbd size 3.7 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 484c332 diff diff %
ydbd size 3 986 933 872 Bytes 3 986 940 880 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 388 172 936 Bytes 1 388 177 672 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 11:13:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3c0b3e0 has started.
⚪ 2025-03-04 11:14:05 UTC Artifacts will be uploaded here
⚪ 2025-03-04 11:17:07 UTC ya make is running...
🟡 2025-03-04 12:16:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19169 17809 0 4 1217 139

⚪ 2025-03-04 12:18:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-04 12:34:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 83 0 0 0 128

🟢 2025-03-04 13:04:41 UTC Build successful.
🟢 2025-03-04 13:05:07 UTC ydbd size 2.1 GiB changed* by +944 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9eea4e3 merge: 3c0b3e0 diff diff %
ydbd size 2 289 175 032 Bytes 2 289 175 976 Bytes +944 Bytes +0.000%
ydbd stripped size 479 753 792 Bytes 479 753 920 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 11:13:58 UTC Pre-commit check linux-x86_64-release-asan for 3c0b3e0 has started.
⚪ 2025-03-04 11:14:12 UTC Artifacts will be uploaded here
⚪ 2025-03-04 11:16:57 UTC ya make is running...
🟡 2025-03-04 12:25:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11689 11489 0 148 19 33

⚪ 2025-03-04 12:26:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 12:41:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
256 (only retried tests) 220 0 3 4 29

⚪ 2025-03-04 12:42:07 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-04 12:56:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 34 0 0 0 29

🟢 2025-03-04 12:56:15 UTC Build successful.
🟡 2025-03-04 12:56:47 UTC ydbd size 3.7 GiB changed* by +195.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 18f45b9 merge: 3c0b3e0 diff diff %
ydbd size 3 989 555 664 Bytes 3 989 755 832 Bytes +195.5 KiB +0.005%
ydbd stripped size 1 388 759 272 Bytes 1 388 812 648 Bytes +52.1 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@SammyVimes SammyVimes merged commit 508e93d into ydb-platform:main Mar 6, 2025
12 checks passed
@SammyVimes SammyVimes deleted the hive-ui-show-warning branch March 6, 2025 11:56
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 6, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@SammyVimes @blinkov
Show modal dialog in Hive UI before disabling/enabling tablets starti…
58ce80f 
…ng (#15152)
SammyVimes added a commit to SammyVimes/ydb that referenced this pull request May 21, 2025
@SammyVimes
Show modal dialog in Hive UI before disabling/enabling tablets starti…
3a51bfe 
…ng (ydb-platform#15152)

(cherry picked from commit 508e93d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vporyadke vporyadke vporyadke approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SammyVimes @vporyadke