Skip to content

Switch to library/cpp/charset/lite to avoid unneded dependency on libiconv #15157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

nepal
Copy link
Collaborator

@nepal nepal commented Feb 27, 2025

Changelog entry

Switch to library/cpp/charset/lite to avoid unneded dependency on libiconv

Changelog category

  • Improvement

Description for reviewers

...

Copy link

github-actions bot commented Feb 27, 2025

🟢 2025-02-27 18:06:33 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 18:05:22 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1d1b365 has started.
2025-02-27 18:05:50 UTC Artifacts will be uploaded here
2025-02-27 18:09:00 UTC ya make is running...
🟡 2025-02-27 19:35:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28307 25698 0 7 2470 132

2025-02-27 19:37:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-27 19:51:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
210 (only retried tests) 85 0 0 0 125

🟢 2025-02-27 19:51:19 UTC Build successful.
🟢 2025-02-27 19:51:38 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e2e92e4 merge: 1d1b365 diff diff %
ydbd size 2 286 779 376 Bytes 2 286 779 376 Bytes 0 Bytes 0.000%
ydbd stripped size 479 430 400 Bytes 479 430 400 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 27, 2025

2025-02-27 18:05:52 UTC Pre-commit check linux-x86_64-release-asan for 1d1b365 has started.
2025-02-27 18:06:10 UTC Artifacts will be uploaded here
2025-02-27 18:09:23 UTC ya make is running...
🟡 2025-02-27 19:52:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13835 13641 0 98 63 33

2025-02-27 19:53:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-27 20:06:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
249 (only retried tests) 219 0 2 0 28

2025-02-27 20:06:55 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-27 20:16:06 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58 (only retried tests) 32 0 0 0 26

🟢 2025-02-27 20:16:16 UTC Build successful.
🟢 2025-02-27 20:16:42 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e2e92e4 merge: 1d1b365 diff diff %
ydbd size 3 985 615 488 Bytes 3 985 615 392 Bytes -96 Bytes -0.000%
ydbd stripped size 1 387 818 824 Bytes 1 387 818 760 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nepal nepal enabled auto-merge (squash) February 27, 2025 18:05
@nepal nepal requested a review from alexv-smirnov February 27, 2025 20:19
@nepal nepal merged commit 0076d49 into ydb-platform:main Feb 28, 2025
15 of 16 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants