Skip to content

regularize coalesce pushdown #15163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2025
Merged

regularize coalesce pushdown #15163

merged 1 commit into from
Feb 28, 2025

Conversation

zverevgeny
Copy link
Collaborator

Changelog category

  • Not for changelog (changelog entry is not required)

@zverevgeny zverevgeny requested a review from a team as a code owner February 28, 2025 05:57
@github-actions GitHub Actions
Copy link

🟢 2025-02-28 05:59:06 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 05:59:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28d1a06 has started.
⚪ 2025-02-28 05:59:27 UTC Artifacts will be uploaded here
⚫ 2025-02-28 06:00:04 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 05:59:25 UTC Pre-commit check linux-x86_64-release-asan for 28d1a06 has started.
⚪ 2025-02-28 05:59:42 UTC Artifacts will be uploaded here
⚫ 2025-02-28 06:00:04 UTC Check cancelled

@zverevgeny zverevgeny force-pushed the regularize_coalesce_pushdown branch from 8fb8631 to c677d75 Compare February 28, 2025 05:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 06:01:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for 578aa63 has started.
⚪ 2025-02-28 06:01:26 UTC Artifacts will be uploaded here
⚪ 2025-02-28 06:04:18 UTC ya make is running...
🟡 2025-02-28 06:51:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18890 17531 0 12 1215 132

⚪ 2025-02-28 06:53:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 07:04:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 85 0 1 0 126

⚪ 2025-02-28 07:04:45 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-28 07:18:19 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
189 (only retried tests) 65 0 1 0 123

🟢 2025-02-28 07:18:26 UTC Build successful.
🟢 2025-02-28 07:18:47 UTC ydbd size 2.1 GiB changed* by -2.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ce94a36 merge: 578aa63 diff diff %
ydbd size 2 286 816 688 Bytes 2 286 814 384 Bytes -2.2 KiB -0.000%
ydbd stripped size 479 452 800 Bytes 479 452 096 Bytes -704 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 06:01:28 UTC Pre-commit check linux-x86_64-release-asan for 578aa63 has started.
⚪ 2025-02-28 06:01:44 UTC Artifacts will be uploaded here
⚪ 2025-02-28 06:04:31 UTC ya make is running...
🟡 2025-02-28 07:05:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11625 11519 0 58 12 36

⚪ 2025-02-28 07:06:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 07:19:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
147 (only retried tests) 112 0 5 0 30

⚪ 2025-02-28 07:19:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-28 07:29:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
64 (only retried tests) 35 0 1 0 28

🟢 2025-02-28 07:30:01 UTC Build successful.
🟢 2025-02-28 07:30:31 UTC ydbd size 3.7 GiB changed* by -12.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ce94a36 merge: 578aa63 diff diff %
ydbd size 3 985 651 168 Bytes 3 985 638 112 Bytes -12.8 KiB -0.000%
ydbd stripped size 1 387 843 176 Bytes 1 387 839 912 Bytes -3.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny added the rebase-and-check Rebase PR with the current base branch and check label Feb 28, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 07:53:51 UTC Pre-commit check linux-x86_64-release-asan for 578aa63 has started.
⚪ 2025-02-28 07:54:07 UTC Artifacts will be uploaded here
⚪ 2025-02-28 07:56:58 UTC ya make is running...
🟡 2025-02-28 09:07:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11625 11432 0 145 14 34

⚪ 2025-02-28 09:08:27 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 09:21:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
257 (only retried tests) 217 0 9 1 30

⚪ 2025-02-28 09:21:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-28 09:33:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 43 0 1 0 29

🟢 2025-02-28 09:33:52 UTC Build successful.
🟢 2025-02-28 09:34:23 UTC ydbd size 3.7 GiB changed* by -12.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ce94a36 merge: 578aa63 diff diff %
ydbd size 3 985 651 168 Bytes 3 985 638 112 Bytes -12.8 KiB -0.000%
ydbd stripped size 1 387 843 176 Bytes 1 387 839 912 Bytes -3.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 07:56:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 578aa63 has started.
⚪ 2025-02-28 07:57:26 UTC Artifacts will be uploaded here
⚪ 2025-02-28 08:01:08 UTC ya make is running...
🟡 2025-02-28 08:56:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18890 17538 0 6 1215 131

⚪ 2025-02-28 08:58:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 09:09:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
199 (only retried tests) 76 0 0 0 123

🟢 2025-02-28 09:09:49 UTC Build successful.
🟢 2025-02-28 09:10:17 UTC ydbd size 2.1 GiB changed* by -2.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ce94a36 merge: 578aa63 diff diff %
ydbd size 2 286 816 688 Bytes 2 286 814 384 Bytes -2.2 KiB -0.000%
ydbd stripped size 479 452 800 Bytes 479 452 096 Bytes -704 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit d077bd0 into ydb-platform:main Feb 28, 2025
17 of 18 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@zverevgeny
regularize coalesce pushdown (ydb-platform#15163)
5f8d462
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@zverevgeny @blinkov
regularize coalesce pushdown (#15163)
8f9b55e
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Apr 21, 2025
@zverevgeny @dorooleg
regularize coalesce pushdown (ydb-platform#15163)
ef5907c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelvelikhov pavelvelikhov pavelvelikhov approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zverevgeny @pavelvelikhov