Skip to content

limitless solomon read actor draft #15200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 11, 2025
Merged

limitless solomon read actor draft #15200

merged 9 commits into from
Mar 11, 2025

Conversation

evanevanevanevannnn
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

first draft of new solomon read actor that works without monitoring api limits

@evanevanevanevannnn evanevanevanevannnn requested review from a team as code owners February 28, 2025 12:19
@github-actions GitHub Actions
Copy link

🟢 2025-02-28 12:20:56 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 12:22:20 UTC Pre-commit check linux-x86_64-release-asan for 18b9729 has started.
⚪ 2025-02-28 12:22:35 UTC Artifacts will be uploaded here
⚪ 2025-02-28 12:25:40 UTC ya make is running...
🔴 2025-02-28 13:06:31 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 12:23:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 18b9729 has started.
⚪ 2025-02-28 12:23:51 UTC Artifacts will be uploaded here
⚪ 2025-02-28 12:27:01 UTC ya make is running...
🔴 2025-02-28 12:50:44 UTC Build failed, see the logs. Also see fail summary

uzhastik
uzhastik reviewed Feb 28, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:15:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 089dabf has started.
⚪ 2025-03-03 12:16:04 UTC Artifacts will be uploaded here
⚫ 2025-03-03 12:16:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:16:29 UTC Pre-commit check linux-x86_64-release-asan for 089dabf has started.
⚫ 2025-03-03 12:16:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:17:34 UTC Pre-commit check linux-x86_64-release-asan for c041cf2 has started.
⚪ 2025-03-03 12:18:08 UTC Artifacts will be uploaded here
⚪ 2025-03-03 12:21:34 UTC ya make is running...
🟡 2025-03-03 14:18:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13640 13326 0 210 68 36

⚪ 2025-03-03 14:19:49 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 14:39:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
402 (only retried tests) 321 0 44 6 31

⚪ 2025-03-03 14:39:38 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-03 14:51:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
120 (only retried tests) 70 0 15 5 30

🟢 2025-03-03 14:52:08 UTC Build successful.
🔴 2025-03-03 14:52:45 UTC ydbd size 3.7 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 1f60fc8 merge: c041cf2 diff diff %
ydbd size 3 988 495 648 Bytes 3 992 059 272 Bytes +3.4 MiB +0.089%
ydbd stripped size 1 388 506 888 Bytes 1 389 365 064 Bytes +838.1 KiB +0.062%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 12:17:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for c041cf2 has started.
⚪ 2025-03-03 12:18:01 UTC Artifacts will be uploaded here
⚪ 2025-03-03 12:21:44 UTC ya make is running...
🟡 2025-03-03 13:45:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28025 25404 0 18 2466 137

⚪ 2025-03-03 13:48:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-03 14:07:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
231 (only retried tests) 92 0 15 0 124

⚪ 2025-03-03 14:07:15 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-03 14:18:50 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 64 0 15 0 122

🟢 2025-03-03 14:19:04 UTC Build successful.
🟡 2025-03-03 14:19:25 UTC ydbd size 2.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1f60fc8 merge: c041cf2 diff diff %
ydbd size 2 288 460 760 Bytes 2 290 501 176 Bytes +1.9 MiB +0.089%
ydbd stripped size 479 649 216 Bytes 479 929 536 Bytes +273.8 KiB +0.058%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA requested changes Mar 3, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 21:57:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4f53232 has started.
⚪ 2025-03-03 21:57:42 UTC Artifacts will be uploaded here
⚪ 2025-03-03 22:00:56 UTC ya make is running...
🔴 2025-03-03 22:22:19 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025 •
edited
Loading

⚪ 2025-03-03 21:57:46 UTC Pre-commit check linux-x86_64-release-asan for 4f53232 has started.
⚪ 2025-03-03 21:58:00 UTC Artifacts will be uploaded here
⚪ 2025-03-03 22:01:09 UTC ya make is running...
🔴 2025-03-03 22:19:45 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 08:52:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for 64e5b78 has started.
⚪ 2025-03-04 08:52:56 UTC Artifacts will be uploaded here
⚪ 2025-03-04 08:56:05 UTC ya make is running...
🟡 2025-03-04 09:55:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28031 25411 0 19 2465 136

⚪ 2025-03-04 09:57:32 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 10:10:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
224 (only retried tests) 83 0 15 0 126

⚪ 2025-03-04 10:11:04 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-04 10:24:20 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
203 (only retried tests) 63 0 15 0 125

🟢 2025-03-04 10:24:31 UTC Build successful.
🟡 2025-03-04 10:24:56 UTC ydbd size 2.1 GiB changed* by +1.9 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 16444c9 merge: 64e5b78 diff diff %
ydbd size 2 289 038 592 Bytes 2 291 069 184 Bytes +1.9 MiB +0.089%
ydbd stripped size 479 730 880 Bytes 480 009 216 Bytes +271.8 KiB +0.058%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025 •
edited
Loading

⚪ 2025-03-04 08:52:46 UTC Pre-commit check linux-x86_64-release-asan for 64e5b78 has started.
⚪ 2025-03-04 08:53:02 UTC Artifacts will be uploaded here
⚪ 2025-03-04 08:56:21 UTC ya make is running...
🟡 2025-03-04 10:06:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13645 13427 0 157 25 36

⚪ 2025-03-04 10:07:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-04 10:29:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
279 (only retried tests) 228 0 18 1 32

⚪ 2025-03-04 10:29:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-04 10:43:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
85 (only retried tests) 39 0 15 1 30

🟢 2025-03-04 10:44:01 UTC Build successful.
🔴 2025-03-04 10:44:31 UTC ydbd size 3.7 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 16444c9 merge: 64e5b78 diff diff %
ydbd size 3 989 529 416 Bytes 3 993 084 688 Bytes +3.4 MiB +0.089%
ydbd stripped size 1 388 748 488 Bytes 1 389 594 440 Bytes +826.1 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 14:53:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 23c4850 has started.
⚪ 2025-03-05 14:53:59 UTC Artifacts will be uploaded here
⚪ 2025-03-05 14:57:14 UTC ya make is running...
⚫ 2025-03-05 14:58:43 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 14:53:44 UTC Pre-commit check linux-x86_64-release-asan for 23c4850 has started.
⚪ 2025-03-05 14:53:59 UTC Artifacts will be uploaded here
⚪ 2025-03-05 14:57:07 UTC ya make is running...
⚫ 2025-03-05 14:58:40 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 15:00:56 UTC Pre-commit check linux-x86_64-release-asan for adfe877 has started.
⚪ 2025-03-05 15:01:15 UTC Artifacts will be uploaded here
⚪ 2025-03-05 15:04:18 UTC ya make is running...
🟡 2025-03-05 16:41:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13680 13319 0 259 63 39

⚪ 2025-03-05 16:42:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 17:00:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
530 (only retried tests) 278 0 215 0 37

⚪ 2025-03-05 17:00:55 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-05 17:17:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
391 (only retried tests) 145 0 173 38 35

🟢 2025-03-05 17:17:18 UTC Build successful.
🔴 2025-03-05 17:17:51 UTC ydbd size 3.7 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 7a630cf merge: adfe877 diff diff %
ydbd size 3 996 782 216 Bytes 4 000 385 096 Bytes +3.4 MiB +0.090%
ydbd stripped size 1 390 173 096 Bytes 1 391 027 048 Bytes +833.9 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 15:00:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for adfe877 has started.
⚪ 2025-03-05 15:01:12 UTC Artifacts will be uploaded here
⚪ 2025-03-05 15:04:26 UTC ya make is running...
🟡 2025-03-05 16:37:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28055 25462 0 6 2466 121

⚪ 2025-03-05 16:39:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 16:52:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 72 0 2 0 108

⚪ 2025-03-05 16:52:40 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-05 17:05:18 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 (only retried tests) 48 0 1 0 105

🟢 2025-03-05 17:05:31 UTC Build successful.
🟡 2025-03-05 17:05:57 UTC ydbd size 2.1 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 7a630cf merge: adfe877 diff diff %
ydbd size 2 293 872 720 Bytes 2 295 939 904 Bytes +2.0 MiB +0.090%
ydbd stripped size 480 356 608 Bytes 480 642 080 Bytes +278.8 KiB +0.059%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:43:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7389f3e has started.
⚪ 2025-03-06 10:44:07 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:47:26 UTC ya make is running...
🟡 2025-03-06 12:18:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28076 25473 0 2 2477 124

⚪ 2025-03-06 12:21:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 12:34:00 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
187 (only retried tests) 80 0 0 0 107

🟢 2025-03-06 12:34:12 UTC Build successful.
🟡 2025-03-06 12:34:35 UTC ydbd size 2.1 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 9059150 merge: 7389f3e diff diff %
ydbd size 2 294 011 160 Bytes 2 296 074 272 Bytes +2.0 MiB +0.090%
ydbd stripped size 480 572 928 Bytes 480 854 336 Bytes +274.8 KiB +0.059%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:44:37 UTC Pre-commit check linux-x86_64-release-asan for 7389f3e has started.
⚪ 2025-03-06 10:44:54 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:48:11 UTC ya make is running...
🟡 2025-03-06 12:35:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13701 13311 0 276 78 36

⚪ 2025-03-06 12:37:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 12:57:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
554 (only retried tests) 306 0 186 27 35

⚪ 2025-03-06 12:57:33 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 13:14:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
389 (only retried tests) 155 0 175 25 34

🟢 2025-03-06 13:14:36 UTC Build successful.
🔴 2025-03-06 13:15:16 UTC ydbd size 3.7 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 9059150 merge: 7389f3e diff diff %
ydbd size 3 995 283 720 Bytes 3 998 890 704 Bytes +3.4 MiB +0.090%
ydbd stripped size 1 389 109 672 Bytes 1 389 967 720 Bytes +837.9 KiB +0.062%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 09:50:55 UTC Pre-commit check linux-x86_64-release-asan for dbb29fd has started.
⚪ 2025-03-07 09:51:09 UTC Artifacts will be uploaded here
⚪ 2025-03-07 09:54:14 UTC ya make is running...
🟡 2025-03-07 11:41:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13708 13593 0 66 16 33

⚪ 2025-03-07 11:43:03 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 11:58:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
164 (only retried tests) 131 0 1 1 31

⚪ 2025-03-07 11:58:24 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-07 12:10:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 32 0 1 0 28

🟢 2025-03-07 12:10:50 UTC Build successful.
🔴 2025-03-07 12:11:21 UTC ydbd size 3.7 GiB changed* by +3.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 1237379 merge: dbb29fd diff diff %
ydbd size 3 994 598 216 Bytes 3 998 201 040 Bytes +3.4 MiB +0.090%
ydbd stripped size 1 388 829 224 Bytes 1 389 683 176 Bytes +833.9 KiB +0.061%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 09:52:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for dbb29fd has started.
⚪ 2025-03-07 09:52:29 UTC Artifacts will be uploaded here
⚪ 2025-03-07 09:55:33 UTC ya make is running...
🟡 2025-03-07 11:26:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28083 25491 0 5 2466 121

⚪ 2025-03-07 11:29:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 11:48:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
175 (only retried tests) 66 0 1 0 108

⚪ 2025-03-07 11:48:43 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 11:59:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
154 (only retried tests) 48 0 0 0 106

🟢 2025-03-07 11:59:54 UTC Build successful.
🟡 2025-03-07 12:00:18 UTC ydbd size 2.1 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1237379 merge: dbb29fd diff diff %
ydbd size 2 293 645 624 Bytes 2 295 708 816 Bytes +2.0 MiB +0.090%
ydbd stripped size 480 484 512 Bytes 480 765 824 Bytes +274.7 KiB +0.059%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

GrigoriyPA
GrigoriyPA reviewed Mar 10, 2025
View reviewed changes
ydb/core/kqp/session_actor/kqp_worker_common.cpp
@@ -189,7 +189,9 @@ bool CanCacheQuery(const NKqpProto::TKqpPhyQuery& query) {
// S3 provider stores S3 paths to read in AST,
// YT provider opens read session during compilation,
// so we can't cache such queries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сюда бы ещё комент про solomon провайдер, что кеш для него выключен из-за runtime листинга (и по идее это будет исправлено)

ydb/library/yql/providers/solomon/actors/dq_solomon_actors_util.cpp

namespace NYql::NDq {

TMetricsEncoder::TMetricsEncoder(const NSo::NProto::TDqSolomonShardScheme& scheme, bool useCloudFormat)
TMetricsEncoder::TMetricsEncoder(const NSo::NProto::TDqSolomonShardScheme& scheme, bool useCloudFormat)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этот отступ тут нужен? Как будто всё ниже идёт без отступа

@evanevanevanevannnn evanevanevanevannnn merged commit 82b3fae into ydb-platform:main Mar 11, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@evanevanevanevannnn @adameat
limitless solomon read actor draft (ydb-platform#15200)
b053dc4
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@evanevanevanevannnn @blinkov
limitless solomon read actor draft (#15200)
62ded5c
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Mar 26, 2025
@evanevanevanevannnn
limitless solomon read actor draft (ydb-platform#15200)
b76e4df
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Mar 26, 2025
@evanevanevanevannnn
limitless solomon read actor draft (ydb-platform#15200)
aacab22
evanevanevanevannnn added a commit to evanevanevanevannnn/ydb that referenced this pull request Mar 26, 2025
@evanevanevanevannnn
limitless solomon read actor draft (ydb-platform#15200)
cea4e77
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@evanevanevanevannnn
limitless solomon read actor draft (ydb-platform#15200)
38d1421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik left review comments

@gridnevvvit gridnevvvit gridnevvvit approved these changes

@GrigoriyPA GrigoriyPA GrigoriyPA approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evanevanevanevannnn @gridnevvvit @GrigoriyPA @uzhastik @rvu1024