Skip to content

25-1: Add saving of the intermediate state of the checksum calculation in import from s3 #15205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Feb 28, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Баг-фикс в еще не вышедшей фиче под фича-флагом. Нужен чтобы в дальнейшем ее можно было включить без проблем с откатом версии.

Cherry-picked from #15046

@pixcc pixcc requested a review from a team as a code owner February 28, 2025 13:23
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 13:24:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for c76ffa4 has started.
2025-02-28 13:24:50 UTC Artifacts will be uploaded here
2025-02-28 13:28:08 UTC ya make is running...
🟡 2025-02-28 15:12:28 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28080 25474 0 6 2464 136

2025-02-28 15:15:05 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 15:36:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
214 (only retried tests) 77 0 1 4 132

2025-02-28 15:36:24 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 15:56:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
200 (only retried tests) 65 0 0 4 131

🟢 2025-02-28 15:56:25 UTC Build successful.
🟢 2025-02-28 15:56:46 UTC ydbd size 2.1 GiB changed* by +79.8 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: d0aa06b merge: c76ffa4 diff diff %
ydbd size 2 241 509 384 Bytes 2 241 591 120 Bytes +79.8 KiB +0.004%
ydbd stripped size 474 783 992 Bytes 474 799 544 Bytes +15.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc self-assigned this Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

2025-02-28 13:24:44 UTC Pre-commit check linux-x86_64-release-asan for c76ffa4 has started.
2025-02-28 13:24:58 UTC Artifacts will be uploaded here
2025-02-28 13:28:07 UTC ya make is running...
🟡 2025-02-28 15:09:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13829 13757 0 23 9 40

2025-02-28 15:11:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 15:31:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
110 (only retried tests) 72 0 0 1 37

🟢 2025-02-28 15:31:46 UTC Build successful.
🟡 2025-02-28 15:32:11 UTC ydbd size 3.6 GiB changed* by +138.5 KiB, which is >= 100.0 KiB vs stable-25-1: Warning

ydbd size dash stable-25-1: d0aa06b merge: c76ffa4 diff diff %
ydbd size 3 899 168 880 Bytes 3 899 310 704 Bytes +138.5 KiB +0.004%
ydbd stripped size 1 364 771 248 Bytes 1 364 830 896 Bytes +58.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc enabled auto-merge (squash) February 28, 2025 15:59
@pixcc pixcc merged commit d650718 into ydb-platform:stable-25-1 Feb 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants