Skip to content

[CBO] added enableshuffleelimination flag #15218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

[CBO] added enableshuffleelimination flag #15218

merged 2 commits into from
Feb 28, 2025

Conversation

pashandor789
Copy link
Collaborator

@pashandor789 pashandor789 commented Feb 28, 2025 •
edited
Loading

Changelog entry

Remove perfomance degradation by switching to the old enumeration algorithm

Changelog category

Not for changelog (changelog entry is not required)

@pashandor789 pashandor789 requested review from a team as code owners February 28, 2025 17:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

🟢 2025-02-28 17:43:10 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 17:33:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for a487c2f has started.
⚪ 2025-02-28 17:33:35 UTC Artifacts will be uploaded here
⚪ 2025-02-28 17:36:31 UTC ya make is running...
🟡 2025-02-28 18:31:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26243 23632 0 11 2464 136

⚪ 2025-02-28 18:34:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 18:50:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 85 0 10 0 125

⚪ 2025-02-28 18:50:47 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-28 19:03:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 70 0 10 0 124

🟢 2025-02-28 19:03:23 UTC Build successful.
🟢 2025-02-28 19:03:44 UTC ydbd size 2.1 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: a487c2f diff diff %
ydbd size 2 287 545 688 Bytes 2 287 545 784 Bytes +96 Bytes +0.000%
ydbd stripped size 479 560 352 Bytes 479 560 352 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 17:33:09 UTC Pre-commit check linux-x86_64-release-asan for a487c2f has started.
⚪ 2025-02-28 17:33:40 UTC Artifacts will be uploaded here
⚪ 2025-02-28 17:36:28 UTC ya make is running...
🟡 2025-02-28 18:50:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11872 11701 0 118 16 37

⚪ 2025-02-28 18:52:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 19:14:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
231 (only retried tests) 187 0 11 2 31

⚪ 2025-02-28 19:14:42 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-28 19:26:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
79 (only retried tests) 40 0 10 0 29

🟢 2025-02-28 19:26:43 UTC Build successful.
🟢 2025-02-28 19:27:16 UTC ydbd size 3.7 GiB changed* by +336 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: a487c2f diff diff %
ydbd size 3 986 933 872 Bytes 3 986 934 208 Bytes +336 Bytes +0.000%
ydbd stripped size 1 388 172 936 Bytes 1 388 173 128 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot removed the bugfix label Feb 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:34:02 UTC Pre-commit check linux-x86_64-release-asan for 32b8106 has started.
⚪ 2025-02-28 19:34:16 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:37:08 UTC ya make is running...
🟡 2025-02-28 20:46:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11872 11710 0 100 28 34

⚪ 2025-02-28 20:47:58 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-28 21:01:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
216 (only retried tests) 181 0 2 1 32

⚪ 2025-02-28 21:01:23 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-28 21:12:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 31 0 0 0 31

🟢 2025-02-28 21:13:05 UTC Build successful.
🟢 2025-02-28 21:13:33 UTC ydbd size 3.7 GiB changed* by +336 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 32b8106 diff diff %
ydbd size 3 986 933 872 Bytes 3 986 934 208 Bytes +336 Bytes +0.000%
ydbd stripped size 1 388 172 936 Bytes 1 388 173 128 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 28, 2025 •
edited
Loading

⚪ 2025-02-28 19:34:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 32b8106 has started.
⚪ 2025-02-28 19:34:17 UTC Artifacts will be uploaded here
⚪ 2025-02-28 19:37:05 UTC ya make is running...
🟡 2025-02-28 20:30:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26243 23637 0 1 2465 140

⚪ 2025-02-28 20:32:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-28 20:47:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
208 (only retried tests) 81 0 0 0 127

🟢 2025-02-28 20:47:16 UTC Build successful.
🟢 2025-02-28 20:47:36 UTC ydbd size 2.1 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: bf4f55b merge: 32b8106 diff diff %
ydbd size 2 287 545 688 Bytes 2 287 545 784 Bytes +96 Bytes +0.000%
ydbd stripped size 479 560 352 Bytes 479 560 352 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pashandor789 pashandor789 merged commit d08419b into ydb-platform:main Feb 28, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@pashandor789
[CBO] added enableshuffleelimination flag (ydb-platform#15218)
71f5ae5
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Closed
This was referenced Mar 10, 2025
Merged
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@pashandor789 @blinkov
[CBO] added enableshuffleelimination flag (#15218)
2e82311
pashandor789 added a commit to pashandor789/ydb that referenced this pull request May 5, 2025
@pashandor789
[CBO] added enableshuffleelimination flag (ydb-platform#15218)
7be4e47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pashandor789 @gridnevvvit