Skip to content

[KIKIMR-22738] (-) minor fixes merge first decoupling ydb/core/control <-> ydb/core/base #15265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

lberserq
Copy link
Contributor

@lberserq lberserq commented Mar 3, 2025

Changelog entry

Some small fixes after merge first part of decoupling

Changelog category

  • Improvement

Description for reviewers

Remove dependencies from ydb/core/control/lib move it to ydb/core/control
add missing dep ydb/core/mon_alloc -> ydb/core/mon
...

Copy link

github-actions bot commented Mar 3, 2025

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Copy link

github-actions bot commented Mar 3, 2025

🟢 2025-03-03 14:28:43 UTC The validation of the Pull Request description is successful.

@alexvru alexvru added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 6, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 15:44:43 UTC Pre-commit check linux-x86_64-release-asan for d7fe49d has started.
2025-03-06 15:44:47 UTC Artifacts will be uploaded here
2025-03-06 15:47:44 UTC ya make is running...
🟡 2025-03-06 16:53:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12669 12507 0 98 28 36

2025-03-06 16:54:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 17:11:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
234 (only retried tests) 196 0 4 2 32

2025-03-06 17:11:23 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-06 17:22:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 38 0 0 1 29

🟢 2025-03-06 17:23:05 UTC Build successful.
🟢 2025-03-06 17:23:39 UTC ydbd size 3.7 GiB changed* by +27.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0d66c0 merge: d7fe49d diff diff %
ydbd size 3 995 104 672 Bytes 3 995 132 720 Bytes +27.4 KiB +0.001%
ydbd stripped size 1 389 062 664 Bytes 1 389 064 456 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 15:45:45 UTC Pre-commit check linux-x86_64-relwithdebinfo for d7fe49d has started.
2025-03-06 15:45:59 UTC Artifacts will be uploaded here
2025-03-06 15:48:52 UTC ya make is running...
🟢 2025-03-06 16:43:43 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27034 24284 0 0 2694 56

🟢 2025-03-06 16:47:17 UTC Build successful.
🟢 2025-03-06 16:47:37 UTC ydbd size 2.1 GiB changed* by +16.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0d66c0 merge: d7fe49d diff diff %
ydbd size 2 293 961 784 Bytes 2 293 979 136 Bytes +16.9 KiB +0.001%
ydbd stripped size 480 565 376 Bytes 480 566 656 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru merged commit b654981 into ydb-platform:main Mar 7, 2025
15 checks passed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants