Skip to content

LocalDB: low-priority cancellable transactions #15355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

snaury
Copy link
Member

@snaury snaury commented Mar 5, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Related to #14936.

Support for low-priority cancellable transactions in LocalDB, which will be used to implement better datashard reads cancellation.

@snaury snaury self-assigned this Mar 5, 2025
Copy link

github-actions bot commented Mar 5, 2025

🟢 2025-03-05 13:14:22 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 13:14:47 UTC Pre-commit check linux-x86_64-release-asan for b8242c9 has started.
2025-03-05 13:15:07 UTC Artifacts will be uploaded here
2025-03-05 13:18:02 UTC ya make is running...
🟡 2025-03-05 14:51:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13481 13333 0 93 16 39

2025-03-05 14:52:34 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-05 15:11:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
211 (only retried tests) 169 0 5 3 34

2025-03-05 15:12:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-05 15:26:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 36 0 3 1 33

🟢 2025-03-05 15:26:42 UTC Build successful.
🟢 2025-03-05 15:27:12 UTC ydbd size 3.7 GiB changed* by +79.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a01e65f merge: b8242c9 diff diff %
ydbd size 3 995 190 984 Bytes 3 995 272 336 Bytes +79.4 KiB +0.002%
ydbd stripped size 1 390 014 632 Bytes 1 390 048 072 Bytes +32.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 5, 2025

2025-03-05 13:16:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for b8242c9 has started.
2025-03-05 13:17:27 UTC Artifacts will be uploaded here
2025-03-05 13:20:49 UTC ya make is running...
🟡 2025-03-05 14:40:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27846 25252 0 2 2467 125

2025-03-05 14:43:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-05 14:56:43 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 72 0 0 0 110

🟢 2025-03-05 14:56:54 UTC Build successful.
🟢 2025-03-05 14:57:15 UTC ydbd size 2.1 GiB changed* by +48.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a01e65f merge: b8242c9 diff diff %
ydbd size 2 292 785 416 Bytes 2 292 834 744 Bytes +48.2 KiB +0.002%
ydbd stripped size 480 305 216 Bytes 480 322 688 Bytes +17.1 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review March 5, 2025 14:57
@snaury snaury requested a review from lex007in March 5, 2025 14:58
lex007in
lex007in previously approved these changes Mar 6, 2025
@snaury snaury force-pushed the bugfix-14936-cancel-enqueued-reads branch from 77916c4 to 4798870 Compare March 6, 2025 07:16
@snaury snaury requested a review from lex007in March 6, 2025 07:18
Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 07:20:02 UTC Pre-commit check linux-x86_64-release-asan for 9d1fdab has started.
2025-03-06 07:20:17 UTC Artifacts will be uploaded here
2025-03-06 07:23:26 UTC ya make is running...
🟡 2025-03-06 09:06:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13493 13089 0 288 77 39

2025-03-06 09:07:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 09:25:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
581 (only retried tests) 300 0 189 59 33

2025-03-06 09:25:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 09:41:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
421 (only retried tests) 158 0 184 46 33

🟢 2025-03-06 09:42:21 UTC Build successful.
🟢 2025-03-06 09:42:59 UTC ydbd size 3.7 GiB changed* by -3.4 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f401330 merge: 9d1fdab diff diff %
ydbd size 3 997 165 976 Bytes 3 993 619 784 Bytes -3.4 MiB -0.089%
ydbd stripped size 1 390 278 760 Bytes 1 388 749 832 Bytes -1.5 MiB -0.110%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 6, 2025

2025-03-06 07:20:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9d1fdab has started.
2025-03-06 07:20:28 UTC Artifacts will be uploaded here
2025-03-06 07:23:22 UTC ya make is running...
🟡 2025-03-06 08:39:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27858 25262 0 3 2470 123

2025-03-06 08:42:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 08:55:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 70 0 0 0 108

🟢 2025-03-06 08:55:29 UTC Build successful.
🟢 2025-03-06 08:55:51 UTC ydbd size 2.1 GiB changed* by -896.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f401330 merge: 9d1fdab diff diff %
ydbd size 2 294 064 440 Bytes 2 293 146 152 Bytes -896.8 KiB -0.040%
ydbd stripped size 480 395 392 Bytes 480 458 432 Bytes +61.6 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury enabled auto-merge (squash) March 6, 2025 07:25
@snaury snaury merged commit 7fc471f into ydb-platform:main Mar 6, 2025
12 checks passed
@snaury snaury deleted the bugfix-14936-cancel-enqueued-reads branch March 6, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants