Skip to content

(refactoring) Basic TTopicMessage #15381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 6, 2025
Merged

(refactoring) Basic TTopicMessage #15381

merged 4 commits into from
Mar 6, 2025

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Mar 5, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@CyberROFL CyberROFL requested a review from nshestakov March 5, 2025 18:50
@CyberROFL CyberROFL self-assigned this Mar 5, 2025
@CyberROFL CyberROFL marked this pull request as ready for review March 5, 2025 18:51
@CyberROFL CyberROFL requested a review from a team as a code owner March 5, 2025 18:51
@CyberROFL CyberROFL requested a review from vporyadke March 5, 2025 18:51
@CyberROFL CyberROFL enabled auto-merge (squash) March 5, 2025 18:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

🟢 2025-03-05 18:51:57 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 18:52:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 45532c3 has started.
⚪ 2025-03-05 18:52:43 UTC Artifacts will be uploaded here
⚪ 2025-03-05 18:55:24 UTC ya make is running...
🔴 2025-03-05 19:02:36 UTC Build failed, see the logs. Also see fail summary
🟢 2025-03-05 19:02:47 UTC ydbd size 2.1 GiB changed* by +11.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0c27d9 merge: 45532c3 diff diff %
ydbd size 2 294 056 144 Bytes 2 294 068 368 Bytes +11.9 KiB +0.001%
ydbd stripped size 480 390 528 Bytes 480 394 432 Bytes +3.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

⚪ 2025-03-05 18:53:05 UTC Pre-commit check linux-x86_64-release-asan for 45532c3 has started.
⚪ 2025-03-05 18:53:20 UTC Artifacts will be uploaded here
⚪ 2025-03-05 18:56:03 UTC ya make is running...
🔴 2025-03-05 18:59:30 UTC Build failed, see the logs. Also see fail summary

@CyberROFL CyberROFL requested review from Enjection and removed request for vporyadke March 5, 2025 18:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:05:40 UTC Pre-commit check linux-x86_64-release-asan for 849bd10 has started.
⚪ 2025-03-06 10:05:54 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:08:44 UTC ya make is running...
🔴 2025-03-06 10:12:32 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:07:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 849bd10 has started.
⚪ 2025-03-06 10:07:15 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:10:08 UTC ya make is running...
🔴 2025-03-06 10:16:29 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:18:26 UTC Pre-commit check linux-x86_64-release-asan for fb3aa57 has started.
⚪ 2025-03-06 10:18:42 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:21:34 UTC ya make is running...
🔴 2025-03-06 10:28:55 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:20:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for fb3aa57 has started.
⚪ 2025-03-06 10:20:41 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:23:26 UTC ya make is running...
🔴 2025-03-06 10:31:22 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:53:07 UTC Pre-commit check linux-x86_64-release-asan for 1e9f288 has started.
⚪ 2025-03-06 10:53:35 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:56:55 UTC ya make is running...
🟡 2025-03-06 12:11:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11749 11367 0 273 71 38

⚪ 2025-03-06 12:12:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 12:32:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
555 (only retried tests) 275 0 200 44 36

⚪ 2025-03-06 12:32:50 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 12:49:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
428 (only retried tests) 179 0 182 33 34

🟢 2025-03-06 12:49:59 UTC Build successful.
🟢 2025-03-06 12:50:37 UTC ydbd size 3.7 GiB changed* by -1.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9059150 merge: 1e9f288 diff diff %
ydbd size 3 995 283 720 Bytes 3 995 281 752 Bytes -1.9 KiB -0.000%
ydbd stripped size 1 389 109 672 Bytes 1 389 108 392 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 10:56:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e9f288 has started.
⚪ 2025-03-06 10:56:40 UTC Artifacts will be uploaded here
⚪ 2025-03-06 10:59:30 UTC ya make is running...
🟡 2025-03-06 11:54:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19211 17858 0 5 1229 119

⚪ 2025-03-06 11:56:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 12:10:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 74 0 0 0 108

🟢 2025-03-06 12:10:41 UTC Build successful.
🟡 2025-03-06 12:11:02 UTC ydbd size 2.1 GiB changed* by +850.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 78f10f9 merge: 1e9f288 diff diff %
ydbd size 2 293 148 520 Bytes 2 294 019 272 Bytes +850.3 KiB +0.038%
ydbd stripped size 480 458 880 Bytes 480 572 736 Bytes +111.2 KiB +0.024%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit 1e9aba9 into ydb-platform:main Mar 6, 2025
12 checks passed
@CyberROFL CyberROFL deleted the topic-message branch March 6, 2025 13:20
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 6, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@CyberROFL @blinkov
(refactoring) Basic TTopicMessage (#15381)
48c3625
nshestakov pushed a commit to nshestakov/ydb that referenced this pull request May 16, 2025
@CyberROFL @nshestakov
(refactoring) Basic TTopicMessage (ydb-platform#15381)
7fc930f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

@nshestakov nshestakov Awaiting requested review from nshestakov

Assignees

@CyberROFL CyberROFL

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @Enjection