Skip to content

Correct ScanActor termination #15395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

Correct ScanActor termination #15395

merged 2 commits into from
Mar 6, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Mar 6, 2025 •
edited
Loading

Changelog entry

...

Changelog category

  • New feature
  • Experimental feature
  • Improvement
  • Performance improvement
  • User Interface
  • Bugfix
  • Backward incompatible change
  • Documentation (changelog entry is not required)
  • Not for changelog (changelog entry is not required)

Description for reviewers

ComputeActor descendents should NOT override PassAway for resource freeing and use DoTerminateImpl instead
#15393

@Hor911 Hor911 requested a review from a team as a code owner March 6, 2025 09:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

🟢 2025-03-06 12:54:11 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 09:32:41 UTC Pre-commit check linux-x86_64-release-asan for 9453325 has started.
⚪ 2025-03-06 09:32:56 UTC Artifacts will be uploaded here
⚪ 2025-03-06 09:35:37 UTC ya make is running...
🟡 2025-03-06 10:42:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11631 11319 0 247 29 36

⚪ 2025-03-06 10:43:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 10:59:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
386 (only retried tests) 285 0 70 0 31

⚪ 2025-03-06 10:59:28 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 11:14:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
141 (only retried tests) 110 0 1 1 29

🟢 2025-03-06 11:14:48 UTC Build successful.
🟢 2025-03-06 11:15:22 UTC ydbd size 3.7 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 89fbf3d merge: 9453325 diff diff %
ydbd size 3 993 538 432 Bytes 3 993 541 568 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 388 716 392 Bytes 1 388 717 032 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 09:32:41 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9453325 has started.
⚪ 2025-03-06 09:32:56 UTC Artifacts will be uploaded here
⚪ 2025-03-06 09:35:36 UTC ya make is running...
🟡 2025-03-06 10:22:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18885 17550 0 2 1217 116

⚪ 2025-03-06 10:24:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 10:35:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 62 0 1 0 104

⚪ 2025-03-06 10:35:28 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-06 10:39:16 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 43 0 1 0 102

🟢 2025-03-06 10:39:25 UTC Build successful.
🟢 2025-03-06 10:39:45 UTC ydbd size 2.1 GiB changed* by +616 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4b641a3 merge: 9453325 diff diff %
ydbd size 2 293 101 120 Bytes 2 293 101 736 Bytes +616 Bytes +0.000%
ydbd stripped size 480 445 056 Bytes 480 445 184 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 12:47:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for ac680fb has started.
⚪ 2025-03-06 12:47:16 UTC Artifacts will be uploaded here
⚪ 2025-03-06 12:50:02 UTC ya make is running...
🟢 2025-03-06 13:39:35 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18900 17560 0 0 1218 122

🟢 2025-03-06 13:41:15 UTC Build successful.
🟢 2025-03-06 13:41:33 UTC ydbd size 2.1 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3abd02a merge: ac680fb diff diff %
ydbd size 2 293 952 896 Bytes 2 293 954 544 Bytes +1.6 KiB +0.000%
ydbd stripped size 480 565 504 Bytes 480 565 696 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 12:49:18 UTC Pre-commit check linux-x86_64-release-asan for ac680fb has started.
⚪ 2025-03-06 12:49:34 UTC Artifacts will be uploaded here
⚪ 2025-03-06 12:52:23 UTC ya make is running...
🟡 2025-03-06 13:56:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11647 11509 0 81 21 36

⚪ 2025-03-06 13:58:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-06 14:13:16 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 156 0 0 5 33

🟢 2025-03-06 14:13:30 UTC Build successful.
🟢 2025-03-06 14:13:57 UTC ydbd size 3.7 GiB changed* by +816 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 508e93d merge: ac680fb diff diff %
ydbd size 3 995 166 096 Bytes 3 995 166 912 Bytes +816 Bytes +0.000%
ydbd stripped size 1 389 082 952 Bytes 1 389 083 080 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit 0a958f2 into ydb-platform:main Mar 6, 2025
14 checks passed
@Hor911 Hor911 mentioned this pull request Mar 6, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@Hor911 @blinkov
Correct ScanActor termination (#15395)
d193824
Hor911 added a commit to Hor911/ydb that referenced this pull request Apr 27, 2025
@Hor911
Correct ScanActor termination (ydb-platform#15395)
8f9df9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashandor789 pashandor789 pashandor789 approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hor911 @pashandor789