Skip to content

CreateDatabase: support specifying the number of coordinators/mediators #15415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

CreateDatabase: support specifying the number of coordinators/mediators #15415

merged 1 commit into from
Mar 7, 2025

Conversation

snaury
Copy link
Member

@snaury snaury commented Mar 6, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Support specifying the number of coordinators/mediators in the CreateDatabase request as a way to very large databases.

@snaury snaury self-assigned this Mar 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

🟢 2025-03-06 13:27:38 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 13:28:39 UTC Pre-commit check linux-x86_64-release-asan for 8d5ebdc has started.
⚪ 2025-03-06 13:28:54 UTC Artifacts will be uploaded here
⚪ 2025-03-06 13:32:12 UTC ya make is running...
⚫ 2025-03-06 15:09:11 UTC Check cancelled

@snaury snaury marked this pull request as ready for review March 6, 2025 13:29
@snaury snaury requested a review from a team as a code owner March 6, 2025 13:29
CyberROFL
CyberROFL previously approved these changes Mar 6, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 13:35:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8d5ebdc has started.
⚪ 2025-03-06 13:36:00 UTC Artifacts will be uploaded here
⚪ 2025-03-06 13:39:12 UTC ya make is running...
🟢 2025-03-06 15:09:39 UTC ydbd size 2.1 GiB changed* by +16.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 9187047 merge: 8d5ebdc diff diff %
ydbd size 2 293 953 776 Bytes 2 293 970 776 Bytes +16.6 KiB +0.001%
ydbd stripped size 480 565 568 Bytes 480 569 632 Bytes +4.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-06 15:09:41 UTC Check cancelled

@snaury snaury force-pushed the console-customize-coordinators-mediators branch from 58a41e7 to df49069 Compare March 6, 2025 15:08
CyberROFL
CyberROFL previously approved these changes Mar 6, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 15:11:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 45fe513 has started.
⚪ 2025-03-06 15:11:31 UTC Artifacts will be uploaded here
⚪ 2025-03-06 15:14:40 UTC ya make is running...
🟡 2025-03-06 16:43:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28851 26254 0 3 2467 127

⚪ 2025-03-06 16:47:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 17:00:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
179 (only retried tests) 70 0 3 0 106

⚪ 2025-03-06 17:00:30 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-06 17:04:03 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
152 (only retried tests) 46 0 3 0 103

🟢 2025-03-06 17:04:10 UTC Build successful.
🟢 2025-03-06 17:04:31 UTC ydbd size 2.1 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0d66c0 merge: 45fe513 diff diff %
ydbd size 2 293 961 784 Bytes 2 293 969 920 Bytes +7.9 KiB +0.000%
ydbd stripped size 480 565 376 Bytes 480 569 760 Bytes +4.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025 •
edited
Loading

⚪ 2025-03-06 15:11:59 UTC Pre-commit check linux-x86_64-release-asan for 45fe513 has started.
⚪ 2025-03-06 15:12:28 UTC Artifacts will be uploaded here
⚪ 2025-03-06 15:16:13 UTC ya make is running...
🟡 2025-03-06 17:01:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14436 14284 0 84 29 39

⚪ 2025-03-06 17:03:08 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-06 17:18:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
215 (only retried tests) 165 0 10 8 32

⚪ 2025-03-06 17:18:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-06 17:30:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
81 (only retried tests) 42 0 4 6 29

🟢 2025-03-06 17:30:58 UTC Build successful.
🟢 2025-03-06 17:31:27 UTC ydbd size 3.7 GiB changed* by +9.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d0d66c0 merge: 45fe513 diff diff %
ydbd size 3 995 104 672 Bytes 3 995 114 424 Bytes +9.5 KiB +0.000%
ydbd stripped size 1 389 062 664 Bytes 1 389 067 304 Bytes +4.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury force-pushed the console-customize-coordinators-mediators branch from df49069 to b1103d6 Compare March 7, 2025 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 08:23:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0fe5292 has started.
⚪ 2025-03-07 08:23:18 UTC Artifacts will be uploaded here
⚪ 2025-03-07 08:26:37 UTC ya make is running...
🟡 2025-03-07 09:59:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28855 26247 0 5 2481 122

⚪ 2025-03-07 10:01:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-07 10:13:39 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
191 (only retried tests) 82 0 0 0 109

🟢 2025-03-07 10:13:49 UTC Build successful.
🟢 2025-03-07 10:14:09 UTC ydbd size 2.1 GiB changed* by +3.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b654981 merge: 0fe5292 diff diff %
ydbd size 2 293 420 848 Bytes 2 293 424 096 Bytes +3.2 KiB +0.000%
ydbd stripped size 480 451 296 Bytes 480 451 424 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025 •
edited
Loading

⚪ 2025-03-07 08:23:23 UTC Pre-commit check linux-x86_64-release-asan for 0fe5292 has started.
⚪ 2025-03-07 08:23:38 UTC Artifacts will be uploaded here
⚪ 2025-03-07 08:26:55 UTC ya make is running...
🟡 2025-03-07 10:15:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14441 14243 0 142 23 33

⚪ 2025-03-07 10:16:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-07 10:32:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
265 (only retried tests) 219 0 13 1 32

⚪ 2025-03-07 10:32:15 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-07 10:44:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
78 (only retried tests) 48 0 0 1 29

🟢 2025-03-07 10:44:12 UTC Build successful.
🟢 2025-03-07 10:44:45 UTC ydbd size 3.7 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b654981 merge: 0fe5292 diff diff %
ydbd size 3 994 259 048 Bytes 3 994 267 872 Bytes +8.6 KiB +0.000%
ydbd stripped size 1 388 747 112 Bytes 1 388 751 560 Bytes +4.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury merged commit 66573f0 into ydb-platform:main Mar 7, 2025
12 checks passed
@snaury snaury deleted the console-customize-coordinators-mediators branch March 7, 2025 12:33
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 11, 2025
Merged
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@snaury @adameat
CreateDatabase: support specifying the number of coordinators/mediato…
bc39591 
…rs (ydb-platform#15415)
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@snaury @blinkov
CreateDatabase: support specifying the number of coordinators/mediato…
b8aa7f5 
…rs (#15415)
snaury added a commit to snaury/ydb that referenced this pull request Mar 28, 2025
@snaury
CreateDatabase: support specifying the number of coordinators/mediato…
80685d4 
…rs (ydb-platform#15415)
@snaury snaury mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL approved these changes

Assignees

@snaury snaury

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaury @CyberROFL