-
Notifications
You must be signed in to change notification settings - Fork 692
tests/library: separate fixtures from harness #15437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/library: separate fixtures from harness #15437
Conversation
🟢 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
||
|
||
@pytest.fixture(scope='module') | ||
def ydb_cluster_configuration(request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Видимо, надо в каком то другом месте удалить?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это про что?
to allow fixture module to be py3 only
3c56229
to
f5deb70
Compare
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
`ydb/tests/library/harness/ydb_fixtures` -> `ydb/tests/library/fixtures`. Move module with pytest fixtures out of `ydb/tests/library/harness` and make it a separate (but dependent) library. Part of the `harness` (namely `ydbd` launching framework: `Daemon`, runner etc), is widely used outside of ydb tests, and some of that uses still require py2 compatibility (so that `harness` must run under py2). ydb's own tests (`ydb/tests/functional`) are all pure py3, so requirement for the test fixtures to be py2 compatible is excessive.
`ydb/tests/library/harness/ydb_fixtures` -> `ydb/tests/library/fixtures`. Move module with pytest fixtures out of `ydb/tests/library/harness` and make it a separate (but dependent) library. Part of the `harness` (namely `ydbd` launching framework: `Daemon`, runner etc), is widely used outside of ydb tests, and some of that uses still require py2 compatibility (so that `harness` must run under py2). ydb's own tests (`ydb/tests/functional`) are all pure py3, so requirement for the test fixtures to be py2 compatible is excessive.
`ydb/tests/library/harness/ydb_fixtures` -> `ydb/tests/library/fixtures`. Move module with pytest fixtures out of `ydb/tests/library/harness` and make it a separate (but dependent) library. Part of the `harness` (namely `ydbd` launching framework: `Daemon`, runner etc), is widely used outside of ydb tests, and some of that uses still require py2 compatibility (so that `harness` must run under py2). ydb's own tests (`ydb/tests/functional`) are all pure py3, so requirement for the test fixtures to be py2 compatible is excessive.
`ydb/tests/library/harness/ydb_fixtures` -> `ydb/tests/library/fixtures`. Move module with pytest fixtures out of `ydb/tests/library/harness` and make it a separate (but dependent) library. Part of the `harness` (namely `ydbd` launching framework: `Daemon`, runner etc), is widely used outside of ydb tests, and some of that uses still require py2 compatibility (so that `harness` must run under py2). ydb's own tests (`ydb/tests/functional`) are all pure py3, so requirement for the test fixtures to be py2 compatible is excessive.
ydb/tests/library/harness/ydb_fixtures
->ydb/tests/library/fixtures
.Move module with pytest fixtures out of
ydb/tests/library/harness
and make it a separate (but dependent) library.Part of the
harness
(namelyydbd
launching framework:Daemon
, runner etc), is widely used outside of ydb tests, and some of that uses still require py2 compatibility (so thatharness
must run under py2).ydb's own tests (
ydb/tests/functional
) are all pure py3, so requirement for the test fixtures to be py2 compatible is excessive.