Skip to content

direct read fix #15479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

direct read fix #15479

merged 1 commit into from
Mar 11, 2025

Conversation

FloatingCrowbar
Copy link
Collaborator

  • Fixes in direct read

Changelog entry

...

Changelog category

  • Bugfix

Description for reviewers

...

@FloatingCrowbar FloatingCrowbar requested a review from a team as a code owner March 7, 2025 19:04
@github-actions github-actions bot added the bugfix label Mar 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

🔴 2025-03-07 19:05:40 UTC The validation of the Pull Request description has failed. Please update the description.

The changelog entry is less than 20 characters or missing.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:11:27 UTC Pre-commit check linux-x86_64-release-asan for f3fb93b has started.
⚪ 2025-03-10 22:11:42 UTC Artifacts will be uploaded here
⚫ 2025-03-10 22:13:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:12:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for f3fb93b has started.
⚪ 2025-03-10 22:12:15 UTC Artifacts will be uploaded here
⚫ 2025-03-10 22:13:33 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:14:13 UTC Pre-commit check linux-x86_64-release-asan for f173455 has started.
⚪ 2025-03-10 22:14:35 UTC Artifacts will be uploaded here
⚪ 2025-03-10 22:17:23 UTC ya make is running...
🔴 2025-03-10 22:20:21 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:15:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for f173455 has started.
⚪ 2025-03-10 22:15:21 UTC Artifacts will be uploaded here
⚪ 2025-03-10 22:18:03 UTC ya make is running...
🔴 2025-03-10 22:20:37 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:43:23 UTC Pre-commit check linux-x86_64-release-asan for f40d310 has started.
⚪ 2025-03-10 22:43:37 UTC Artifacts will be uploaded here
⚪ 2025-03-10 22:46:23 UTC ya make is running...
🟡 2025-03-10 23:55:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13529 13255 0 217 23 34

⚪ 2025-03-10 23:56:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-11 00:10:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
379 (only retried tests) 278 0 67 1 33

⚪ 2025-03-11 00:10:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-11 00:23:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 107 0 42 1 31

🟢 2025-03-11 00:23:20 UTC Build successful.
🟢 2025-03-11 00:23:48 UTC ydbd size 3.7 GiB changed* by +43.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a27aca4 merge: f40d310 diff diff %
ydbd size 3 995 244 368 Bytes 3 995 289 048 Bytes +43.6 KiB +0.001%
ydbd stripped size 1 388 725 448 Bytes 1 388 739 656 Bytes +13.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 22:44:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for f40d310 has started.
⚪ 2025-03-10 22:44:25 UTC Artifacts will be uploaded here
⚪ 2025-03-10 22:47:19 UTC ya make is running...
🟡 2025-03-10 23:45:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27902 25320 0 3 2467 112

⚪ 2025-03-10 23:48:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-11 00:00:37 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 59 0 0 0 103

🟢 2025-03-11 00:00:45 UTC Build successful.
🟢 2025-03-11 00:01:03 UTC ydbd size 2.1 GiB changed* by +20.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a27aca4 merge: f40d310 diff diff %
ydbd size 2 294 046 184 Bytes 2 294 067 056 Bytes +20.4 KiB +0.001%
ydbd stripped size 480 442 432 Bytes 480 446 400 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

qyryq
qyryq previously approved these changes Mar 11, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 11:44:48 UTC Pre-commit check linux-x86_64-release-asan for 0d80c73 has started.
⚪ 2025-03-11 11:45:03 UTC Artifacts will be uploaded here
⚪ 2025-03-11 11:47:55 UTC ya make is running...
🟡 2025-03-11 12:54:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13558 13320 0 187 18 33

⚪ 2025-03-11 12:55:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-11 13:13:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
341 (only retried tests) 227 0 81 1 32

⚪ 2025-03-11 13:13:25 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-11 13:32:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
190 (only retried tests) 108 0 51 0 31

🟢 2025-03-11 13:32:41 UTC Build successful.
🟢 2025-03-11 13:33:10 UTC ydbd size 3.7 GiB changed* by +40.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7959b23 merge: 0d80c73 diff diff %
ydbd size 3 998 881 888 Bytes 3 998 923 488 Bytes +40.6 KiB +0.001%
ydbd stripped size 1 389 594 216 Bytes 1 389 604 584 Bytes +10.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2025 •
edited
Loading

⚪ 2025-03-11 11:44:50 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0d80c73 has started.
⚪ 2025-03-11 11:45:05 UTC Artifacts will be uploaded here
⚪ 2025-03-11 11:47:50 UTC ya make is running...
🟡 2025-03-11 12:46:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27934 25346 0 4 2467 117

⚪ 2025-03-11 12:49:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-11 13:02:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 62 0 0 0 103

🟢 2025-03-11 13:02:59 UTC Build successful.
🟢 2025-03-11 13:03:20 UTC ydbd size 2.1 GiB changed* by +20.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7959b23 merge: 0d80c73 diff diff %
ydbd size 2 296 127 960 Bytes 2 296 149 128 Bytes +20.7 KiB +0.001%
ydbd stripped size 480 730 336 Bytes 480 734 368 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@FloatingCrowbar FloatingCrowbar enabled auto-merge (squash) March 11, 2025 12:47
@FloatingCrowbar FloatingCrowbar merged commit 5ed8c5f into ydb-platform:main Mar 11, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@FloatingCrowbar @adameat
direct read fix (ydb-platform#15479)
b7d556b
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@FloatingCrowbar @blinkov
direct read fix (#15479)
bb3aa38
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@FloatingCrowbar
direct read fix (ydb-platform#15479)
dfd1183
qyryq pushed a commit to qyryq/ydb that referenced this pull request May 6, 2025
@FloatingCrowbar @qyryq
direct read fix (ydb-platform#15479)
8a91dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qyryq qyryq qyryq approved these changes

@alexnick88 alexnick88 Awaiting requested review from alexnick88 alexnick88 is a code owner automatically assigned from ydb-platform/topics

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FloatingCrowbar @qyryq