Skip to content

Enable XDC by default, fix ut to use XDC transfers #15540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2025
Merged

Enable XDC by default, fix ut to use XDC transfers #15540

merged 3 commits into from
Mar 10, 2025

Conversation

dcherednik
Copy link
Member

@dcherednik dcherednik commented Mar 10, 2025 •
edited
Loading

Changelog entry

XDC allows to send huge events without splitting into small IC chunks.

Changelog category

  • Performance improvement

Description for reviewers

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

🟢 2025-03-10 15:23:08 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 15:20:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7f34b1c has started.
⚪ 2025-03-10 15:20:29 UTC Artifacts will be uploaded here
⚪ 2025-03-10 15:23:27 UTC ya make is running...
⚫ 2025-03-10 15:52:10 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 15:21:01 UTC Pre-commit check linux-x86_64-release-asan for 7f34b1c has started.
⚪ 2025-03-10 15:21:17 UTC Artifacts will be uploaded here
⚪ 2025-03-10 15:24:21 UTC ya make is running...
⚫ 2025-03-10 15:52:10 UTC Check cancelled

@dcherednik dcherednik requested a review from a team as a code owner March 10, 2025 15:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 15:54:47 UTC Pre-commit check linux-x86_64-release-asan for 3f24cc0 has started.
⚪ 2025-03-10 15:55:03 UTC Artifacts will be uploaded here
⚪ 2025-03-10 15:58:15 UTC ya make is running...
🟡 2025-03-10 17:37:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14002 13800 0 155 12 35

⚪ 2025-03-10 17:38:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 17:53:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
303 (only retried tests) 190 0 74 8 31

⚪ 2025-03-10 17:53:55 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-10 18:05:59 UTC ydbd size 3.7 GiB changed* by +384 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7a338da merge: 3f24cc0 diff diff %
ydbd size 3 994 913 880 Bytes 3 994 914 264 Bytes +384 Bytes +0.000%
ydbd stripped size 1 388 603 848 Bytes 1 388 604 168 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-03-10 18:06:01 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 15:55:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3f24cc0 has started.
⚪ 2025-03-10 15:55:30 UTC Artifacts will be uploaded here
⚪ 2025-03-10 15:59:09 UTC ya make is running...
🟡 2025-03-10 17:26:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28506 25920 0 2 2467 117

⚪ 2025-03-10 17:29:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 17:43:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 62 0 0 0 106

🟢 2025-03-10 17:43:38 UTC Build successful.
🟢 2025-03-10 17:43:56 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7a338da merge: 3f24cc0 diff diff %
ydbd size 2 293 868 784 Bytes 2 293 868 784 Bytes 0 Bytes 0.000%
ydbd stripped size 480 434 112 Bytes 480 434 112 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

alexvru
alexvru previously approved these changes Mar 10, 2025
View reviewed changes
nepal
nepal reviewed Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@nepal nepal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vitstn
vitstn reviewed Mar 10, 2025
View reviewed changes
ydb/library/yql/providers/dq/config/config.proto Outdated
@@ -25,7 +25,7 @@ message TDqConfig {
optional uint64 MessagePendingTimeoutMs = 15 [default = 5000];
optional uint64 MessagePendingSize = 16 [default = 18446744073709551615];
optional uint32 MaxSerializedEventSize = 17 [default = 67108000];
optional bool EnableExternalDataChannel = 27 [default = false];
optional bool EnableExternalDataChannel = 27 [default = true];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше тут не переключать default

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 18:07:29 UTC Pre-commit check linux-x86_64-release-asan for 37b6d13 has started.
⚪ 2025-03-10 18:12:15 UTC Artifacts will be uploaded here
⚪ 2025-03-10 18:15:21 UTC ya make is running...
🟡 2025-03-10 19:51:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13992 13827 0 114 13 38

⚪ 2025-03-10 19:52:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 20:05:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
252 (only retried tests) 153 0 63 1 35

⚪ 2025-03-10 20:05:54 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-10 20:18:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 107 0 41 1 32

🟢 2025-03-10 20:18:30 UTC Build successful.
🟢 2025-03-10 20:18:59 UTC ydbd size 3.7 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 04e2915 merge: 37b6d13 diff diff %
ydbd size 3 995 244 496 Bytes 3 995 244 416 Bytes -80 Bytes -0.000%
ydbd stripped size 1 388 725 448 Bytes 1 388 725 384 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 10, 2025 •
edited
Loading

⚪ 2025-03-10 18:09:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37b6d13 has started.
⚪ 2025-03-10 18:09:15 UTC Artifacts will be uploaded here
⚪ 2025-03-10 18:12:18 UTC ya make is running...
🟡 2025-03-10 19:36:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28496 25907 0 2 2471 116

⚪ 2025-03-10 19:39:10 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 19:50:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 64 0 0 0 105

🟢 2025-03-10 19:50:31 UTC Build successful.
🟢 2025-03-10 19:50:49 UTC ydbd size 2.1 GiB changed* by -16 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 04e2915 merge: 37b6d13 diff diff %
ydbd size 2 294 046 280 Bytes 2 294 046 264 Bytes -16 Bytes -0.000%
ydbd stripped size 480 442 432 Bytes 480 442 432 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) March 10, 2025 18:12
@dcherednik dcherednik merged commit a27aca4 into ydb-platform:main Mar 10, 2025
12 checks passed
@serbel324 serbel324 mentioned this pull request Mar 13, 2025
Merged
@alexnick88 alexnick88 mentioned this pull request Mar 19, 2025
Closed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
@dcherednik @adameat
Enable XDC by default, fix ut to use XDC transfers (ydb-platform#15540)
a67663c 
XDC allows to send huge events without splitting into small IC chunks.
blinkov pushed a commit that referenced this pull request Mar 21, 2025
@dcherednik @blinkov
Enable XDC by default, fix ut to use XDC transfers (#15540)
1febe01 
XDC allows to send huge events without splitting into small IC chunks.
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@dcherednik
Enable XDC by default, fix ut to use XDC transfers (ydb-platform#15540)
d293250 
XDC allows to send huge events without splitting into small IC chunks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nepal nepal nepal left review comments

@vitstn vitstn vitstn approved these changes

@alexvru alexvru alexvru left review comments

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcherednik @nepal @vitstn @alexvru