Skip to content

fix tabletid in TBuildSlicesTask #15542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zverevgeny
Copy link
Collaborator

@zverevgeny zverevgeny commented Mar 10, 2025

Changelog category

  • Bugfix

Additional info

TabletId in TWriteActor was initialized by a table pathId. Had now impact as TabletId in TWriteActor is used only for logging

@zverevgeny zverevgeny requested a review from a team as a code owner March 10, 2025 16:37
Copy link

github-actions bot commented Mar 10, 2025

🔴 2025-03-10 16:57:11 UTC The validation of the Pull Request description has failed. Please update the description.

The changelog entry is less than 20 characters or missing.

Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 16:39:41 UTC Pre-commit check linux-x86_64-release-asan for 8685aab has started.
2025-03-10 16:39:56 UTC Artifacts will be uploaded here
2025-03-10 16:42:46 UTC ya make is running...
🟡 2025-03-10 17:46:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11662 11451 0 165 9 37

2025-03-10 17:47:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-10 18:01:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
315 (only retried tests) 208 0 70 2 35

2025-03-10 18:01:26 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-10 18:14:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 102 0 51 1 32

🟢 2025-03-10 18:14:31 UTC Build successful.
🟢 2025-03-10 18:15:05 UTC ydbd size 3.7 GiB changed* by -240 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: a2426cc merge: 8685aab diff diff %
ydbd size 3 994 996 656 Bytes 3 994 996 416 Bytes -240 Bytes -0.000%
ydbd stripped size 1 388 606 728 Bytes 1 388 606 664 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 10, 2025

2025-03-10 16:39:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8685aab has started.
2025-03-10 16:39:52 UTC Artifacts will be uploaded here
2025-03-10 16:42:36 UTC ya make is running...
🟡 2025-03-10 17:27:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18920 17582 0 1 1218 119

2025-03-10 17:29:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-10 17:41:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
168 (only retried tests) 62 0 0 0 106

🟢 2025-03-10 17:41:29 UTC Build successful.
🟢 2025-03-10 17:41:51 UTC ydbd size 2.1 GiB changed* by +61.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7a338da merge: 8685aab diff diff %
ydbd size 2 293 868 784 Bytes 2 293 931 240 Bytes +61.0 KiB +0.003%
ydbd stripped size 480 434 112 Bytes 480 434 176 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny enabled auto-merge (squash) March 10, 2025 16:43
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 10, 2025
@zverevgeny zverevgeny merged commit 6baf82d into ydb-platform:main Mar 10, 2025
15 of 18 checks passed
adameat pushed a commit to adameat/ydb that referenced this pull request Mar 20, 2025
blinkov pushed a commit that referenced this pull request Mar 21, 2025
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants