Skip to content

Remove Private Cache wait pads #15644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

kunga
Copy link
Member

@kunga kunga commented Mar 12, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

In order to remove all excess functionality from Private Cache, track loading pages and their transactions in Shared Cache.

Although it may lead to increase of requested data (in terms of local NSharedCache::TEvRequest and NSharedCache::TEvResult messages content), I expect that it won't effect much as different transactions usually needs different data pages. Also, we are already tracking all requests and pages in NKikimr::NSharedCache::TRequest.

Copy link

github-actions bot commented Mar 12, 2025

🟢 2025-03-12 14:29:12 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 14:30:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1b7a005 has started.
2025-03-12 14:30:15 UTC Artifacts will be uploaded here
2025-03-12 14:33:12 UTC ya make is running...
🟡 2025-03-12 15:57:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28131 25450 0 72 2495 114

2025-03-12 15:59:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 16:12:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
318 (only retried tests) 143 0 63 4 108

2025-03-12 16:13:03 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-12 16:27:08 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
263 (only retried tests) 94 0 59 4 106

🟢 2025-03-12 16:27:18 UTC Build successful.
🟢 2025-03-12 16:27:45 UTC ydbd size 2.1 GiB changed* by -260.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: eda007c merge: 1b7a005 diff diff %
ydbd size 2 297 951 776 Bytes 2 297 685 280 Bytes -260.2 KiB -0.012%
ydbd stripped size 480 968 512 Bytes 480 969 088 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 12, 2025

2025-03-12 14:30:20 UTC Pre-commit check linux-x86_64-release-asan for 1b7a005 has started.
2025-03-12 14:30:35 UTC Artifacts will be uploaded here
2025-03-12 14:33:47 UTC ya make is running...
🟡 2025-03-12 16:08:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13743 13599 0 91 15 38

2025-03-12 16:09:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-12 16:22:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
237 (only retried tests) 137 0 61 5 34

2025-03-12 16:22:51 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-12 16:35:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 82 0 56 4 34

🟢 2025-03-12 16:35:16 UTC Build successful.
🟢 2025-03-12 16:35:55 UTC ydbd size 3.8 GiB changed* by -334.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 70284e9 merge: 1b7a005 diff diff %
ydbd size 4 044 617 480 Bytes 4 044 274 984 Bytes -334.5 KiB -0.008%
ydbd stripped size 1 399 434 664 Bytes 1 399 448 424 Bytes +13.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Mar 14, 2025
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 13:34:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 810c9f4 has started.
2025-03-17 13:34:38 UTC Artifacts will be uploaded here
2025-03-17 13:37:40 UTC ya make is running...
🟡 2025-03-17 14:59:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28232 25618 0 17 2482 115

2025-03-17 15:01:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 15:29:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 66 0 15 3 108

2025-03-17 15:29:48 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-17 15:41:41 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
177 (only retried tests) 53 0 15 1 108

🟢 2025-03-17 15:41:48 UTC Build successful.
🟢 2025-03-17 15:42:08 UTC ydbd size 2.1 GiB changed* by -4.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f4ac441 merge: 810c9f4 diff diff %
ydbd size 2 298 241 784 Bytes 2 298 237 456 Bytes -4.2 KiB -0.000%
ydbd stripped size 481 100 960 Bytes 481 098 400 Bytes -2.5 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 13:34:38 UTC Pre-commit check linux-x86_64-release-asan for 810c9f4 has started.
2025-03-17 13:34:52 UTC Artifacts will be uploaded here
2025-03-17 13:37:52 UTC ya make is running...
🟡 2025-03-17 15:11:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13817 13714 0 48 15 40

2025-03-17 15:13:04 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-17 15:29:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
156 (only retried tests) 97 0 15 8 36

2025-03-17 15:29:12 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-17 15:40:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 43 0 15 5 35

🟢 2025-03-17 15:41:11 UTC Build successful.
🟢 2025-03-17 15:41:40 UTC ydbd size 3.8 GiB changed* by +41.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f4ac441 merge: 810c9f4 diff diff %
ydbd size 4 046 705 384 Bytes 4 046 747 336 Bytes +41.0 KiB +0.001%
ydbd stripped size 1 400 101 608 Bytes 1 400 108 168 Bytes +6.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 13:42:03 UTC Pre-commit check linux-x86_64-release-asan for 65b0da6 has started.
2025-03-18 13:42:18 UTC Artifacts will be uploaded here
2025-03-18 13:45:23 UTC ya make is running...
🟡 2025-03-18 15:18:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13835 13734 0 44 18 39

2025-03-18 15:19:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-18 15:37:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
163 (only retried tests) 109 0 11 9 34

2025-03-18 15:38:08 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-18 15:50:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
93 (only retried tests) 47 0 11 4 31

🟢 2025-03-18 15:51:02 UTC Build successful.
🟢 2025-03-18 15:51:34 UTC ydbd size 3.8 GiB changed* by +43.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 041403d merge: 65b0da6 diff diff %
ydbd size 4 049 843 600 Bytes 4 049 888 112 Bytes +43.5 KiB +0.001%
ydbd stripped size 1 401 009 640 Bytes 1 401 015 560 Bytes +5.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 18, 2025

2025-03-18 13:45:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 65b0da6 has started.
2025-03-18 13:45:37 UTC Artifacts will be uploaded here
2025-03-18 13:48:39 UTC ya make is running...
🟡 2025-03-18 15:09:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28260 25642 0 11 2490 117

2025-03-18 15:12:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-18 15:33:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 67 0 11 1 109

2025-03-18 15:33:33 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-18 15:45:31 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 55 0 11 1 107

🟢 2025-03-18 15:45:40 UTC Build successful.
🟢 2025-03-18 15:46:05 UTC ydbd size 2.1 GiB changed* by -3.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 041403d merge: 65b0da6 diff diff %
ydbd size 2 300 087 704 Bytes 2 300 084 280 Bytes -3.3 KiB -0.000%
ydbd stripped size 481 400 768 Bytes 481 399 360 Bytes -1.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga mentioned this pull request May 7, 2025
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant