Skip to content

Revert "24-4: Force oldest locks into shard locks due to range limits (#15473)" #15851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

snaury
Copy link
Member

@snaury snaury commented Mar 17, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

This reverts commit 42f0576.

@snaury snaury self-assigned this Mar 17, 2025
Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 16:03:55 UTC Pre-commit check for 6499f06 has started.
2025-03-17 16:06:43 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-03-17 16:52:47 UTC Build successful.
2025-03-17 16:53:03 UTC Tests are running...
🔴 2025-03-17 18:21:28 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14805 13441 0 20 1301 43

🟢 2025-03-17 18:22:24 UTC ydbd size 8.3 GiB changed* by +15.1 KiB, which is < 100.0 KiB vs stable-24-4: OK

ydbd size dash stable-24-4: 85b3d16 merge: 6499f06 diff diff %
ydbd size 8 898 609 496 Bytes 8 898 624 920 Bytes +15.1 KiB +0.000%
ydbd stripped size 485 027 272 Bytes 485 028 456 Bytes +1.2 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 17, 2025

2025-03-17 16:04:45 UTC Pre-commit check for 6499f06 has started.
2025-03-17 16:07:31 UTC Build linux-x86_64-release-asan is running...
🟢 2025-03-17 16:35:12 UTC Build successful.
2025-03-17 16:35:28 UTC Tests are running...
🔴 2025-03-17 18:48:29 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10370 10273 0 34 23 40

🟢 2025-03-17 18:49:25 UTC ydbd size 5.6 GiB changed* by -8.1 KiB, which is <= 0 Bytes vs stable-24-4: OK

ydbd size dash stable-24-4: 26fc43b merge: 6499f06 diff diff %
ydbd size 6 027 679 024 Bytes 6 027 670 720 Bytes -8.1 KiB -0.000%
ydbd stripped size 1 508 473 792 Bytes 1 508 470 368 Bytes -3.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review March 17, 2025 16:44
@snaury snaury requested a review from a team as a code owner March 17, 2025 16:44
@snaury snaury merged commit 808c600 into ydb-platform:stable-24-4 Mar 18, 2025
6 of 10 checks passed
@snaury snaury deleted the revert-42f05765972cf136fb4b5705f352285002c3c8f0 branch March 18, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants