Skip to content

Remove upload on page fault "optimization" #16485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Mar 31, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Each Seek leads to PageFault handling which trigger upload that works badly for small prefixes

For similarity with other searches disable in them too (profit is doubtful)

Copy link

github-actions bot commented Mar 31, 2025

🟢 2025-03-31 12:05:07 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 31, 2025

2025-03-31 12:05:08 UTC Pre-commit check linux-x86_64-release-asan for a53e485 has started.
2025-03-31 12:05:16 UTC Artifacts will be uploaded here
2025-03-31 12:08:02 UTC ya make is running...
🟡 2025-03-31 13:26:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12230 12105 0 70 16 39

2025-03-31 13:27:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 13:40:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
181 (only retried tests) 106 0 34 8 33

2025-03-31 13:40:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-31 13:58:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
109 (only retried tests) 38 0 33 8 30

🟢 2025-03-31 13:58:37 UTC Build successful.
🟢 2025-03-31 13:59:10 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0bd909 merge: a53e485 diff diff %
ydbd size 4 122 070 680 Bytes 4 122 073 864 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 424 481 864 Bytes 1 424 482 504 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 31, 2025

2025-03-31 12:05:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for a53e485 has started.
2025-03-31 12:05:59 UTC Artifacts will be uploaded here
2025-03-31 12:08:41 UTC ya make is running...
🟡 2025-03-31 13:10:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19683 18328 0 6 1241 108

2025-03-31 13:12:15 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 13:32:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 58 0 1 0 101

2025-03-31 13:32:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-31 13:42:55 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
140 (only retried tests) 39 0 1 0 100

🟢 2025-03-31 13:43:02 UTC Build successful.
🟢 2025-03-31 13:43:24 UTC ydbd size 2.2 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c0bd909 merge: a53e485 diff diff %
ydbd size 2 349 178 520 Bytes 2 349 180 792 Bytes +2.2 KiB +0.000%
ydbd stripped size 491 112 256 Bytes 491 112 768 Bytes +512 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga requested a review from MBkkt March 31, 2025 13:40
@kunga kunga added the rebase-and-check Rebase PR with the current base branch and check label Mar 31, 2025
@kunga kunga self-assigned this Mar 31, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 31, 2025
Copy link

github-actions bot commented Mar 31, 2025

2025-03-31 15:46:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 55fa11b has started.
2025-03-31 15:46:58 UTC Artifacts will be uploaded here
2025-03-31 15:49:43 UTC ya make is running...
🟡 2025-03-31 16:50:17 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19689 18329 0 7 1243 110

2025-03-31 16:51:59 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 17:06:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 61 0 2 0 102

2025-03-31 17:06:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-31 17:23:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
144 (only retried tests) 41 0 1 0 102

🟢 2025-03-31 17:23:55 UTC Build successful.
🟢 2025-03-31 17:24:18 UTC ydbd size 2.2 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a701bdb merge: 55fa11b diff diff %
ydbd size 2 349 155 720 Bytes 2 349 157 928 Bytes +2.2 KiB +0.000%
ydbd stripped size 491 107 904 Bytes 491 108 352 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 31, 2025

2025-03-31 15:47:52 UTC Pre-commit check linux-x86_64-release-asan for 55fa11b has started.
2025-03-31 15:48:06 UTC Artifacts will be uploaded here
2025-03-31 15:50:58 UTC ya make is running...
🟡 2025-03-31 17:10:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12234 12077 0 106 13 38

2025-03-31 17:11:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-31 17:29:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
222 (only retried tests) 148 0 35 5 34

2025-03-31 17:29:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-31 17:41:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 39 0 33 3 31

🟢 2025-03-31 17:41:28 UTC Build successful.
🟢 2025-03-31 17:41:59 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a701bdb merge: 55fa11b diff diff %
ydbd size 4 122 027 944 Bytes 4 122 031 080 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 424 470 600 Bytes 1 424 471 176 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga added the rebase-and-check Rebase PR with the current base branch and check label Apr 1, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Apr 1, 2025
Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 08:29:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for fdb6ae4 has started.
2025-04-01 08:29:11 UTC Artifacts will be uploaded here
2025-04-01 08:32:02 UTC ya make is running...
🟡 2025-04-01 09:31:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19693 18312 0 15 1252 114

2025-04-01 09:33:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 09:52:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
186 (only retried tests) 84 0 1 0 101

2025-04-01 09:53:02 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-01 10:03:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
140 (only retried tests) 40 0 0 0 100

🟢 2025-04-01 10:03:31 UTC Build successful.
🟢 2025-04-01 10:03:53 UTC ydbd size 2.2 GiB changed* by +2.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5442b2e merge: fdb6ae4 diff diff %
ydbd size 2 349 551 664 Bytes 2 349 553 872 Bytes +2.2 KiB +0.000%
ydbd stripped size 491 488 384 Bytes 491 488 832 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 1, 2025

2025-04-01 08:30:51 UTC Pre-commit check linux-x86_64-release-asan for fdb6ae4 has started.
2025-04-01 08:30:57 UTC Artifacts will be uploaded here
2025-04-01 08:33:53 UTC ya make is running...
🟡 2025-04-01 09:57:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12242 11999 0 175 30 38

2025-04-01 09:58:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 10:12:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
306 (only retried tests) 225 0 41 7 33

2025-04-01 10:12:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-01 10:24:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 42 0 33 6 32

🟢 2025-04-01 10:24:43 UTC Build successful.
🟢 2025-04-01 10:25:21 UTC ydbd size 3.8 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 5442b2e merge: fdb6ae4 diff diff %
ydbd size 4 122 323 072 Bytes 4 122 326 216 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 424 516 232 Bytes 1 424 516 808 Bytes +576 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga enabled auto-merge (squash) April 1, 2025 11:21
@kunga kunga merged commit 19e614d into ydb-platform:main Apr 1, 2025
29 of 31 checks passed
@kunga kunga mentioned this pull request Apr 6, 2025
48 tasks
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request May 29, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants