Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "25-1: TOptionsParseResult: throwing an exception in case of options parsing errors" #16754

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

andrewstalin
Copy link
Collaborator

Changelog entry

Reverts #16710

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

@andrewstalin andrewstalin requested a review from a team as a code owner April 4, 2025 02:31
Copy link

github-actions bot commented Apr 4, 2025

🟢 2025-04-04 02:32:32 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 02:34:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 811f24f has started.
2025-04-04 02:35:10 UTC Artifacts will be uploaded here
2025-04-04 02:38:00 UTC ya make is running...
🟡 2025-04-04 03:44:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26380 23785 0 4 2460 131

2025-04-04 03:46:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 04:07:02 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 69 0 0 3 126

🟢 2025-04-04 04:07:11 UTC Build successful.
🟢 2025-04-04 04:07:29 UTC ydbd size 2.1 GiB changed* by -1.5 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: dfed0b4 merge: 811f24f diff diff %
ydbd size 2 244 264 368 Bytes 2 244 262 856 Bytes -1.5 KiB -0.000%
ydbd stripped size 475 194 008 Bytes 475 193 752 Bytes -256 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 02:34:56 UTC Pre-commit check linux-x86_64-release-asan for 811f24f has started.
2025-04-04 02:35:12 UTC Artifacts will be uploaded here
2025-04-04 02:38:15 UTC ya make is running...
🟡 2025-04-04 03:52:17 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12241 12148 0 41 17 35

2025-04-04 03:53:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-04 04:13:29 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
141 (only retried tests) 109 0 0 0 32

🟢 2025-04-04 04:13:35 UTC Build successful.
🟢 2025-04-04 04:14:00 UTC ydbd size 3.6 GiB changed* by -2.4 KiB, which is <= 0 Bytes vs stable-25-1: OK

ydbd size dash stable-25-1: dfed0b4 merge: 811f24f diff diff %
ydbd size 3 903 975 272 Bytes 3 903 972 768 Bytes -2.4 KiB -0.000%
ydbd stripped size 1 366 011 408 Bytes 1 366 010 512 Bytes -896 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@andrewstalin andrewstalin merged commit 0099b9c into stable-25-1 Apr 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants