Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor describe handler #16766

Merged
merged 1 commit into from
Apr 7, 2025
Merged

refactor describe handler #16766

merged 1 commit into from
Apr 7, 2025

Conversation

adameat
Copy link
Member

@adameat adameat commented Apr 4, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@adameat adameat self-assigned this Apr 4, 2025
@adameat adameat requested a review from a team as a code owner April 4, 2025 09:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025

🟢 2025-04-04 09:21:15 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 09:21:19 UTC Pre-commit check linux-x86_64-release-asan for ad27921 has started.
⚪ 2025-04-04 09:21:34 UTC Artifacts will be uploaded here
⚪ 2025-04-04 09:24:23 UTC ya make is running...
🟡 2025-04-04 10:40:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11954 11827 0 58 32 37

⚪ 2025-04-04 10:41:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-04 10:54:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 81 0 36 16 34

⚪ 2025-04-04 10:54:37 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-04 11:13:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
116 (only retried tests) 49 0 34 3 30

🟢 2025-04-04 11:13:40 UTC Build successful.
🟢 2025-04-04 11:14:09 UTC ydbd size 3.8 GiB changed* by -3.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d257768 merge: ad27921 diff diff %
ydbd size 4 125 232 672 Bytes 4 125 228 800 Bytes -3.8 KiB -0.000%
ydbd stripped size 1 425 303 208 Bytes 1 425 299 976 Bytes -3.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2025 •
edited
Loading

⚪ 2025-04-04 09:22:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for ad27921 has started.
⚪ 2025-04-04 09:22:53 UTC Artifacts will be uploaded here
⚪ 2025-04-04 09:25:35 UTC ya make is running...
🟡 2025-04-04 10:23:51 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19210 17835 0 5 1252 118

⚪ 2025-04-04 10:26:06 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-04 10:36:59 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 73 0 1 0 102

⚪ 2025-04-04 10:37:08 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-04 10:46:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 43 0 1 0 98

🟢 2025-04-04 10:46:42 UTC Build successful.
🟢 2025-04-04 10:47:05 UTC ydbd size 2.2 GiB changed* by -536 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: d257768 merge: ad27921 diff diff %
ydbd size 2 351 166 728 Bytes 2 351 166 192 Bytes -536 Bytes -0.000%
ydbd stripped size 491 721 600 Bytes 491 720 512 Bytes -1.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat enabled auto-merge (squash) April 4, 2025 10:39
alexvru
alexvru previously approved these changes Apr 4, 2025
View reviewed changes
@adameat adameat force-pushed the improve-describe branch from ed48895 to 7cf68fe Compare April 7, 2025 05:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 05:41:29 UTC Pre-commit check linux-x86_64-release-asan for 72d12de has started.
⚪ 2025-04-07 05:41:32 UTC Artifacts will be uploaded here
⚪ 2025-04-07 05:44:28 UTC ya make is running...
🟡 2025-04-07 06:58:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11925 11764 0 88 37 36

⚪ 2025-04-07 06:59:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-07 07:12:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
218 (only retried tests) 120 0 40 24 34

⚪ 2025-04-07 07:12:46 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-07 07:25:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
129 (only retried tests) 56 0 32 8 33

🟢 2025-04-07 07:25:09 UTC Build successful.
🟢 2025-04-07 07:25:41 UTC ydbd size 3.8 GiB changed* by -7.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 95387e2 merge: 72d12de diff diff %
ydbd size 4 131 699 168 Bytes 4 131 691 256 Bytes -7.7 KiB -0.000%
ydbd stripped size 1 427 182 056 Bytes 1 427 174 792 Bytes -7.1 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 05:41:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72d12de has started.
⚪ 2025-04-07 05:41:36 UTC Artifacts will be uploaded here
⚪ 2025-04-07 05:44:30 UTC ya make is running...
🟡 2025-04-07 06:41:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19184 17813 0 2 1260 109

⚪ 2025-04-07 06:42:47 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-07 06:51:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
169 (only retried tests) 70 0 0 0 99

🟢 2025-04-07 06:51:52 UTC Build successful.
🟢 2025-04-07 06:52:12 UTC ydbd size 2.2 GiB changed* by -544 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 95387e2 merge: 72d12de diff diff %
ydbd size 2 354 469 984 Bytes 2 354 469 440 Bytes -544 Bytes -0.000%
ydbd stripped size 492 040 672 Bytes 492 039 584 Bytes -1.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat requested a review from alexvru April 7, 2025 11:36
@adameat adameat force-pushed the improve-describe branch from 7cf68fe to 8a25ba3 Compare April 7, 2025 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 11:49:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for f91bbce has started.
⚪ 2025-04-07 11:49:26 UTC Artifacts will be uploaded here
⚪ 2025-04-07 11:52:11 UTC ya make is running...
🟡 2025-04-07 12:50:37 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19190 17826 0 7 1250 107

⚪ 2025-04-07 12:52:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-07 13:08:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 56 0 2 0 101

⚪ 2025-04-07 13:08:48 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-04-07 13:18:33 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
143 (only retried tests) 45 0 0 0 98

🟢 2025-04-07 13:18:40 UTC Build successful.
🟡 2025-04-07 13:19:01 UTC ydbd size 2.2 GiB changed* by +847.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 95387e2 merge: f91bbce diff diff %
ydbd size 2 354 469 984 Bytes 2 355 337 488 Bytes +847.2 KiB +0.037%
ydbd stripped size 492 040 672 Bytes 492 495 328 Bytes +444.0 KiB +0.092%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

⚪ 2025-04-07 11:55:49 UTC Pre-commit check linux-x86_64-release-asan for f91bbce has started.
⚪ 2025-04-07 11:56:04 UTC Artifacts will be uploaded here
⚪ 2025-04-07 11:58:57 UTC ya make is running...
🟡 2025-04-07 13:16:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11926 11786 0 71 36 33

⚪ 2025-04-07 13:17:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-07 13:31:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 112 0 35 10 31

⚪ 2025-04-07 13:31:17 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-07 13:45:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 38 0 32 3 31

🟢 2025-04-07 13:46:01 UTC Build successful.
🟡 2025-04-07 13:46:32 UTC ydbd size 3.8 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 95387e2 merge: f91bbce diff diff %
ydbd size 4 131 699 168 Bytes 4 132 792 104 Bytes +1.0 MiB +0.026%
ydbd stripped size 1 427 182 056 Bytes 1 427 778 792 Bytes +582.8 KiB +0.042%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat merged commit dc2c77f into ydb-platform:main Apr 7, 2025
13 checks passed
@adameat adameat deleted the improve-describe branch April 8, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StekPerepolnen StekPerepolnen StekPerepolnen approved these changes

@alexvru alexvru Awaiting requested review from alexvru

Assignees

@adameat adameat

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adameat @alexvru @StekPerepolnen