-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per PR docker image tests #16780
base: main
Are you sure you want to change the base?
Per PR docker image tests #16780
Conversation
🟢 |
b9f7010
to
60f178e
Compare
⚫ |
⚪ Test history | Ya make output | Test bloat
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢 |
60f178e
to
85685fc
Compare
85685fc
to
03628c6
Compare
⚪ Test history | Ya make output | Test bloat
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢 |
03628c6
to
6b00374
Compare
6b00374
to
14820f9
Compare
⚪ Test history | Ya make output | Test bloat
🟢 |
⚪ Test history | Ya make output | Test bloat
🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я бы ожидал, что в рамках задачи будет тест в рамках ya make, а не какая-то новая политика на ПР.
Подскажи, пожалуйста, как через ya make сделать сборку docker образа и протестировать его запуск и переход в состояние healthy. Важно, суть этого пр в тестировании образа, а не отдельных его компонент |
Changelog entry
This pull request includes changes to the GitHub Actions workflow for publishing Docker images. The primary focus is to enhance the workflow by adding conditions for pull request targets and renaming the workflow file for clarity.
Key changes:
Workflow enhancements:
.github/workflows/docker_build_test_publish.yml
: Addedpull_request_target
trigger for themain
branch to the workflow schedule..github/workflows/docker_build_test_publish.yml
: Added a condition to thePush docker image
step to ensure it only runs if the event is not apull_request_target
.File renaming:
.github/workflows/docker_publish.yml
to.github/workflows/docker_build_test_publish.yml
for better clarity and organization. [1] [2]...
Changelog category
Description for reviewers
...