Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per PR docker image tests #16780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Per PR docker image tests #16780

wants to merge 1 commit into from

Conversation

polRk
Copy link
Member

@polRk polRk commented Apr 4, 2025

Changelog entry

This pull request includes changes to the GitHub Actions workflow for publishing Docker images. The primary focus is to enhance the workflow by adding conditions for pull request targets and renaming the workflow file for clarity.

Key changes:

Workflow enhancements:

File renaming:

  • Renamed .github/workflows/docker_publish.yml to .github/workflows/docker_build_test_publish.yml for better clarity and organization. [1] [2]

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

github-actions bot commented Apr 4, 2025

🟢 2025-04-04 11:24:31 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:26:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for fa49e3e has started.
2025-04-04 11:26:30 UTC Artifacts will be uploaded here
2025-04-04 11:26:53 UTC Check cancelled

@polRk polRk force-pushed the per-pr-validate-docker-image branch from b9f7010 to 60f178e Compare April 4, 2025 11:26
Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:26:39 UTC Check cancelled

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:35:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for ad4296b has started.
2025-04-04 11:35:35 UTC Artifacts will be uploaded here
2025-04-04 11:37:52 UTC ya make is running...
🟢 2025-04-04 11:37:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:38:04 UTC Build successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:35:39 UTC Pre-commit check linux-x86_64-release-asan for ad4296b has started.
2025-04-04 11:35:54 UTC Artifacts will be uploaded here
2025-04-04 11:38:06 UTC ya make is running...
🟢 2025-04-04 11:38:11 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:38:17 UTC Build successful.

@polRk polRk force-pushed the per-pr-validate-docker-image branch from 60f178e to 85685fc Compare April 4, 2025 11:40
Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:41:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for f44a052 has started.
2025-04-04 11:42:02 UTC Artifacts will be uploaded here
2025-04-04 11:42:27 UTC Check cancelled

@polRk polRk force-pushed the per-pr-validate-docker-image branch from 85685fc to 03628c6 Compare April 4, 2025 11:42
Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:44:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for ec62791 has started.
2025-04-04 11:44:23 UTC Artifacts will be uploaded here
2025-04-04 11:46:33 UTC ya make is running...
🟢 2025-04-04 11:46:38 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:46:44 UTC Build successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:44:08 UTC Pre-commit check linux-x86_64-release-asan for ec62791 has started.
2025-04-04 11:44:23 UTC Artifacts will be uploaded here
2025-04-04 11:46:44 UTC ya make is running...
🟢 2025-04-04 11:46:50 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:46:55 UTC Build successful.

@polRk polRk force-pushed the per-pr-validate-docker-image branch from 03628c6 to 6b00374 Compare April 4, 2025 11:49
@polRk polRk force-pushed the per-pr-validate-docker-image branch from 6b00374 to 14820f9 Compare April 4, 2025 11:50
Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:53:09 UTC Pre-commit check linux-x86_64-release-asan for ff75667 has started.
2025-04-04 11:53:23 UTC Artifacts will be uploaded here
2025-04-04 11:55:34 UTC ya make is running...
🟢 2025-04-04 11:55:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:55:45 UTC Build successful.

Copy link

github-actions bot commented Apr 4, 2025

2025-04-04 11:53:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for ff75667 has started.
2025-04-04 11:53:24 UTC Artifacts will be uploaded here
2025-04-04 11:55:34 UTC ya make is running...
🟢 2025-04-04 11:55:39 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-04 11:55:45 UTC Build successful.

Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы ожидал, что в рамках задачи будет тест в рамках ya make, а не какая-то новая политика на ПР.

@polRk
Copy link
Member Author

polRk commented Apr 5, 2025

Я бы ожидал, что в рамках задачи будет тест в рамках ya make, а не какая-то новая политика на ПР.

Подскажи, пожалуйста, как через ya make сделать сборку docker образа и протестировать его запуск и переход в состояние healthy. Важно, суть этого пр в тестировании образа, а не отдельных его компонент

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants