Add proto plugin for config processing #1750

Enjection · 2024-02-08T19:06:07Z

Changelog entry

This PR adding protobuf plugin which simplifies protobuf usage for configs transformation

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-02-08T19:07:06Z

⚪ 2024-02-08 19:07:05 UTC Pre-commit check for c0fe140 has started.
⚪ 2024-02-08 19:07:07 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 19:54:54 UTC Build successful.
⚪ 2024-02-08 19:55:04 UTC Tests are running...
🟢 2024-02-08 21:42:49 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67413	56472	0	0	10892	49

github-actions · 2024-02-08T19:07:32Z

⚪ 2024-02-08 19:07:32 UTC Pre-commit check for c0fe140 has started.
⚪ 2024-02-08 19:07:33 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 19:54:12 UTC Build successful.
⚪ 2024-02-08 19:54:22 UTC Tests are running...
🔴 2024-02-08 21:38:17 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14740	14552	0	11	124	53

github-actions · 2024-02-08T22:00:38Z

⚪ 2024-02-08 22:00:37 UTC Pre-commit check for f6f68f1 has started.
⚪ 2024-02-08 22:00:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-08 22:48:28 UTC Build successful.
⚪ 2024-02-08 22:48:46 UTC Tests are running...
🟢 2024-02-09 00:33:51 UTC Tests successful.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67416	56469	0	0	10888	59

github-actions · 2024-02-08T22:00:56Z

⚪ 2024-02-08 22:00:56 UTC Pre-commit check for f6f68f1 has started.
⚪ 2024-02-08 22:00:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-08 22:52:21 UTC Build successful.
⚪ 2024-02-08 22:52:36 UTC Tests are running...
🔴 2024-02-09 00:41:35 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14738	14535	0	21	131	51

github-actions · 2024-02-09T12:01:02Z

⚪ 2024-02-09 12:01:02 UTC Pre-commit check for 14a11c9 has started.
⚪ 2024-02-09 12:01:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 12:43:35 UTC Build successful.
⚪ 2024-02-09 12:43:48 UTC Tests are running...
🔴 2024-02-09 13:26:22 UTC Test run completed, no test results found for commit 7943313. Please check build logs.
⚫ 2024-02-09 13:26:25 UTC Check cancelled

github-actions · 2024-02-09T12:01:07Z

⚪ 2024-02-09 12:01:06 UTC Pre-commit check for 14a11c9 has started.
⚪ 2024-02-09 12:01:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 12:45:12 UTC Build successful.
⚪ 2024-02-09 12:45:25 UTC Tests are running...
🔴 2024-02-09 13:26:22 UTC Test run completed, no test results found for commit 7943313. Please check build logs.
⚫ 2024-02-09 13:26:25 UTC Check cancelled

github-actions · 2024-02-09T13:27:37Z

⚪ 2024-02-09 13:27:36 UTC Pre-commit check for 921bb5c has started.
⚪ 2024-02-09 13:27:38 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 14:09:47 UTC Build successful.
⚪ 2024-02-09 14:10:03 UTC Tests are running...
🔴 2024-02-09 14:49:09 UTC Test run completed, no test results found for commit afa9d26. Please check build logs.
⚫ 2024-02-09 14:49:13 UTC Check cancelled

github-actions · 2024-02-09T13:27:40Z

⚪ 2024-02-09 13:27:40 UTC Pre-commit check for 921bb5c has started.
⚪ 2024-02-09 13:27:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 14:09:43 UTC Build successful.
⚪ 2024-02-09 14:09:52 UTC Tests are running...
🔴 2024-02-09 14:49:07 UTC Test run completed, no test results found for commit afa9d26. Please check build logs.
⚫ 2024-02-09 14:49:10 UTC Check cancelled

CyberROFL · 2024-02-09T13:37:34Z

ydb/public/lib/validation/helpers.h

Почему этот файл удален, а не перемещен?

Странно, изначально точно делал git mv и потом редактировал в других коммитах

ydb/public/lib/protobuf/helpers.h

ydb/core/config/protos/marker.proto

Co-authored-by: Ilnaz Nizametdinov <[email protected]>

github-actions · 2024-02-09T14:49:51Z

⚪ 2024-02-09 14:49:51 UTC Pre-commit check for 4b96cc0 has started.
⚪ 2024-02-09 14:49:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 15:40:20 UTC Build successful.
⚪ 2024-02-09 15:40:30 UTC Tests are running...
🔴 2024-02-09 17:26:30 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14737	14558	0	9	131	39

github-actions · 2024-02-09T14:50:39Z

⚪ 2024-02-09 14:50:38 UTC Pre-commit check for 4b96cc0 has started.
⚪ 2024-02-09 14:50:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 15:34:35 UTC Build successful.
⚪ 2024-02-09 15:34:49 UTC Tests are running...
🔴 2024-02-09 17:18:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
67415	56475	0	1	10903	36

Enjection added 6 commits February 8, 2024 18:41

extract protobuf helpers from validation

908497e

add additional helpers

98ee85d

add basic plugin implementation

495cc4a

mark config root

bb94b4d

fix plugin usage

ba3d3df

fix plugin usage

fd5d302

github-actions bot added the not-for-changelog label Feb 8, 2024

finish generator beautifying

286ad41

add some tests

7943313

add more tests

afa9d26

Enjection requested a review from CyberROFL February 9, 2024 13:26

Enjection marked this pull request as ready for review February 9, 2024 13:26

CyberROFL requested changes Feb 9, 2024

View reviewed changes

Update ydb/public/lib/protobuf/helpers.h

c882bbd

Co-authored-by: Ilnaz Nizametdinov <[email protected]>

CyberROFL approved these changes Feb 9, 2024

View reviewed changes

Enjection merged commit de2ba86 into ydb-platform:main Feb 9, 2024

Enjection deleted the feature/KIKIMR-21042/config-helper-pb-plugin branch February 9, 2024 18:14

niksaveliev mentioned this pull request Feb 12, 2024

Workload read without consumer and metrics fixes #1792

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching #1800

Closed

vitstn mentioned this pull request Feb 12, 2024

quick fix for column name of select version() #1801

Merged

vitstn mentioned this pull request Feb 12, 2024

Support of database sys cache #1817

Merged

starlinskiy mentioned this pull request Feb 12, 2024

runtime dispatching (fixed) #1847

Merged

serbel324 mentioned this pull request Feb 13, 2024

Improve some headers #1877

Merged

pavelvelikhov mentioned this pull request Feb 13, 2024

Fixed a problem with simplified plan JSONs #1878

Merged

serbel324 mentioned this pull request Feb 13, 2024

Reintroduce test_helpers for ut_blobstorage #1890

Merged

This was referenced Feb 13, 2024

Case insensivity for pg_catalog tables/cluster, columns. Support of pg_class:relam, and some columns in pg_database & pg_namespace #1893

Merged

fixed pg_get_userbyid function #1936

Merged

support of AnyNonArray type, fixes for array_agg #1958

Merged

pavelvelikhov mentioned this pull request Feb 15, 2024

Fixed a problem with plans in PG ut #1974

Merged

niksaveliev mentioned this pull request Feb 16, 2024

Fix kafka with enabled proxy #2017

Merged

vitstn mentioned this pull request Feb 16, 2024

mock of savepoints #2026

Merged

GrigoriyPA mentioned this pull request Feb 26, 2024

YQ-2898 fix query failed with unknown uncommitted upload issue #2240

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add proto plugin for config processing #1750

Add proto plugin for config processing #1750

Enjection commented Feb 8, 2024

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

CyberROFL Feb 9, 2024

Enjection Feb 9, 2024

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

Add proto plugin for config processing #1750

Add proto plugin for config processing #1750

Conversation

Enjection commented Feb 8, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

CyberROFL Feb 9, 2024

Choose a reason for hiding this comment

Enjection Feb 9, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 9, 2024 • edited Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 8, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading

github-actions bot commented Feb 9, 2024 •

edited

Loading