Skip to content

Fix win build #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 9, 2024
Merged

Fix win build #1760

merged 2 commits into from
Feb 9, 2024

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented Feb 9, 2024

  • Bugfix

@Hor911 Hor911 requested a review from a team as a code owner February 9, 2024 08:59
@github-actions github-actions bot added the bugfix label Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 09:02:03 UTC Pre-commit check for bbe76c3 has started.
⚪ 2024-02-09 09:02:05 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 09:03:39 UTC Build successful.
⚪ 2024-02-09 09:03:56 UTC Tests are running...
🔴 2024-02-09 10:29:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67409 56478 0 1 10892 38

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 09:02:10 UTC Pre-commit check for bbe76c3 has started.
⚪ 2024-02-09 09:02:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 09:03:48 UTC Build successful.
⚪ 2024-02-09 09:04:01 UTC Tests are running...
🔴 2024-02-09 10:43:04 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14732 14533 0 17 135 47

spuchin
spuchin previously approved these changes Feb 9, 2024
View reviewed changes
uzhastik
uzhastik previously approved these changes Feb 9, 2024
View reviewed changes
ydb/library/yql/providers/s3/provider/yql_s3_dq_integration.cpp Outdated
@@ -405,6 +405,8 @@ class TS3DqIntegration: public TDqIntegrationBase {
srcDesc.MutableSettings()->insert({"addPathIndex", "true"});
}

#if defined(_linux_) || defined(_darwin_)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

временное решение. ifdef надо в будущем убрать. очередь никак не связана с кодом CH

@Hor911 Hor911 dismissed stale reviews from uzhastik and spuchin via 7de5010 February 9, 2024 12:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 12:13:51 UTC Pre-commit check for 0897ccc has started.
⚪ 2024-02-09 12:13:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-09 12:35:01 UTC Build successful.
⚪ 2024-02-09 12:35:18 UTC Tests are running...
🔴 2024-02-09 14:06:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67415 56476 0 2 10904 33

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

⚪ 2024-02-09 12:14:05 UTC Pre-commit check for 0897ccc has started.
⚪ 2024-02-09 12:14:07 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-09 12:37:21 UTC Build successful.
⚪ 2024-02-09 12:37:34 UTC Tests are running...
🔴 2024-02-09 14:19:24 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14744 14533 0 23 139 49

@Hor911 Hor911 merged commit 1717439 into ydb-platform:main Feb 9, 2024
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
@serbel324 serbel324 mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 17, 2024
Merged
This was referenced Feb 19, 2024
Merged
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
Hor911 added a commit to Hor911/ydb that referenced this pull request Mar 3, 2024
@Hor911
Fix win build (ydb-platform#1760)
5636c6d 
* Fix win build

* Disable RuntimeListing until refactoring to eliminate unwanted dependencies
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 5, 2024
@Hor911 @EgorkaZ
Fix win build (ydb-platform#1760)
cdea1b7 
* Fix win build

* Disable RuntimeListing until refactoring to eliminate unwanted dependencies
EgorkaZ pushed a commit to EgorkaZ/ydb that referenced this pull request Apr 8, 2024
@Hor911 @EgorkaZ
Fix win build (ydb-platform#1760)
567ea76 
* Fix win build

* Disable RuntimeListing until refactoring to eliminate unwanted dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

@spuchin spuchin spuchin left review comments

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hor911 @spuchin @uzhastik