Docs: fix --warmup option name for topic workload command #2483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/ydb-platform/ydb/blob/8945dcc074687117fc1b8b730c360de78e624e21/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_full.cpp#L34 https://github.com/ydb-platform/ydb/blob/8945dcc074687117fc1b8b730c360de78e624e21/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_read.cpp#L31 https://github.com/ydb-platform/ydb/blob/8945dcc074687117fc1b8b730c360de78e624e21/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_write.cpp#L34
✅ Documentation buildRevision built successfully |
✅ Documentation buildRevision built successfully |
blinkov
approved these changes
Mar 12, 2024
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
Merged
Merged
This was referenced Mar 29, 2024
Merged
This was referenced Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the docs the option is called
--warmup-time, but the correct name is--warmup:ydb/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_full.cpp
Line 34 in 8945dcc
ydb/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_read.cpp
Line 31 in 8945dcc
ydb/ydb/public/lib/ydb_cli/commands/topic_workload/topic_workload_run_write.cpp
Line 34 in 8945dcc