Fix race between table merge and borrowed gc compaction. Fixes #3154. #3164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
azevaykin
approved these changes
Mar 26, 2024
This was referenced Mar 29, 2024
Merged
This was referenced Apr 4, 2024
Merged
This was referenced Apr 6, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Fixed a race between table merge and borrowed gc compaction.
Changelog category
Additional information
A fix in #2286 introduced a race, where datashard allowed local database to compact borrowed data before all borrowed data is actually loaded and merged into the table. This caused local database borrowed compaction to later fail due to unexpected epoch invariant violations.
Fixes #3154.