You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TCallbackContext::LockShared method creates a new TBorrowed object. Its constructor acquires a shared_lock on the mutex stored in the TCallbackContext object.
TCallbackContext::LockShared method creates a new TBorrowed object. Its constructor acquires a shared_lock on a mutex stored in the TCallbackContext object.
In a rare situation the LockShared method is called twice in a row from the same thread, but calling lock_shared more than once without releasing the lock leads to undefined behaviour (see https://en.cppreference.com/w/cpp/thread/shared_mutex/lock_shared).
In general, recursive mutexes are frowned upon, but in our case it looks to be the most elegant solution to the problem at hand.
⚪ 2024-05-07 13:49:44 UTC Pre-commit check for 6bf4b4a has started.
⚪ 2024-05-07 13:49:47 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-07 13:52:47 UTC Build successful.
⚪ 2024-05-07 13:49:50 UTC Pre-commit check for 6bf4b4a has started.
⚪ 2024-05-07 13:49:53 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-07 13:53:05 UTC Build successful.
⚪ 2024-05-07 13:54:54 UTC Tests are running...
🔴 2024-05-07 13:58:36 UTC Test run completed, no test results found for commit 7c28599. Please check build logs.
⚫ 2024-05-07 13:58:39 UTC Check cancelled
⚪ 2024-05-07 13:54:05 UTC Pre-commit check for 6bf4b4a has started.
⚪ 2024-05-07 13:54:06 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-07 13:57:08 UTC Build successful.
⚫ 2024-05-07 13:58:34 UTC Check cancelled
⚪ 2024-05-07 17:03:28 UTC Pre-commit check for f2f777b has started.
⚪ 2024-05-07 17:03:30 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-05-07 17:06:00 UTC Build successful.
⚪ 2024-05-07 17:07:38 UTC Tests are running...
🔴 2024-05-07 18:38:17 UTC Some tests failed, follow the links below.
⚪ 2024-05-07 16:58:41 UTC Pre-commit check for f2f777b has started.
⚪ 2024-05-07 16:58:43 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-05-07 17:04:09 UTC Build successful.
⚪ 2024-05-07 17:10:07 UTC Pre-commit check for f2f777b has started.
⚪ 2024-05-07 17:10:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-05-07 17:15:19 UTC Build successful.
⚪ 2024-05-07 17:16:56 UTC Tests are running...
🔴 2024-05-07 18:53:56 UTC Some tests failed, follow the links below.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCallbackContext::LockShared method creates a new TBorrowed object. Its constructor acquires a shared_lock on the mutex stored in the TCallbackContext object.
In a rare situation the LockShared method is called twice in a row from the same thread, but calling lock_shared more than once without releasing the lock leads to undefined behaviour (see https://en.cppreference.com/w/cpp/thread/shared_mutex/lock_shared).
In general, recursive mutexes are frowned upon, but in our case it looks to be the most elegant solution to the problem at hand.