Remove the dependency on the S3 provider implementation #5150

andrewstalin · 2024-06-04T07:34:57Z

Changelog entry

Separated the implementation of the S3 provider from the declaration so that we did not need to link unnecessary static libraries where it was not really needed. A stub is used instead of the real implementation.

Changelog category

Not for changelog (changelog entry is not required)

Additional information

github-actions · 2024-06-04T07:57:33Z

⚪ 2024-06-04 07:57:33 UTC Pre-commit check for e84ca51 has started.
⚪ 2024-06-04 08:00:07 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-04 08:13:07 UTC Build successful.

github-actions · 2024-06-04T07:57:35Z

⚪ 2024-06-04 07:57:35 UTC Pre-commit check for e84ca51 has started.
⚪ 2024-06-04 08:00:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-04 08:14:25 UTC Build successful.
⚪ 2024-06-04 08:14:40 UTC Tests are running...
🔴 2024-06-04 09:51:22 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38378	33553	0	19	4799	7

github-actions · 2024-06-04T07:57:36Z

⚪ 2024-06-04 07:57:36 UTC Pre-commit check for e84ca51 has started.
⚪ 2024-06-04 08:00:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-04 08:14:31 UTC Build successful.
⚪ 2024-06-04 08:14:43 UTC Tests are running...
🔴 2024-06-04 10:16:15 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10787	10708	0	41	23	15

github-actions · 2024-06-04T10:32:05Z

⚪ 2024-06-04 10:32:05 UTC Pre-commit check for 9b6c941 has started.
⚪ 2024-06-04 10:34:35 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-04 10:48:23 UTC Build successful.
⚪ 2024-06-04 10:48:36 UTC Tests are running...
🔴 2024-06-04 12:40:35 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10777	10716	0	25	28	8

github-actions · 2024-06-04T10:33:51Z

⚪ 2024-06-04 10:33:51 UTC Pre-commit check for 9b6c941 has started.
⚪ 2024-06-04 10:36:26 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-04 10:53:45 UTC Build successful.

github-actions · 2024-06-04T10:34:12Z

⚪ 2024-06-04 10:34:12 UTC Pre-commit check for 9b6c941 has started.
⚪ 2024-06-04 10:36:46 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-04 10:50:53 UTC Build successful.
⚪ 2024-06-04 10:51:07 UTC Tests are running...
🔴 2024-06-04 12:27:31 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38394	33586	0	4	4799	5

ydb/core/fq/libs/compute/common/ya.make

ydb/library/yql/providers/s3/actors/yql_s3_actors_factory.cpp

ydb/library/yql/providers/s3/actors/yql_s3_actors_factory.h

github-actions · 2024-06-06T03:31:20Z

⚪ 2024-06-06 03:31:20 UTC Pre-commit check for 7088049 has started.
⚪ 2024-06-06 03:33:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-06 03:46:46 UTC Build successful.

github-actions · 2024-06-06T03:31:26Z

⚪ 2024-06-06 03:31:26 UTC Pre-commit check for 7088049 has started.
⚪ 2024-06-06 03:34:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-06 03:48:43 UTC Build successful.
⚪ 2024-06-06 03:48:59 UTC Tests are running...
🔴 2024-06-06 05:30:44 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38498	33648	0	6	4834	10

github-actions · 2024-06-06T03:31:33Z

⚪ 2024-06-06 03:31:33 UTC Pre-commit check for 7088049 has started.
⚪ 2024-06-06 03:34:08 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-06 03:49:16 UTC Build successful.
⚪ 2024-06-06 03:49:30 UTC Tests are running...
🔴 2024-06-06 05:49:10 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10827	10759	0	35	23	10

github-actions · 2024-06-06T07:49:17Z

⚪ 2024-06-06 07:49:16 UTC Pre-commit check for acfae2f has started.
⚪ 2024-06-06 07:51:51 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-06 08:29:45 UTC Build successful.

github-actions · 2024-06-06T07:49:21Z

⚪ 2024-06-06 07:49:21 UTC Pre-commit check for acfae2f has started.
⚪ 2024-06-06 07:51:54 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-06 08:06:44 UTC Build successful.
⚪ 2024-06-06 08:07:00 UTC Tests are running...
🔴 2024-06-06 10:09:18 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10829	10765	0	29	26	9

github-actions · 2024-06-06T07:49:27Z

⚪ 2024-06-07 10:58:41 UTC Pre-commit check for acfae2f has started.
⚪ 2024-06-07 11:01:23 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-07 11:02:39 UTC Build successful.
⚪ 2024-06-07 11:02:56 UTC Tests are running...
🔴 2024-06-07 12:44:11 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38502	33654	0	6	4835	7

ydb/library/yql/providers/s3/actors_factory/ya.make

ydb/core/kqp/compute_actor/ya.make

ydb/core/fq/libs/compute/common/ya.make

ydb/core/kqp/node_service/kqp_node_ut.cpp

ydb/core/kqp/proxy_service/kqp_proxy_service.h

ydb/core/kqp/ut/common/kqp_ut_common.h

ydb/core/kqp/ut/federated_query/common/common.h

github-actions · 2024-06-10T04:02:41Z

⚪ 2024-06-10 04:02:41 UTC Pre-commit check for 68a854d has started.
⚪ 2024-06-10 04:05:16 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-10 04:19:10 UTC Build successful.

github-actions · 2024-06-10T04:02:55Z

⚪ 2024-06-10 04:02:55 UTC Pre-commit check for 68a854d has started.
⚪ 2024-06-10 04:05:34 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-10 04:21:52 UTC Build successful.
⚪ 2024-06-10 04:22:08 UTC Tests are running...
🔴 2024-06-10 06:21:54 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10819	10744	0	26	40	9

github-actions · 2024-06-10T04:03:03Z

⚪ 2024-06-10 04:03:03 UTC Pre-commit check for 68a854d has started.
⚪ 2024-06-10 04:05:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-10 04:20:03 UTC Build successful.
⚪ 2024-06-10 04:20:17 UTC Tests are running...
🔴 2024-06-10 05:56:07 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
38555	33707	0	2	4837	9

Remove the dependency on the S3 provider implementation

09db2c1

andrewstalin requested review from a team as code owners June 4, 2024 07:34

github-actions bot added the not-for-changelog label Jun 4, 2024

merge with main

e235b77

andrewstalin added 2 commits June 4, 2024 10:24

fix GenericFederatedQuery ut

fedf31f

merge with main

3532562

uzhastik reviewed Jun 4, 2024

View reviewed changes

fix review remarks

b27fbdc

andrewstalin requested a review from uzhastik June 6, 2024 03:29

fix unit test

cb4d5b9

uzhastik reviewed Jun 7, 2024

View reviewed changes

ydb/library/yql/providers/s3/actors_factory/ya.make Outdated Show resolved Hide resolved

uzhastik reviewed Jun 7, 2024

View reviewed changes

ydb/core/kqp/compute_actor/ya.make Show resolved Hide resolved

uzhastik reviewed Jun 7, 2024

View reviewed changes

ydb/core/fq/libs/compute/common/ya.make Show resolved Hide resolved

uzhastik reviewed Jun 7, 2024

View reviewed changes

ydb/core/kqp/node_service/kqp_node_ut.cpp Outdated Show resolved Hide resolved

ydb/core/kqp/proxy_service/kqp_proxy_service.h Show resolved Hide resolved

ydb/core/kqp/ut/common/kqp_ut_common.h Show resolved Hide resolved

ydb/core/kqp/ut/federated_query/common/common.h Show resolved Hide resolved

andrewstalin added 2 commits June 10, 2024 03:40

fix ya.make

edcdd6d

merge with master

ec1e132

andrewstalin requested a review from uzhastik June 10, 2024 07:20

uzhastik approved these changes Jun 11, 2024

View reviewed changes

vitstn approved these changes Jun 11, 2024

View reviewed changes

andrewstalin merged commit 052ab22 into ydb-platform:main Jun 11, 2024
8 of 12 checks passed

This was referenced Jun 11, 2024

metadata cache keeps merged issues #5461

Merged

json_hc metadata cache #5465

Merged

GrigoriyPA mentioned this pull request Jun 13, 2024

YQ-3333 added yql syntax for creating resource pools #5498

Merged

andrewstalin deleted the removing-clickhouse-deps-di branch June 13, 2024 11:40

This was referenced Jun 14, 2024

json tenantinfo status metadata cache #5543

Merged

json query transaction mode #5574

Merged

This was referenced Jun 15, 2024

YQ-3225 detached script execution results forgetting #5598

Merged

YQ-3346 improve secrets fetching #5614

Merged

YQ-3342 fix script results writing #5682

Merged

StekPerepolnen mentioned this pull request Jun 19, 2024

hc api doc #5703

Merged

This was referenced Jun 19, 2024

WM passed resource pool settings to user request context #5734

Merged

YQ splitted fq/s3/test_s3.py tests #5798

Merged

This was referenced Jun 23, 2024

move time difference issue under database level #5859

Merged

metadata requests flags fix #5860

Merged

oidc-proxy new iam 2 #6059

Merged

Remove the dependency on the S3 provider implementation #5150

Remove the dependency on the S3 provider implementation #5150

Uh oh!

Conversation

andrewstalin commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog entry

Changelog category

Additional information

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andrewstalin commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 4, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 6, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading

github-actions bot commented Jun 10, 2024 •

edited

Loading