Fix lock in Immediate Control Board #5290

[the-ancient-1]

Changelog entry

Do not use write lock in ICB when read lock is enough. Use swap to prevent read-check-write races.

Changelog category

• Bugfix

Additional information

This may fix some latency issues.

[github-actions]

⚪ 2024-06-06 14:08:46 UTC Pre-commit check for 178e007 has started.
⚪ 2024-06-06 14:11:24 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-06 14:44:42 UTC Build successful.

[github-actions]

⚪ 2024-06-06 14:10:13 UTC Pre-commit check for 178e007 has started.
⚪ 2024-06-06 14:13:00 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-06 14:53:10 UTC Build successful.
⚪ 2024-06-06 14:53:24 UTC Tests are running...
🔴 2024-06-06 16:28:59 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
38636	33779	0	11	4837	9

[github-actions]

⚪ 2024-06-06 14:14:29 UTC Pre-commit check for 178e007 has started.
⚪ 2024-06-06 14:17:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-06 14:57:46 UTC Build successful.
⚪ 2024-06-06 14:57:56 UTC Tests are running...
🔴 2024-06-06 16:56:02 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
10911	10830	0	36	30	15

[github-actions]

⚪ 2024-07-23 17:48:24 UTC Pre-commit check for 95b0aef has started.
⚪ 2024-07-23 17:51:23 UTC Build+Tests linux-x86_64-release-clang14 is running...
🟢 2024-07-23 18:27:48 UTC Build successful.

[github-actions]

⚪ 2024-07-23 17:49:14 UTC Pre-commit check for 95b0aef has started.
⚪ 2024-07-23 17:52:18 UTC Build+Tests linux-x86_64-relwithdebinfo is running...
🟢 2024-07-23 20:06:24 UTC Build successful.
🔴 2024-07-23 20:10:53 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
39745	34452	0	2	5278	13

🟢 2024-07-23 20:11:35 UTC ydbd size 8.1 GiB changed* by -7.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: abe4d5b	merge: 95b0aef	diff	diff %
ydbd size	8 652 686 752 Bytes	8 652 678 744 Bytes	-7.8 KiB	-0.000%
ydbd stripped size	471 059 936 Bytes	471 059 936 Bytes	0 Bytes	0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2024-07-23 17:50:06 UTC Pre-commit check for 95b0aef has started.
⚪ 2024-07-23 17:53:08 UTC Build+Tests linux-x86_64-release-asan is running...
🟢 2024-07-23 20:35:44 UTC Build successful.
🔴 2024-07-23 20:38:27 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
11060	10454	0	105	327	174

🟢 2024-07-23 20:39:24 UTC ydbd size 5.2 GiB changed* by +8.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: abe4d5b	merge: 95b0aef	diff	diff %
ydbd size	5 556 151 216 Bytes	5 556 159 440 Bytes	+8.0 KiB	+0.000%
ydbd stripped size	1 196 797 904 Bytes	1 196 797 840 Bytes	-64 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}