Skip to content

TTableHistogramBuilderBtreeIndex improvements #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 17, 2024
Merged

TTableHistogramBuilderBtreeIndex improvements #5451

merged 12 commits into from
Jun 17, 2024

Conversation

kunga
Copy link
Member

@kunga kunga commented Jun 11, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

  • Add benchmark part count param
  • Search for 10 histogram buckets instead of fixed resolution
  • Measure TSpent for BuildStats

@kunga kunga changed the title remove slices, add parts count Benchmark new B-Tree stat histogram builder Jun 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 11:25:12 UTC Pre-commit check for 36a7747 has started.
⚪ 2024-06-11 11:27:04 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-11 11:28:38 UTC Build successful.
⚪ 2024-06-11 11:28:47 UTC Tests are running...
🔴 2024-06-11 11:29:24 UTC Test run completed, no test results found for commit 3693cb5. Please check test log.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 11:30:22 UTC Pre-commit check for 36a7747 has started.
⚪ 2024-06-11 11:32:14 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-11 11:40:30 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 11:40:49 UTC Pre-commit check for 36a7747 has started.
⚪ 2024-06-11 11:42:40 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-11 11:44:09 UTC Build successful.
⚪ 2024-06-11 11:44:19 UTC Tests are running...
🔴 2024-06-11 11:45:25 UTC Test run completed, no test results found for commit 3693cb5. Please check test log.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 16:30:34 UTC Pre-commit check for d1e35fa has started.
⚪ 2024-06-11 16:33:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-11 16:53:10 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 16:30:47 UTC Pre-commit check for d1e35fa has started.
⚪ 2024-06-11 16:33:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-11 16:56:17 UTC Build successful.
⚪ 2024-06-11 16:56:33 UTC Tests are running...
🔴 2024-06-11 18:45:27 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38765 33886 0 9 4858 12

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚪ 2024-06-11 16:31:05 UTC Pre-commit check for d1e35fa has started.
⚪ 2024-06-11 16:33:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-11 16:58:40 UTC Build successful.
⚪ 2024-06-11 16:58:55 UTC Tests are running...
🔴 2024-06-11 18:51:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10947 10885 0 24 24 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:31:56 UTC Pre-commit check for 58ae0d6 has started.
⚪ 2024-06-12 10:34:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-12 10:37:10 UTC Build successful.
⚪ 2024-06-12 10:37:24 UTC Tests are running...
🔴 2024-06-12 10:48:19 UTC Test run completed, no test results found for commit efe1a5c. Please check test log.
⚫ 2024-06-12 10:48:45 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:31:58 UTC Pre-commit check for 58ae0d6 has started.
⚪ 2024-06-12 10:34:36 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-12 10:37:03 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:32:12 UTC Pre-commit check for 58ae0d6 has started.
⚪ 2024-06-12 10:34:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-12 10:37:51 UTC Build successful.
⚪ 2024-06-12 10:38:04 UTC Tests are running...
🔴 2024-06-12 10:48:26 UTC Test run completed, no test results found for commit efe1a5c. Please check test log.
⚫ 2024-06-12 10:48:52 UTC Check cancelled

@kunga kunga force-pushed the test-btree-histogram branch from efe1a5c to 8c98388 Compare June 12, 2024 10:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:51:48 UTC Pre-commit check for c01fd44 has started.
⚪ 2024-06-12 10:54:26 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-12 10:55:34 UTC Build successful.
⚪ 2024-06-12 10:55:46 UTC Tests are running...
🔴 2024-06-12 12:43:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38765 33930 0 13 4812 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:52:40 UTC Pre-commit check for c01fd44 has started.
⚪ 2024-06-12 10:55:19 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-12 10:56:27 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

⚪ 2024-06-12 10:52:48 UTC Pre-commit check for c01fd44 has started.
⚪ 2024-06-12 10:55:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-12 10:56:35 UTC Build successful.
⚪ 2024-06-12 10:56:47 UTC Tests are running...
🔴 2024-06-12 12:45:12 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10950 10881 0 26 25 18

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 08:59:22 UTC Pre-commit check for 2b2a108 has started.
⚪ 2024-06-13 09:02:01 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-13 09:04:28 UTC Build successful.
⚪ 2024-06-13 09:04:44 UTC Tests are running...
🔴 2024-06-13 10:48:32 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10953 10893 0 22 24 14

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 08:59:24 UTC Pre-commit check for 2b2a108 has started.
⚪ 2024-06-13 09:02:08 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-13 09:04:37 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 08:59:26 UTC Pre-commit check for 2b2a108 has started.
⚪ 2024-06-13 09:02:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-13 09:04:29 UTC Build successful.
⚪ 2024-06-13 09:04:44 UTC Tests are running...
🔴 2024-06-13 10:47:55 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38770 33930 0 11 4812 17

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 14:57:07 UTC Pre-commit check for 395bca9 has started.
⚪ 2024-06-13 15:00:08 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-13 15:27:43 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 15:02:23 UTC Pre-commit check for 395bca9 has started.
⚪ 2024-06-13 15:04:59 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-13 15:29:05 UTC Build failed. see the build logs.
🔴 2024-06-13 15:29:07 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 15:24:24 UTC Pre-commit check for 395bca9 has started.
⚪ 2024-06-13 15:27:00 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-13 15:49:37 UTC Build failed. see the build logs.
🔴 2024-06-13 15:49:38 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 17:38:40 UTC Pre-commit check for 847ded3 has started.
⚪ 2024-06-13 17:41:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-13 17:47:21 UTC Build successful.
⚪ 2024-06-13 17:47:35 UTC Tests are running...
🔴 2024-06-13 19:27:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10966 10917 0 15 24 10

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 17:39:03 UTC Pre-commit check for 847ded3 has started.
⚪ 2024-06-13 17:41:50 UTC Build linux-x86_64-release-clang14 is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 13, 2024 •
edited
Loading

⚪ 2024-06-13 17:39:19 UTC Pre-commit check for 847ded3 has started.
⚪ 2024-06-13 17:42:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-13 17:48:11 UTC Build successful.
⚪ 2024-06-13 17:48:26 UTC Tests are running...
🔴 2024-06-13 19:44:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38873 34052 0 1 4811 9

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 10:54:44 UTC Pre-commit check for abccb5c has started.
⚪ 2024-06-14 10:57:17 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-14 11:17:33 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 10:57:01 UTC Pre-commit check for abccb5c has started.
⚪ 2024-06-14 10:59:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-14 11:22:40 UTC Build successful.
⚪ 2024-06-14 11:22:51 UTC Tests are running...
🟢 2024-06-14 13:08:53 UTC Tests successful.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
38983 34163 0 0 4811 9

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

⚪ 2024-06-14 10:57:10 UTC Pre-commit check for abccb5c has started.
⚪ 2024-06-14 10:59:48 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-14 11:22:38 UTC Build successful.
⚪ 2024-06-14 11:22:50 UTC Tests are running...
🔴 2024-06-14 13:06:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10965 10912 0 19 24 10

@kunga kunga changed the title Benchmark new B-Tree stat histogram builder TableHistogramBuilderBtreeIndex improvements Jun 14, 2024
@kunga kunga changed the title TableHistogramBuilderBtreeIndex improvements TTableHistogramBuilderBtreeIndex improvements Jun 14, 2024
@kunga kunga requested a review from snaury June 14, 2024 13:11
@kunga kunga merged commit f93a9f3 into ydb-platform:main Jun 17, 2024
13 of 15 checks passed
@kunga kunga self-assigned this Jun 17, 2024
This was referenced Jun 18, 2024
Merged
Merged
Merged
This was referenced Jun 23, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snaury snaury snaury approved these changes

Assignees

@kunga kunga

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunga @snaury