Skip to content

Literals for big tz types #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

Literals for big tz types #5739

merged 2 commits into from
Jun 20, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jun 19, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner June 19, 2024 15:23
@vitstn vitstn requested review from nepal and igormunkin June 19, 2024 15:23
@vitstn vitstn added the area/yql YQL query language issues label Jun 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 15:29:32 UTC Pre-commit check for fc5692a has started.
⚪ 2024-06-19 15:32:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 15:35:24 UTC Build successful.
⚪ 2024-06-19 15:35:38 UTC Tests are running...
🔴 2024-06-19 17:28:42 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14790 14593 0 35 154 8

🟡 2024-06-19 17:29:13 UTC merge: fc5692a ydbd size 5.7 GiB +415.2 KiB +0.007% vs build main: de4dd76

Build size details

main: de4dd76 ydbd build size:

  • binary size 6 148 763 632 Bytes
  • stripped binary size 1 527 413 120 Bytes

merge: fc5692a ydbd build size:

  • binary size 6 149 188 816 Bytes
  • stripped binary size 1 527 528 256 Bytes

ydbd size dashboard

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 15:36:27 UTC Pre-commit check for fc5692a has started.
⚪ 2024-06-19 15:39:04 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-19 15:43:29 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 15:44:34 UTC Pre-commit check for fc5692a has started.
⚪ 2024-06-19 15:47:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 15:50:25 UTC Build successful.
⚪ 2024-06-19 15:50:40 UTC Tests are running...
🔴 2024-06-19 17:56:05 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75237 62146 0 5 13078 8

🟡 2024-06-19 17:56:54 UTC merge: fc5692a ydbd size 8.6 GiB +426.7 KiB +0.005% vs build main: de4dd76

Build size details

main: de4dd76 ydbd build size:

  • binary size 9 212 645 104 Bytes
  • stripped binary size 711 238 128 Bytes

merge: fc5692a ydbd build size:

  • binary size 9 213 082 072 Bytes
  • stripped binary size 711 272 880 Bytes

ydbd size dashboard

nepal
nepal previously approved these changes Jun 19, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 09:31:28 UTC Pre-commit check for 462a4b6 has started.
⚪ 2024-06-20 09:34:11 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-20 09:37:25 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 09:32:14 UTC Pre-commit check for 462a4b6 has started.
⚪ 2024-06-20 09:34:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-20 09:37:28 UTC Build successful.
⚪ 2024-06-20 09:37:45 UTC Tests are running...
🔴 2024-06-20 11:40:00 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14789 14703 0 29 43 14

🟡 2024-06-20 11:40:44 UTC ydbd size 5.7 GiB changed by +415.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 5bff5d6 merge: 462a4b6 diff diff %
ydbd size 6 148 832 040 Bytes 6 149 257 224 Bytes +415.2 KiB +0.007%
ydbd stripped size 1 527 394 048 Bytes 1 527 509 184 Bytes +112.4 KiB +0.008%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 20, 2024 •
edited
Loading

⚪ 2024-06-20 09:32:22 UTC Pre-commit check for 462a4b6 has started.
⚪ 2024-06-20 09:35:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-20 09:38:22 UTC Build successful.
⚪ 2024-06-20 09:38:33 UTC Tests are running...
🔴 2024-06-20 12:10:16 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75245 62106 0 8 13119 12

🟢 2024-06-20 12:11:03 UTC ydbd size 8.6 GiB changed by +5.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 43d5e45 merge: 462a4b6 diff diff %
ydbd size 9 214 548 552 Bytes 9 214 554 208 Bytes +5.5 KiB +0.000%
ydbd stripped size 711 277 424 Bytes 711 295 408 Bytes +17.6 KiB +0.003%

@vitstn vitstn requested a review from nepal June 20, 2024 11:44
igormunkin
igormunkin approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM, but please consider my nit below.

@vitstn vitstn merged commit cc73f2c into ydb-platform:main Jun 20, 2024
8 of 12 checks passed
@vitstn vitstn deleted the bigtz_literals branch June 20, 2024 14:30
@GrigoriyPA GrigoriyPA mentioned this pull request Jun 20, 2024
Merged
This was referenced Jun 21, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igormunkin igormunkin igormunkin approved these changes

@nepal nepal Awaiting requested review from nepal

Assignees
No one assigned
Labels
area/yql YQL query language issues new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitstn @nepal @igormunkin