Skip to content

Implement external blob precharge in read iterator #5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 12, 2024

Conversation

SammyVimes
Copy link
Collaborator

Changelog category

  • Improvement

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 23:00:53 UTC Pre-commit check for 1abad0c has started.
2024-06-19 23:03:44 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-19 23:27:48 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 23:00:59 UTC Pre-commit check for 1abad0c has started.
2024-06-19 23:03:48 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-19 23:33:40 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 19, 2024

2024-06-19 23:01:02 UTC Pre-commit check for 1abad0c has started.
2024-06-19 23:03:54 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-19 23:27:04 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 10:42:07 UTC Pre-commit check for bd1178e has started.
2024-06-20 10:44:43 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-20 10:56:18 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 10:56:42 UTC Pre-commit check for bd1178e has started.
2024-06-20 10:59:16 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-20 11:14:57 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 11:01:53 UTC Pre-commit check for bd1178e has started.
2024-06-20 11:05:06 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-20 11:18:50 UTC Build failed. see the build logs.

@SammyVimes SammyVimes requested a review from kunga June 20, 2024 11:15
Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 16:44:12 UTC Pre-commit check for 0c6dfa7 has started.
2024-06-20 16:46:51 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-20 17:08:26 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 16:56:30 UTC Pre-commit check for 0c6dfa7 has started.
2024-06-20 16:59:02 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-20 17:21:00 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 16:57:14 UTC Pre-commit check for 0c6dfa7 has started.
2024-06-20 16:59:56 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-20 17:29:24 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 18:19:13 UTC Pre-commit check for c2e74fc has started.
2024-06-20 18:21:46 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-20 18:40:45 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 18:45:25 UTC Pre-commit check for c2e74fc has started.
2024-06-20 18:48:01 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-20 19:07:22 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 20, 2024

2024-06-20 18:47:36 UTC Pre-commit check for c2e74fc has started.
2024-06-20 18:50:08 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-20 19:12:46 UTC Build failed. see the build logs.

@kunga kunga self-assigned this Jun 21, 2024
Copy link

github-actions bot commented Jun 24, 2024

2024-06-24 14:09:45 UTC Pre-commit check for eccba6c has started.
2024-06-24 14:12:32 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-24 14:41:30 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 24, 2024

2024-06-24 14:10:00 UTC Pre-commit check for eccba6c has started.
2024-06-24 14:12:43 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-24 14:35:10 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 24, 2024

2024-06-24 14:10:42 UTC Pre-commit check for eccba6c has started.
2024-06-24 14:13:21 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-24 14:36:26 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jun 25, 2024

2024-06-25 10:33:35 UTC Pre-commit check for b368271 has started.
2024-06-25 10:36:22 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-25 11:02:37 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 18:07:06 UTC Pre-commit check for 20d786d has started.
2024-07-03 18:10:23 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-03 18:46:20 UTC Build successful.

Copy link

github-actions bot commented Jul 3, 2024

2024-07-03 18:11:02 UTC Pre-commit check for 20d786d has started.
2024-07-03 18:13:54 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-03 19:12:35 UTC Build successful.
2024-07-03 19:12:46 UTC Tests are running...
🔴 2024-07-03 21:07:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39593 34396 0 1 5185 11

🟢 2024-07-03 21:08:10 UTC ydbd size 8.2 GiB changed* by -144.8 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4313e61 merge: 20d786d diff diff %
ydbd size 8 926 807 512 Bytes 8 774 926 848 Bytes -144.8 MiB -1.701%
ydbd stripped size 486 814 568 Bytes 482 678 216 Bytes -3.9 MiB -0.850%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 13:31:55 UTC Pre-commit check for 960f857 has started.
2024-07-08 13:35:21 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-08 14:32:48 UTC Build successful.
2024-07-08 14:33:02 UTC Tests are running...
🔴 2024-07-08 16:17:22 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39653 34421 0 1 5219 12

🟢 2024-07-08 16:18:01 UTC ydbd size 8.1 GiB changed* by +25.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f94fdc3 merge: 960f857 diff diff %
ydbd size 8 709 191 648 Bytes 8 709 217 576 Bytes +25.3 KiB +0.000%
ydbd stripped size 475 593 336 Bytes 475 598 712 Bytes +5.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 13:37:55 UTC Pre-commit check for 960f857 has started.
2024-07-08 13:40:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-08 14:24:18 UTC Build successful.
2024-07-08 14:24:30 UTC Tests are running...
🔴 2024-07-08 16:24:24 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11144 10559 0 86 326 173

🟢 2024-07-08 16:25:03 UTC ydbd size 5.2 GiB changed* by +12.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6e9dd6a merge: 960f857 diff diff %
ydbd size 5 605 978 616 Bytes 5 605 991 768 Bytes +12.8 KiB +0.000%
ydbd stripped size 1 206 528 824 Bytes 1 206 532 408 Bytes +3.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 8, 2024

2024-07-08 13:39:43 UTC Pre-commit check for 960f857 has started.
2024-07-08 13:43:08 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-08 14:17:57 UTC Build successful.

@SammyVimes SammyVimes requested a review from snaury July 9, 2024 10:34
Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 11:00:47 UTC Pre-commit check for 5118f04 has started.
2024-07-09 11:03:42 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-09 11:46:40 UTC Build successful.
2024-07-09 11:46:52 UTC Tests are running...
🔴 2024-07-09 13:55:03 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11129 10532 0 94 327 176

🟢 2024-07-09 13:55:52 UTC ydbd size 5.2 GiB changed* by -72.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 5118f04 diff diff %
ydbd size 5 610 940 168 Bytes 5 610 865 832 Bytes -72.6 KiB -0.001%
ydbd stripped size 1 206 606 616 Bytes 1 206 605 272 Bytes -1.3 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 11:03:16 UTC Pre-commit check for 5118f04 has started.
2024-07-09 11:06:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-09 11:42:47 UTC Build successful.

Copy link

github-actions bot commented Jul 9, 2024

2024-07-09 12:34:24 UTC Pre-commit check for 5118f04 has started.
2024-07-09 12:37:35 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-09 13:34:43 UTC Build successful.
2024-07-09 13:34:57 UTC Tests are running...
🔴 2024-07-09 15:15:43 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39661 34422 0 4 5219 16

🟢 2024-07-09 15:16:25 UTC ydbd size 8.1 GiB changed* by -192.4 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0fa3052 merge: 5118f04 diff diff %
ydbd size 8 720 569 560 Bytes 8 720 372 552 Bytes -192.4 KiB -0.002%
ydbd stripped size 474 992 800 Bytes 474 987 872 Bytes -4.8 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@SammyVimes SammyVimes requested a review from snaury July 11, 2024 13:11
Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:15:30 UTC Pre-commit check for 10b458d has started.
2024-07-11 13:18:15 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-11 13:50:42 UTC Build successful.

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:15:33 UTC Pre-commit check for 10b458d has started.
2024-07-11 13:18:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-11 13:58:43 UTC Build successful.
2024-07-11 13:58:56 UTC Tests are running...
🔴 2024-07-11 15:57:40 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11125 10541 0 84 322 178

🟢 2024-07-11 15:58:28 UTC ydbd size 5.2 GiB changed* by +18.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 21bdc0e merge: 10b458d diff diff %
ydbd size 5 607 929 432 Bytes 5 607 947 912 Bytes +18.0 KiB +0.000%
ydbd stripped size 1 207 237 168 Bytes 1 207 241 584 Bytes +4.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 11, 2024

2024-07-11 13:15:42 UTC Pre-commit check for 10b458d has started.
2024-07-11 13:18:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-11 14:17:25 UTC Build successful.
2024-07-11 14:17:39 UTC Tests are running...
🔴 2024-07-11 16:03:13 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39641 34404 0 1 5219 17

🟢 2024-07-11 16:03:49 UTC ydbd size 8.1 GiB changed* by +24.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 21bdc0e merge: 10b458d diff diff %
ydbd size 8 717 047 464 Bytes 8 717 072 368 Bytes +24.3 KiB +0.000%
ydbd stripped size 475 511 184 Bytes 475 512 848 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants